Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Uptime] add monitor management docs link #130558

Merged
merged 1 commit into from
Apr 19, 2022
Merged

[Uptime] add monitor management docs link #130558

merged 1 commit into from
Apr 19, 2022

Conversation

dominiqueclarke
Copy link
Contributor

Fixes: elastic/uptime#468

Monitor Management

Updates the Read the docs link to point to the WIP Synthetics Private Beta docs.

Screen Shot 2022-04-19 at 9 23 46 AM

Screen Shot 2022-04-19 at 9 22 32 AM

Screen Shot 2022-04-19 at 9 24 01 AM

@dominiqueclarke dominiqueclarke added bug Fixes for quality problems that affect the customer experience Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v8.2.0 v8.3.0 labels Apr 19, 2022
@dominiqueclarke dominiqueclarke requested a review from a team as a code owner April 19, 2022 13:30
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

colleenmcginnis
colleenmcginnis reviewed Apr 19, 2022
View reviewed changes
.../plugins/uptime/public/components/monitor_management/monitor_list/enablement_empty_state.tsx
@@ -102,15 +105,15 @@ const MONITOR_MANAGEMENT_ENABLEMENT_MESSAGE = i18n.translate(
'xpack.uptime.monitorManagement.emptyState.enablement',
{
defaultMessage:
'Enable Monitor Management to run lightweight checks and real-browser monitors from hosted testing locations around the world. Enabling Monitor Management will generate an API key to allow the Synthetics Service to write back to your Elasticsearch cluster.',
'Enable Monitor Management to run lightweight and real-browser monitors from hosted testing locations around the world. Enabling Monitor Management will generate an API key to allow the Synthetics Service to write back to your Elasticsearch cluster.',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The term "Synthetics Service" is new to me so I'm not sure exactly what it refers to, but that might be ok if it's made clear in the linked document.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@drewpost @paulb-elastic Have we thought about concrete terms for how we refer to the service that runs the tests on our hosted testing nodes?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question... I've been referring to it as the Synthetics Cloud Service. @drewpost do you have something in mind?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guilty of sowing the seeds of confusion here. Internally we've called it synthetics service but as a part of the broader Synthetics product, this capability is "Global managed testing infrastructure"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have many places in docs where we use "Synthetics Service". I will be updated them all.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
uptime 777.2KB 777.3KB +64.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

dominiqueclarke
dominiqueclarke commented Apr 19, 2022
View reviewed changes
.../plugins/uptime/public/components/monitor_management/monitor_list/enablement_empty_state.tsx
@@ -102,15 +105,15 @@ const MONITOR_MANAGEMENT_ENABLEMENT_MESSAGE = i18n.translate(
'xpack.uptime.monitorManagement.emptyState.enablement',
{
defaultMessage:
'Enable Monitor Management to run lightweight checks and real-browser monitors from hosted testing locations around the world. Enabling Monitor Management will generate an API key to allow the Synthetics Service to write back to your Elasticsearch cluster.',
'Enable Monitor Management to run lightweight and real-browser monitors from hosted testing locations around the world. Enabling Monitor Management will generate an API key to allow the Synthetics Service to write back to your Elasticsearch cluster.',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'Enable Monitor Management to run lightweight and real-browser monitors from hosted testing locations around the world. Enabling Monitor Management will generate an API key to allow the Synthetics Service to write back to your Elasticsearch cluster.',
'Enable Monitor Management to run lightweight and real-browser monitors from hosted testing locations around the world. Enabling Monitor Management will generate an API key to allow our global managed testing infrastructure to write back to your Elasticsearch cluster.',

@drewpost how is this?

hbharding
hbharding approved these changes Apr 19, 2022
View reviewed changes
Copy link
Contributor

@hbharding hbharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link LGTM

@dominiqueclarke dominiqueclarke merged commit 834b178 into elastic:main Apr 19, 2022
@dominiqueclarke dominiqueclarke deleted the fix/uptime-monitor-management-docs-link branch April 19, 2022 21:04
kibanamachine pushed a commit that referenced this pull request Apr 19, 2022
@dominiqueclarke
uptime - add monitor management docs link (#130558)
afa8d0b 
(cherry picked from commit 834b178)
@kibanamachine kibanamachine mentioned this pull request Apr 19, 2022
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Apr 19, 2022
@kibanamachine @dominiqueclarke
uptime - add monitor management docs link (#130558) (#130621)
db74c4e 
(cherry picked from commit 834b178)

Co-authored-by: Dominique Clarke <[email protected]>
kertal pushed a commit to kertal/kibana that referenced this pull request May 24, 2022
@dominiqueclarke @kertal
uptime - add monitor management docs link (elastic#130558)
582cae0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulb-elastic paulb-elastic paulb-elastic left review comments

@colleenmcginnis colleenmcginnis colleenmcginnis left review comments

@drewpost drewpost drewpost left review comments

@hbharding hbharding hbharding approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.2.0 v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update the Enable Monitor Management links
8 participants
@dominiqueclarke @elasticmachine @kibana-ci @kibanamachine @hbharding @drewpost @colleenmcginnis @paulb-elastic