Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stack Monitoring] use CCS constant in place of '*' string #130466

Merged
merged 4 commits into from
Apr 19, 2022

Conversation

neptunian
Copy link
Contributor

As part of #120384 (comment), instead of making CCS remotes customizable via kibana config we will continue to use '*', but place it in a constant. See #129806 for original PR using kibana config. Also adds some other cleanup changes

  • Replace usage of * with CCS_REMOTE_PATTERN. This is used by rule executors and getting initial cluster information from the UI to check for remote clusters.
  • Remove getConfigCcs and directly access config. We don't need to check of ccs is enabled before using the ccs string value of the remote name/pattern because that already happens in prefixIndexPattern
  • change prefixIndexPattern to prefixIndexPatternWithCcs. Previously this was used to also append metricbeat-* to the index but now only handles CCS

@neptunian neptunian added Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes v8.3.0 labels Apr 18, 2022
@neptunian neptunian self-assigned this Apr 18, 2022
@neptunian neptunian requested a review from a team as a code owner April 18, 2022 15:27
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
monitoring 471.1KB 471.1KB -11.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
monitoring 23.7KB 23.7KB +43.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @neptunian

Copy link
Contributor

@matschaffer matschaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! As you mentioned we don't have a good way to get SM UI via CCS, so I just confirmed via local monitoring and confirmed that the collected APM traces included the *: prefix.

@neptunian neptunian merged commit 00effe7 into elastic:main Apr 19, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 19, 2022
kertal pushed a commit to kertal/kibana that referenced this pull request May 24, 2022
…30466)

* add constant for CCS_REMOTE_PATTERN

* remove getConfigCcs and replace with CCS_REMOTE_PATTERN constant

* use CCS_REMOTE_PATTERN for * queries

* changes prefixIndexPattern to prefixIndePatternWithCcs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v8.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants