[Stack Monitoring] support custom ccs remote prefixes #129806
Conversation
neptunian
added
Team:Infra Monitoring UI - DEPRECATED
| * @return {String} The index pattern with the {@code cluster} prefix appropriately prepended. | ||
| */ | ||
| export function prefixIndexPattern(config: MonitoringConfig, indexPattern: string, ccs?: string) { | ||
| const ccsEnabled = getConfigCcs(config); | ||
| export function prefixIndexPatternWithCcs( |
There was a problem hiding this comment.
I changed the name to have "WithCcs" because previously this function also handled appending metricbeat-*. Now it only does CCS so want to clarify that.
neptunian
changed the title
neptunian
force-pushed
the
120384-allow-ccs-remote-pattern
branch
2 times, most recently
from
08f1cb1 to
834da9e
Compare
| @@ -114,6 +148,12 @@ export function createConfig(config: MonitoringConfigSchema): MonitoringConfig { | |||
| ...config, | |||
| ui: { | |||
| ...config.ui, | |||
| ccs: { | |||
| ...config.ui.ccs, | |||
| remotePatterns: Array.isArray(config.ui.ccs.remotePatterns) | |||
There was a problem hiding this comment.
is user specifies a string value put it in an array we only have to work with array type.
|
@jasonrhodes @ravikesarwani This PR is about ready, but @jportner mentioned we should consider putting this in Kibana Advanced Settings UI instead of in the yaml config. Given the impact putting in a non existent remote could have on alerts and viewing the SM UI, what do you think? We'd also be able to have it by space if that's something we possibly see implementing in the future.
|
Just to be clear, everything in Advanced Settings is space-isolated by design. In other words, if you change an Advanced Setting in one space, it only affects that space, there's no additional dev effort to make that happen 👍 |
|
Something to consider is that so long as the user selects "skip if unavailable" in the remote (which is not on by default), the errors mentioned above will not happen.
When the remote goes down, the alert will recover and the user can still access SM UI Of course if the user enters a remote name in the kibana config that never existed to begin with they will still get the errors. |
|
Was trying to understand the context:
|
…n rule filter query
neptunian
force-pushed
the
120384-allow-ccs-remote-pattern
branch
from
834da9e to
58f3f3a
Compare
💔 Build FailedFailed CI StepsTest Failures
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @neptunian |
There was a problem hiding this comment.
Just pointing to this note here #120384 (comment)
@neptunian and I decided we'll rework this to read the value from a constant for now instead of from a new config flag. That will maintain all of the consolidation work done here without introducing a flag we have to support for a long time, so that we can wait a bit longer to decide on whether we want this flag or not.
|
Closing in place of #130466 for now |
Resolves #120384
Adds the ability for the user to specify a remote prefix instead of searching cross cluster with the default "*" query which gets all available remotes.
prefixIndexPatterntoprefixIndexPatternWithCcsmonitoring.ui.ccs.remotePatternsin order to use the KQL filter in the rulesChanges in behavior when using the monitoring.ui.ccs.remotePatterns and not using
*monitoring.ui.ccs.enabledistrue(default), a cross cluster search will only look for remotes inmonitoring.ui.ccs.remotePatternsinstead of all available.Error: security_exception: [no_such_remote_cluster_exception] Reason: no such remote cluster: [idontexist], caused by: "no such remote cluster: [idontexist]"). Previously we used*and before that fetchAvailableCcs when CCS was enabled so we did not have this issue, but that created a problem when there were too many remotes.Test
myremoteandmyremote2. Usingmonitoring.ui.ccs.remotePatternsI was able to "filter" out my remotes by adding"myremote"or["myremote"]and only that remote showed up in the cluster listing. When i added the 2nd remote["myremote", "myremote2"], both of them showed up in the cluster listing. When I setmonitoring.ui.ccs.enabled: false, neither showed up.