Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unified Search] Move autocomplete logic to unified search plugin #129277

Conversation

nlatipov
Copy link
Contributor

@nlatipov nlatipov commented Apr 3, 2022

Summary

This PR is solves Issue: #128383

Motivation:
After PR #127651 is merged, next step is move the autocomplete folder to the unified_search plugin. No extra functionality is going to be added (or cleanups or improvements).

What was done:

  1. data/plugin/autocomplete folder was moved into unified_search;
  2. data/plugin/server/autocomplete folder was moved into unified_search;
  3. The following part was moved from from the Data Plugin runtime contract to UnifiedSearch Plugin
  autocomplete: this.autocomplete.start(),
  1. Related Static and Runtime imports were updated
  2. Added the unifiedSearch plugin as a dependency to plugins that require plugins (Kibana.json)
  3. Registered a unifiedSearch plugin in the i18n (translations) plugin
  4. data/server/config_deprecations.ts file was moved into unified_search/server and added renameFromRoot for autocomplete;

@nlatipov nlatipov changed the title Issue move autocomplete to unified search [Unified Search] Move autocomplete logic to unified search plugin Apr 8, 2022
@nlatipov
Copy link
Contributor Author

nlatipov commented Apr 9, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Default CI Group #10 / Actions and Triggers app Rule Details Header should reenable a disabled the rule

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
controls 179 181 +2
data 470 456 -14
unifiedSearch 143 157 +14
total +2

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
data 2824 2816 -8
unifiedSearch 45 75 +30
total +22

Any counts in public APIs

Total count of every any typed public API. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats any for more detailed information.

id before after diff
data 40 39 -1
unifiedSearch 1 2 +1
total -0

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 2.8MB 2.8MB +9.0B
controls 437.6KB 437.7KB +100.0B
fleet 684.3KB 684.3KB +18.0B
infra 1005.7KB 1005.7KB +18.0B
lens 1.0MB 1.0MB +148.0B
ml 3.3MB 3.3MB +9.0B
monitoring 471.1KB 471.1KB +19.0B
securitySolution 4.8MB 4.8MB +36.0B
unifiedSearch 138.3KB 116.1KB -22.2KB
uptime 777.5KB 777.5KB +9.0B
total -21.8KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
data 20 18 -2
unifiedSearch 6 11 +5
total +3

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff errors
controls 32.4KB 32.4KB +53.0B
data 422.4KB 410.2KB -12.2KB
inputControlVis 5.4KB 5.5KB +32.0B
maps 70.1KB 70.1KB +9.0B
ml 39.5KB 39.5KB +30.0B
monitoring 23.6KB 23.8KB +143.0B
unifiedSearch 41.5KB 87.8KB +46.3KB ❌ 39.7KB over limit
total +34.3KB
Unknown metric groups

API count

id before after diff
data 3434 3428 -6
unifiedSearch 48 79 +31
total +25

async chunk count

id before after diff
unifiedSearch 10 9 -1

ESLint disabled line counts

id before after diff
data 40 39 -1
unifiedSearch 12 15 +3
total +2

References to deprecated APIs

id before after diff
data 406 382 -24
unifiedSearch 255 380 +125
total +101

Total ESLint disabled count

id before after diff
data 44 43 -1
unifiedSearch 12 15 +3
total +2

History

  • 💔 Build #37127 failed 90f2452259e52c55323d07cdd05cf364d0531ba8
  • 💔 Build #37126 failed 7029aba2296e7394d382f90cdda999d133af8eb1
  • 💔 Build #37077 failed 08f0dbd7a8478dceeb87fbeb89a343f681f94045
  • 💔 Build #37069 failed 3bbf027b5a732864d610d178e1d529bae8837729
  • 💔 Build #36960 failed e90c8db4d3dca37efd9a353544fb86889ca6f0a7

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nlatipov nlatipov force-pushed the issue-move-autocomplete-to-unified-search branch from d87ffc1 to 17ffceb Compare April 12, 2022 07:02
@nlatipov nlatipov closed this Apr 12, 2022
@nlatipov nlatipov deleted the issue-move-autocomplete-to-unified-search branch April 12, 2022 07:05
@nlatipov nlatipov restored the issue-move-autocomplete-to-unified-search branch April 12, 2022 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants