Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Unified search] Move the autocomplete logic to the unified search plugin #128383

Closed
stratoula opened this issue Mar 23, 2022 · 2 comments · Fixed by #129977
Closed

[Unified search] Move the autocomplete logic to the unified search plugin #128383

stratoula opened this issue Mar 23, 2022 · 2 comments · Fixed by #129977
Assignees
@alexwizp
Labels
Feature:Unified search Unified search related tasks impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture

Comments

@stratoula
Copy link
Contributor

Describe the feature:
After this PR #127651 is merged, we should also move the autocomplete folder to the new unified_search plugin.

After syncing with @flash1293 and @ppisljar we decided that the new plugin will have :

  • all the UI components that are parts of the unified search experience (dataview picker, queryInput, filterBar, datePicker, queryBarMenu, languageSwitcher etc)
  • the autocomplete logic as it is only used by the components of this plugin

The global state will remain to the data plugin.
@stratoula stratoula added technical debt Improvement of the software architecture and operational architecture Team:Visualizations Visualization editors, elastic-charts and infrastructure Team:AppServicesSv Feature:Unified search Unified search related tasks labels Mar 23, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesSv)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@alexwizp alexwizp self-assigned this Mar 24, 2022
@exalate-issue-sync exalate-issue-sync bot added the impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. label Apr 4, 2022
This was referenced Apr 8, 2022
Closed
Merged
@exalate-issue-sync exalate-issue-sync bot reopened this Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexwizp alexwizp

Labels
Feature:Unified search Unified search related tasks impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Unified Search] Move autocomplete logic to unified search plugin nlatipov/kibana
3 participants
@elasticmachine @stratoula @alexwizp