Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changing query should update url state #12912

Merged
merged 1 commit into from
Jul 17, 2017
Merged

changing query should update url state #12912

merged 1 commit into from
Jul 17, 2017

Conversation

ppisljar
Copy link
Member

closes #12882

@ppisljar ppisljar added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) review v6.0.0 labels Jul 17, 2017
thomasneirynck
thomasneirynck approved these changes Jul 17, 2017
View reviewed changes
Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ppisljar ppisljar merged commit 9c40441 into elastic:master Jul 17, 2017
@ppisljar ppisljar deleted the fix/visualizeQueryState branch July 17, 2017 15:06
@ppisljar ppisljar restored the fix/visualizeQueryState branch September 26, 2018 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasneirynck thomasneirynck thomasneirynck approved these changes

@lukasolson lukasolson Awaiting requested review from lukasolson

Assignees
No one assigned
Labels
Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:fix review v6.0.0-rc1 v6.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Visualize query isn't preserved with back button
3 participants
@ppisljar @thomasneirynck @jimgoodwin