Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualize query isn't preserved with back button #12882

Closed
lukasolson opened this issue Jul 14, 2017 · 3 comments · Fixed by #12912
Closed

Visualize query isn't preserved with back button #12882

lukasolson opened this issue Jul 14, 2017 · 3 comments · Fixed by #12912
Assignees
Labels
blocker bug Fixes for quality problems that affect the customer experience Feature:Query Bar Querying and query bar features Feature:Visualizations Generic visualization features (in case no more specific feature label is available) PR sent v6.0.0

Comments

@lukasolson
Copy link
Member

  1. Create a visualization
  2. Type something in the query bar and search
  3. Click on any other tab
  4. Click the back button

The query you typed in will be gone.

I checked 5.5.0 and 6.0.0-alpha2 and it was working just fine. It also works fine in Discover and Dashboard. For some reason, it looks like the query isn't actually being pushed to the URL state.

jul-14-2017 14-33-09

@lukasolson lukasolson added Feature:Query Bar Querying and query bar features Feature:Visualizations Generic visualization features (in case no more specific feature label is available) bug Fixes for quality problems that affect the customer experience labels Jul 14, 2017
@thomasneirynck
Copy link
Contributor

Probably regression due to refactor

@lukasolson
Copy link
Member Author

This is actually worse than I had originally thought. If you choose to create the visualization from a saved search, then when you type in the query bar and hit search, the search you type in won't even be applied. Seems related to this bug, but if it's unrelated, I can file a new ticket.

@ppisljar
Copy link
Member

@lukasolson seems unrelated, vis with saved search should not show the query bar and filters. i addressed that in #12911

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker bug Fixes for quality problems that affect the customer experience Feature:Query Bar Querying and query bar features Feature:Visualizations Generic visualization features (in case no more specific feature label is available) PR sent v6.0.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants