Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix upgrade maps smoke tests #128696

Merged
merged 4 commits into from
Mar 30, 2022
Merged

Fix upgrade maps smoke tests #128696

merged 4 commits into from
Mar 30, 2022

Conversation

liza-mae
Copy link
Contributor

Fixes elastic/elastic-stack-testing#1200

@liza-mae liza-mae added release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v8.2.0 v7.17.2 v8.1.2 labels Mar 28, 2022
@liza-mae liza-mae requested review from nreese and a team March 28, 2022 23:02
@liza-mae liza-mae self-assigned this Mar 28, 2022
@nreese
Copy link
Contributor

nreese commented Mar 29, 2022

Can you provide some more details about how the tests are running. What versions are being upgraded from/to?

The default base map switched in v8.0.0 from "bright" to "desaturated".

Requests by Country changed to Requests by Destination in v7.16

So depending on when sample data saved objects are created, these things will change.

@liza-mae
Copy link
Contributor Author

@nreese yes here are some failures:

7.16.3 -> 7.17.1, fails to find by country and when we end up on 8.1.x from earlier versions of 7.x or 6.8.x we fail to find desaturated. This PR when merged, should stabilize the test failures in upgrade, we have about 54 failing tests.

@liza-mae
Copy link
Contributor Author

@nreese mind giving a review for this?

nreese
nreese reviewed Mar 29, 2022
View reviewed changes
x-pack/test/upgrade/maps_services.ts Outdated Show resolved Hide resolved
x-pack/test/upgrade/services.ts Outdated Show resolved Hide resolved
@liza-mae
Copy link
Contributor Author

@nreese how do the updates look for review approval ?

@nreese
Copy link
Contributor

nreese commented Mar 29, 2022

how do the updates look for review approval ?

There is still the comment about renaming maps_services to maps_upgrade_services. Everything else looks great

@liza-mae
Copy link
Contributor Author

Thanks file renamed

nreese
nreese approved these changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for maintaining these tests as sample data evolves
code review

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @liza-mae

@liza-mae liza-mae merged commit 8eadbc6 into elastic:main Mar 30, 2022
@liza-mae liza-mae deleted the liza/fix-upgrade-maps-tests branch March 30, 2022 15:53
kibanamachine pushed a commit that referenced this pull request Mar 30, 2022
@liza-mae
Fix upgrade maps smoke tests (#128696)
4dfc78f 
* Fix upgrade maps smoke tests

* Review updates

* Update maps services name to be more specific

* Rename maps_services file

(cherry picked from commit 8eadbc6)
@kibanamachine kibanamachine mentioned this pull request Mar 30, 2022
Merged
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
❌ 7.17 Backport failed because of merge conflicts
✅ 8.1

Manual backport

To create the backport manually run:

node scripts/backport --pr 128696

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Mar 30, 2022
@kibanamachine @liza-mae
Fix upgrade maps smoke tests (#128696) (#128936)
82d9b34 
* Fix upgrade maps smoke tests

* Review updates

* Update maps services name to be more specific

* Rename maps_services file

(cherry picked from commit 8eadbc6)

Co-authored-by: liza-mae <[email protected]>
@liza-mae liza-mae mentioned this pull request Apr 4, 2022
Merged
liza-mae added a commit to liza-mae/kibana that referenced this pull request Apr 4, 2022
@liza-mae
Fix upgrade maps smoke tests (elastic#128696)
ca2d5c4 
* Fix upgrade maps smoke tests

* Review updates

* Update maps services name to be more specific

* Rename maps_services file

(cherry picked from commit 8eadbc6)
liza-mae added a commit that referenced this pull request Apr 4, 2022
@liza-mae
Fix upgrade maps smoke tests (#128696) (#129395)
6c08e26 
* Fix upgrade maps smoke tests

* Review updates

* Update maps services name to be more specific

* Rename maps_services file

(cherry picked from commit 8eadbc6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nreese nreese nreese approved these changes

Assignees

@liza-mae liza-mae

Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes v7.17.2 v8.1.2 v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@liza-mae @nreese @kibana-ci @kibanamachine