-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[maps] Use desaturated map tiles instead of bright map tiles by default #116179
Conversation
Pinging @elastic/kibana-gis (Team:Geo) |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
merge conflict between base and head |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! tested in Chrome.
- New maps are by default desaturated
- Autoselect based on kibana theme still works
- Imported saved objects from older version (7.15.1) maintain their original layer style
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 on code, some minor comments.
I don't feel strongly about this, but I think the initial app load looks "off".
before:
after:
I also wonder if any user has been truly disadvantaged by the current "bright" base-map as a default on startup.
Anyways, +1 on merging if there's an overall preference for this new base map. cc @jsanz @nickpeihl @ghudgins @miukimiu
x-pack/plugins/maps/common/descriptor_types/source_descriptor_types.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in Chrome. Creating new maps and loading the sample datasets all come with the desaturated style. As @nickpeihl tested, importing the kibana sample flights saved object from a 7.15.0
instance keeps the original bright style.
I like this style as a default as it helps users focus on their data, as the basemap is usually here to provide spatial context.
❤️ i'm in agreement here as this gets out of the way of the data! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx @ghudgins for weighing in, lgtm
@elasticmachine merge upstream |
@elasticmachine merge upstream |
expected head sha didn’t match current head ref. |
💛 Build succeeded, but was flaky
Test Failures
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Fixes #115979