Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uses SavedObjectsClient for UI Settings #12747

Merged
merged 3 commits into from
Jul 11, 2017
Merged

Uses SavedObjectsClient for UI Settings #12747

merged 3 commits into from
Jul 11, 2017

Conversation

tylersmalley
Copy link
Contributor

No description provided.

@tylersmalley tylersmalley mentioned this pull request Jul 11, 2017
Closed
7 tasks
@tylersmalley tylersmalley force-pushed the ui-settings-saved-objects branch from 1d3517b to ebdb4d9 Compare July 11, 2017 04:53
@tylersmalley tylersmalley requested a review from spalger July 11, 2017 05:29
@spalger
Copy link
Contributor

spalger commented Jul 11, 2017

This is great, but before we can require a SavedObjectsClient when creating a uiSettingsService we need to add a way to instantiate a SavedObjectsClient using a server factory like https://github.com/elastic/kibana/blob/master/src/ui/ui_settings/ui_settings_mixin.js#L40

spalger
spalger approved these changes Jul 11, 2017
View reviewed changes
Copy link
Contributor

@spalger spalger left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, once tests pass

@spalger spalger mentioned this pull request Jul 11, 2017
Merged
spalger
spalger suggested changes Jul 11, 2017
View reviewed changes
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed something, thinking there might be an issue with removing the ignore401Errors handling...

@spalger spalger force-pushed the ui-settings-saved-objects branch from ef08852 to a4909dc Compare July 11, 2017 16:11
@tylersmalley tylersmalley merged commit 44dedd6 into elastic:master Jul 11, 2017
tylersmalley added a commit to tylersmalley/kibana that referenced this pull request Jul 11, 2017
@tylersmalley
Uses SavedObjectsClient for UI Settings (elastic#12747)
c1f57f2
@tylersmalley
Copy link
Contributor Author

tylersmalley commented Jul 11, 2017 •
edited
Loading

5.x: 1cd2597

@epixa
Copy link
Contributor

epixa commented Jul 11, 2017

@tylersmalley I think that backport belongs to a different PR, no?

@tylersmalley
Copy link
Contributor Author

@epixa, you're right - updated.

tylersmalley added a commit that referenced this pull request Jul 11, 2017
@tylersmalley
Uses SavedObjectsClient for UI Settings (#12747)
1cd2597
@spalger spalger mentioned this pull request Jul 24, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spalger spalger spalger approved these changes

Assignees
No one assigned
Labels
blocker release_note:enhancement review v5.6.0 v6.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tylersmalley @spalger @epixa @jimgoodwin