Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[elasticsearch/migrateConfig] use server.savedObjectsClientFactory() #12767

Merged
merged 5 commits into from
Jul 18, 2017

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Jul 11, 2017

Requires #12747

Updates the migrateConfig step of the es healthcheck to use the new server.savedObjectsClientFactory() exposed by #12747 rather than importing the class and constructing it directly.

@spalger spalger added Team:Operations Team label for Operations Team blocked v5.6.0 v6.0.0 labels Jul 11, 2017
@spalger spalger added review and removed blocked labels Jul 13, 2017
@spalger spalger requested a review from kobelb July 13, 2017 19:33
@spalger spalger requested a review from tylersmalley July 13, 2017 19:34
Copy link
Contributor

@kobelb kobelb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spalger spalger merged commit 0772998 into elastic:master Jul 18, 2017
@spalger spalger deleted the fix/use-saved-objects-client-factory branch July 18, 2017 00:48
spalger added a commit that referenced this pull request Jul 18, 2017
…12767)

* Uses SavedObjectsClient for UI Settings

Signed-off-by: Tyler Smalley <[email protected]>

* [server/saved_objects] add server.savedObjectsClientFactory()

* [elasticsearch/migrateConfig] use server.savedObjectsClientFactory()

* [elasticsearch/healthCheck] add savedObjectsClient stub

(cherry picked from commit 0772998)
@spalger
Copy link
Contributor Author

spalger commented Jul 18, 2017

5.x/5.6: 6e76310

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants