-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Execution context jest tests #126777
Merged
Merged
Execution context jest tests #126777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizozom
added
Team:Core
Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
release_note:skip
Skip the PR/issue when compiling release notes
auto-backport
Deprecated - use backport:version if exact versions are needed
v8.1.0
v8.2.0
v8.1.1
labels
Mar 3, 2022
Pinging @elastic/kibana-core (Team:Core) |
add execution context to fullstory
lizozom
force-pushed
the
execution-context-jest
branch
from
March 3, 2022 14:48
3c7d85c
to
ecddf30
Compare
9 tasks
mshustov
approved these changes
Mar 3, 2022
src/core/public/execution_context/execution_context_service.test.ts
Outdated
Show resolved
Hide resolved
src/core/public/execution_context/execution_context_service.test.ts
Outdated
Show resolved
Hide resolved
src/core/public/execution_context/execution_context_service.test.ts
Outdated
Show resolved
Hide resolved
💚 Build SucceededMetrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
that referenced
this pull request
Mar 3, 2022
* fix a couple bugs in context management add execution context to fullstory * Update execution_context_service.ts * stop and app name tests * code review (cherry picked from commit 93a95fd)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Mar 3, 2022
* fix a couple bugs in context management add execution context to fullstory * Update execution_context_service.ts * stop and app name tests * code review (cherry picked from commit 93a95fd) Co-authored-by: Liza Katz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Deprecated - use backport:version if exact versions are needed
release_note:skip
Skip the PR/issue when compiling release notes
Team:Core
Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
v8.1.0
v8.1.1
v8.2.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Folow up for #124996
set
andreset
to persist thedefault context
which is not provided by applications directlyChecklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers