-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use execution context for Fullstory #126780
Conversation
add execution context to fullstory
…cution-context-for-fs
4b5d021
to
adea846
Compare
…cution-context-for-fs
Pinging @elastic/kibana-core (Team:Core) |
@elasticmachine merge upstream |
Report org id to FS
…ana into use-execution-context-for-fs
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just added 1 nit for providing the org_id_str
as part of the identify
call if possible.
…ana into use-execution-context-for-fs
💚 Build SucceededMetrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: cc @lizozom |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
* fix a couple bugs in context management add execution context to fullstory * Update execution_context_service.ts * stop and app name tests * Use execution context in fullstory * Fix user hash Report org id to FS * Use setUserVars for esorgid * pass orgid into identify * fix Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit ff90bd4)
* fix a couple bugs in context management add execution context to fullstory * Update execution_context_service.ts * stop and app name tests * Use execution context in fullstory * Fix user hash Report org id to FS * Use setUserVars for esorgid * pass orgid into identify * fix Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit ff90bd4) Co-authored-by: Liza Katz <[email protected]>
Summary
Depends on #126777
setUserVars
withsetVars
which matches our type of data better.Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers