Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use execution context for Fullstory #126780

Merged
merged 15 commits into from
Mar 7, 2022

Conversation

lizozom
Copy link
Contributor

@lizozom lizozom commented Mar 3, 2022

Summary

Depends on #126777

  • Uses the new information from our execution context (app name, page name, entity id) and passes it to Fullstory.
  • Replaces the use of setUserVars with setVars which matches our type of data better.
  • Fixes an integration bug where users are not scoped to their organization, causing all users with the same name to be counted as a single user.
  • Pass the Elastic organization id to fullstory

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@lizozom lizozom added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v8.1.0 v8.2.0 v8.1.1 labels Mar 3, 2022
@lizozom lizozom self-assigned this Mar 3, 2022
@lizozom lizozom force-pushed the use-execution-context-for-fs branch from 4b5d021 to adea846 Compare March 3, 2022 14:52
@lizozom lizozom mentioned this pull request Mar 3, 2022
9 tasks
@lizozom lizozom marked this pull request as ready for review March 5, 2022 12:42
@lizozom lizozom requested a review from a team as a code owner March 5, 2022 12:42
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@lizozom
Copy link
Contributor Author

lizozom commented Mar 6, 2022

@elasticmachine merge upstream

@lizozom
Copy link
Contributor Author

lizozom commented Mar 6, 2022

@elasticmachine merge upstream

Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just added 1 nit for providing the org_id_str as part of the identify call if possible.

x-pack/plugins/cloud/public/plugin.tsx Outdated Show resolved Hide resolved
@lizozom lizozom enabled auto-merge (squash) March 7, 2022 17:13
@lizozom lizozom merged commit ff90bd4 into elastic:main Mar 7, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
cloud 8.6KB 8.8KB +256.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @lizozom

@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine pushed a commit that referenced this pull request Mar 7, 2022
* fix a couple bugs in context management
add execution context to fullstory

* Update execution_context_service.ts

* stop and app name tests

* Use execution context in fullstory

* Fix user hash
Report org id to FS

* Use setUserVars for esorgid

* pass orgid into identify

* fix

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit ff90bd4)
kibanamachine added a commit that referenced this pull request Mar 7, 2022
* fix a couple bugs in context management
add execution context to fullstory

* Update execution_context_service.ts

* stop and app name tests

* Use execution context in fullstory

* Fix user hash
Report org id to FS

* Use setUserVars for esorgid

* pass orgid into identify

* fix

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit ff90bd4)

Co-authored-by: Liza Katz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.1.0 v8.1.1 v8.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants