Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Response Ops] Alerts table #125977

Merged
merged 52 commits into from
Mar 29, 2022
Merged

Conversation

chrisronline
Copy link
Contributor

@chrisronline chrisronline commented Feb 17, 2022

Resolves #125849

This PR adds a very basic alerts table that support sorting and pagination. We will continuously add to this table until we reach feature parity with what security solutions and o11y teams need.

To test, I added an internal route /app/management/insightsAndAlerting/triggersActions/_internal/alerts that shows the table but it's not hooked into any real data source so it's limited to just showing mock data.

Here are some screenshots of how the table looks hooked into the observability archive data:

Screen Shot 2022-03-21 at 4 57 32 PM

Screen Shot 2022-03-21 at 4 57 38 PM

Screen Shot 2022-03-21 at 4 57 44 PM

@gmmorris
Copy link
Contributor

@elasticmachine merge upstream

@chrisronline
Copy link
Contributor Author

@academo Apologies. The state of this PR wasn't really ready for external review (for those without context into the decision making of the PR implementation) so I apologize for marking it as such. I'll clean it up, add those tests, and remove the unnecessary code today. I'll ping you once it's ready for another round. Thanks!

@chrisronline
Copy link
Contributor Author

One thing I need to do is incorporate the recent feature flagging logic so the internal page is hidden behind a feature flag

@chrisronline chrisronline requested a review from academo March 24, 2022 13:39
@chrisronline
Copy link
Contributor Author

@academo Ready for another round!

import { lazy } from 'react';
import { suspendedComponentWithProps } from '../../lib/suspended_component_with_props';

export const AlertsTable = suspendedComponentWithProps(lazy(() => import('./alerts_table')));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you consider exporting both a non-lazy and lazy version of the alert table?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if that'd cause bundle size issues, which is why it's lazy in the first place. I can investigate if that's a requirement.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
triggersActionsUi 345 358 +13

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
ruleRegistry 164 167 +3
triggersActionsUi 286 288 +2
total +5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 685.2KB 697.2KB +12.0KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
ruleRegistry 8 7 -1
triggersActionsUi 22 23 +1
total -0

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
triggersActionsUi 98.1KB 98.5KB +389.0B
Unknown metric groups

API count

id before after diff
ruleRegistry 191 194 +3
triggersActionsUi 300 302 +2
total +5

async chunk count

id before after diff
triggersActionsUi 71 73 +2

ESLint disabled line counts

id before after diff
triggersActionsUi 158 160 +2

Total ESLint disabled count

id before after diff
triggersActionsUi 164 166 +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @chrisronline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting ci:cloud-deploy Create or update a Cloud deployment release_note:skip Skip the PR/issue when compiling release notes review Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ResponseOps] Build the React component for the alerts table
7 participants