-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Response Ops] Alerts table #125977
[Response Ops] Alerts table #125977
Conversation
This reverts commit 5583997.
@elasticmachine merge upstream |
@academo Apologies. The state of this PR wasn't really ready for external review (for those without context into the decision making of the PR implementation) so I apologize for marking it as such. I'll clean it up, add those tests, and remove the unnecessary code today. I'll ping you once it's ready for another round. Thanks! |
One thing I need to do is incorporate the recent feature flagging logic so the internal page is hidden behind a feature flag |
@academo Ready for another round! |
import { lazy } from 'react'; | ||
import { suspendedComponentWithProps } from '../../lib/suspended_component_with_props'; | ||
|
||
export const AlertsTable = suspendedComponentWithProps(lazy(() => import('./alerts_table'))); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you consider exporting both a non-lazy and lazy version of the alert table?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if that'd cause bundle size issues, which is why it's lazy in the first place. I can investigate if that's a requirement.
💚 Build SucceededMetrics [docs]Module Count
Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
Unknown metric groupsAPI count
async chunk count
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
Resolves #125849
This PR adds a very basic alerts table that support sorting and pagination. We will continuously add to this table until we reach feature parity with what security solutions and o11y teams need.
To test, I added an internal route
/app/management/insightsAndAlerting/triggersActions/_internal/alerts
that shows the table but it's not hooked into any real data source so it's limited to just showing mock data.Here are some screenshots of how the table looks hooked into the observability archive data: