-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RAM] [META] Make rules list and rule event log list shareable #129932
Comments
Pinging @elastic/response-ops (Team:ResponseOps) |
@JiaweiWu We talked with the team and here are our primary goals for 8.3:
We can move on with creating subtickets. For 8.3 observability folks can start working on the prioritized items I mentioned (status, tags, filtering per status, filtering per tags and rule details page components) and of course we can support you in the review process of the remaining stuff in the rules list page. |
Hi @JiaweiWu, Thank you very much for your effort in making all these components shareable!! As you can see, I mentioned #130126 here as the Rule details page requires three components to be sharable: 3- Trigger actions (I believe this is the same one that @mgiota needs for the Rule list page Do you think you could add the components I mentioned to your ongoing effort? If feasible, please tell me if I can help with anything to ease the task. I don't know the complexity/issue size to make a given component sharable. But our team AO relay heavily on the requested changes for |
@JiaweiWu @XavierM - In the Simplified Protections Management meeting a requirement came up for Security Solution. They were wondering if we were able to make the SearchBar in our sharable Rules List an independently sharable component that they could consume without needing to consume our Rules Table (yet, at least). What are your thoughts? Is this doable as part of this issue without adding much effort? Or should I file a follow up issue? |
@fkanout Yes for sure, those components are accounted for in our efforts to make the rule summary shareable, we can discuss further to create individual tasks. @gmmorris I agree with you there, actually @mgiota expressed the same opinion for having the searchbar as a separate entity that is detached from the rules table. Personally I think it's quite doable and shouldn't really add too much complexity overall. |
@fkanout Regarding Trigger actions I tested out the PR @Zacqary has in Review and it works like a charm (with one small addition I had to do). You can have a look at my comment here #130205 (comment) to get an idea of how you can reuse the shareable StatusDropdown in Rules Detail page as well. |
We would like to make the rules list and rule summary components in the
triggers_actions_ui
plugin shareable. This means determining what parts of the component we would like to promote to props, so they can be customized, also determining what parts of the component API we would like to keep intriggers_actions_ui
.This will also result in a smaller bundle size for the
triggers_actions_ui
plugin, which would be nice 🙂Note:
After the kick off meeting with @mgiota, here are something that we decided to start with:
Rule List:
Some things that we want to parameterize and promote to props:
Rule summary:
To be determined, most likely we will need to share every element that is currently displayed in the rule summaries page, including the new event log lists. @mgiota will have a meeting with her product owner to determine what is needed.
Other components
NoPermissionPrompt
EmptyPrompt
CenterJustifiedSpinner
The text was updated successfully, but these errors were encountered: