Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Actionable Observability] Consume shareable RuleStatusDropdown component #130053

Closed
Tracked by #132777
mgiota opened this issue Apr 12, 2022 · 1 comment · Fixed by #130656 or #131108
Closed
Tracked by #132777

[Actionable Observability] Consume shareable RuleStatusDropdown component #130053

mgiota opened this issue Apr 12, 2022 · 1 comment · Fixed by #130656 or #131108
Assignees
Labels
Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.3.0

Comments

@mgiota
Copy link
Contributor

mgiota commented Apr 12, 2022

Depends on #129774

Summary

In 8.2 users can snooze a rule indefinetly. In 8.3 users will be able to snooze a rule for a desired time period.

Screenshot 2022-05-24 at 11 06 15

Acceptance criteria

  1. Delete current content from the status column in the observability rules page

Screenshot 2022-04-12 at 21 38 22

2. Use current RuleStatusDropdown component from triggers_actions_ui plugin once it is exposed in #129774

Screenshot 2022-04-12 at 21 40 15

cc @Zacqary @XavierM

@mgiota mgiota self-assigned this Apr 12, 2022
@mgiota mgiota added Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.3.0 labels Apr 12, 2022
@mgiota
Copy link
Contributor Author

mgiota commented Apr 15, 2022

I tested out use of sharable status dropdown component and works fine. Once #130205 is merged, I can apply the change I posted in the comment #130205 (comment).

return triggersActionsUi.getRuleStatusDropdown({
            rule: item,
            enableRule: async () => await enableRule({ http, id: item.id }),
            disableRule: async () => await disableRule({ http, id: item.id }),
            onRuleChanged: () => reload(),
            isEditable: true, // TODO don't hardcode
            snoozeRule: async (snoozeEndTime: string | -1, interval: string | null) => {
              await snoozeRule({ http, id: item.id, snoozeEndTime });
            },
            unsnoozeRule: async () => await unsnoozeRule({ http, id: item.id })
          });

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.3.0
Projects
None yet
1 participant