[Accessibility] Add button to skip past the discover doc table #12539
Conversation
weltenwort
added
Project:Accessibility
Feature:Discover
|
Let's try to hide it, if it ends up being too complicated we'll leave it visible. |
|
@weltenwort Would you mind requesting @aphelionz for a review for you're ready? |
The "Skip to bottom"-button displays all remaining rows that were already loaded and focuses an anchor located below the table.
weltenwort
force-pushed
the
fix/doctable-accessibility-load-all
branch
from
9e8e289 to
a19391f
Compare
| $scope.scrollToBottom = function () { | ||
| // delay scrolling to after the rows have been rendered | ||
| $timeout(() => { | ||
| $document.find('#discoverBottomMarker').focus(); |
There was a problem hiding this comment.
Any reason you're opting to use $document instead of $element here?
There was a problem hiding this comment.
No, it's just a remnant of the fact that the code lived deeper in the directive hierarchy previously. good catch
| <div ng-if="rows.length == opts.sampleSize" class="discover-table-footer"> | ||
| These are the first {{opts.sampleSize}} documents matching | ||
| your search, refine your search to see others. | ||
| <a ng-click="toTop()">Back to top.</a> | ||
| <a tabindex="0" ng-click="scrollToTop()">Back to top.</a> |
There was a problem hiding this comment.
Since you're in here anyway, would you mind adding kbnAccessibleClick to this element? Currently if it has focus and you hit enter, nothing happens.
There was a problem hiding this comment.
Doing that will also mean you can remove tabindex="0".
|
@lukasolson @cjcenizal Thanks for the reviews! I have addressed the two issue you mentioned. |
|
would you mind taking another look, @lukasolson @cjcenizal @aphelionz |
|
jenkins, test this |
Release Note: The new "Skip to bottom"-button in Discover is invisible unless focused. When activated it displays all remaining rows that were already loaded and focuses an anchor located below the table.
fixes #11855