Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility: Remove infinite scrolling from Discover table #11855

Closed
cjcenizal opened this issue May 17, 2017 · 4 comments · Fixed by #12539
Closed

Accessibility: Remove infinite scrolling from Discover table #11855

cjcenizal opened this issue May 17, 2017 · 4 comments · Fixed by #12539
Assignees
Labels
Feature:Discover Discover Application Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.

Comments

@cjcenizal
Copy link
Contributor

This table utilizes 'infinite scrolling' to add additional content as the user reaches the bottom of the page. Technically, it stops at 500 documents, but this is a very high number. This can make it difficult for keyboard users to navigate past this area. We should remove the infinite scroll and replace it with a "Load more items" link at the bottom of the page.

@cjcenizal cjcenizal added the Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. label May 17, 2017
@cjcenizal cjcenizal changed the title Discover: Remove infinite scrolling from table Accessibility: Remove infinite scrolling from table May 17, 2017
@cjcenizal cjcenizal added Feature:Discover Discover Application :Discovery labels May 17, 2017
@cjcenizal cjcenizal changed the title Accessibility: Remove infinite scrolling from table Accessibility: Remove infinite scrolling from Discover table May 17, 2017
@eprothro
Copy link

Is there anyway to accomplish this accessibility need without losing the benefit of loading next pages without requiring a button click/selection?

This change, as described, will frustrate many users.

@weltenwort
Copy link
Member

It's not like the infinite scrolling actually loads anything new from the server. All 500 documents are loaded from the start, but not all are displayed (probably for performance reasons). When the table has been refactored to React we might not need that trick.

In the meantime a "scroll to bottom" link, that is invisible to non-screen-readers might be able to serve as an accessible way to trigger "display more". @cjcenizal, what do you think?

@cjcenizal
Copy link
Contributor Author

@weltenwort That's a really interesting suggestion. Considering it made me also reconsider the original problem we're trying to solve:

This can make it difficult for keyboard users to navigate past [the infinitely scrolling table].

I assume this is because as the user tabs through the table, they'll get to the bottom, causing the table to continue loading. So any content in the tab order after the table will become difficult to tab to.

So your solution could work if we rename it something like "Skip to content after table" and triggering it will set the focus on the first element immediately following the table. After thinking about it some more, I think this is a really good solution. The alternative would be to redesign the table so that content is accessible via arrow keys or something, which would be kind of weird. I like it, @weltenwort!

@cjcenizal
Copy link
Contributor Author

For future reference, there's information about how to implement this under the "Skip to main content" section on http://webaim.org/techniques/css/invisiblecontent/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Discover Discover Application Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants