Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Use search strategy error in timeline #125178

Merged
merged 6 commits into from
Feb 11, 2022
Merged

[Security Solution] Use search strategy error in timeline #125178

merged 6 commits into from
Feb 11, 2022

Conversation

stephmilovic
Copy link
Contributor

@stephmilovic stephmilovic commented Feb 10, 2022 •
edited
Loading

Summary

Implements better error handling to fix #122990

The search strategy error handler does some extra work on errors that we are missing out on by using our own error toast. In timeline, I switched it to use the better error handling so we can get this error on a bad runtime field:

better

This is how it used to look:
before

We should probably do this replace all of our addError within search strategy calls with data.search.showError

To test: On alerts page, add runtime field for emit(doc["process.name"].value) this will likely show the error. If it does not, sort by the new runtime field and this will show the error.

@stephmilovic stephmilovic added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. auto-backport Deprecated - use backport:version if exact versions are needed v8.1.0 Team:Threat Hunting:Explore v8.0.1 labels Feb 10, 2022
semd
semd approved these changes Feb 10, 2022
View reviewed changes
Copy link
Contributor

@semd semd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's awesome! LGTM

@stephmilovic stephmilovic marked this pull request as ready for review February 10, 2022 14:54
@stephmilovic stephmilovic requested review from a team as code owners February 10, 2022 14:54
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

michaelolo24
michaelolo24 approved these changes Feb 10, 2022
View reviewed changes
Copy link
Contributor

@michaelolo24 michaelolo24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these changes Steph!

@stephmilovic stephmilovic mentioned this pull request Feb 10, 2022
Open
@semd semd mentioned this pull request Feb 10, 2022
Closed
9 tasks
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 4.7MB 4.7MB +7.0B
timelines 226.0KB 226.0KB -33.0B
total -26.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stephmilovic stephmilovic merged commit 4fe96b7 into elastic:main Feb 11, 2022
@kibanamachine kibanamachine mentioned this pull request Feb 11, 2022
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 11, 2022
@stephmilovic @kibanamachine
[Security Solution] Use search strategy error in timeline (elastic#12…
a6280af 
…5178)

(cherry picked from commit 4fe96b7)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 11, 2022
@stephmilovic @kibanamachine
[Security Solution] Use search strategy error in timeline (elastic#12…
cae9386 
…5178)

(cherry picked from commit 4fe96b7)
@kibanamachine kibanamachine mentioned this pull request Feb 11, 2022
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.1
✅ 8.0

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Feb 11, 2022
@kibanamachine @stephmilovic
[Security Solution] Use search strategy error in timeline (#125178) (#…
9d2091b 
…125423)

(cherry picked from commit 4fe96b7)

Co-authored-by: Steph Milovic <[email protected]>
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 15, 2022
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

5 similar comments
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 24, 2022
kibanamachine added a commit that referenced this pull request Feb 24, 2022
@kibanamachine @stephmilovic
[Security Solution] Use search strategy error in timeline (#125178) (#…
015578b 
…125422)

(cherry picked from commit 4fe96b7)

Co-authored-by: Steph Milovic <[email protected]>
This was referenced Feb 24, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semd semd semd approved these changes

@michaelolo24 michaelolo24 michaelolo24 approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team v8.0.1 v8.1.0 v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Security Solution] Runtime field columns added to timeline should disable sorting
6 participants
@stephmilovic @elasticmachine @kibana-ci @kibanamachine @michaelolo24 @semd