Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Use search strategy showError instead of addError #125263

Open
stephmilovic opened this issue Feb 10, 2022 · 2 comments
Open

[Security Solution] Use search strategy showError instead of addError #125263

stephmilovic opened this issue Feb 10, 2022 · 2 comments
Labels
Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team technical debt Improvement of the software architecture and operational architecture

Comments

@stephmilovic
Copy link
Contributor

stephmilovic commented Feb 10, 2022 •
edited
Loading

In security solution, we have our own error toaster component addError. When we made the switch from GraphQL to Search Strategy, we were unaware of the Search Strategy data.search.showError method and continued using addError. The showError includes special error handling for specific cases. For example, take a look at the same error passed to addError, and then passed to showError:
before
better

We should replace every addError handling an error for search strategy (data.search.search) with the data.search.showError method.

I have already made the change in timeline, which is the gifs above: #125178
@stephmilovic stephmilovic added technical debt Improvement of the software architecture and operational architecture Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Feb 10, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stephmilovic @elasticmachine