TSVB needs to display better UX message when default index pattern is non-time based #124341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DianaDerevyankina
changed the title
DianaDerevyankina
added
Feature:TSVB
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
alexwizp
reviewed
Feb 7, 2022
| @@ -34,7 +35,11 @@ export function getIntervalAndTimefield( | |||
| } | |||
|
|
|||
| if (panel.use_kibana_indexes) { | |||
| validateField(timeField!, index); | |||
| if (timeField) { | |||
|
Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors) |
flash1293
approved these changes
Feb 7, 2022
DianaDerevyankina
removed
the
backport:skip
DianaDerevyankina
added a commit
to DianaDerevyankina/kibana
that referenced
this pull request
Feb 8, 2022
… non-time based (elastic#124341) Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit c299aab)
DianaDerevyankina
added a commit
that referenced
this pull request
Feb 8, 2022
… non-time based (#124341) (#124937) Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit c299aab) Co-authored-by: Kibana Machine <[email protected]>
|
👏 as a new TSVB user, I ran into this several times. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #123863
Summary
Display an error message in case the time field wasn't specified.
For maintainers