Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Uptime Monitor Management - Adjust monitor details page href for browser monitors" #124082

Merged
merged 1 commit into from
Feb 1, 2022
Merged

Revert "Uptime Monitor Management - Adjust monitor details page href for browser monitors" #124082

merged 1 commit into from
Feb 1, 2022

Conversation

shahzad31
Copy link
Contributor

Reverts #122533

@shahzad31
Revert "Uptime Monitor Management - Adjust monitor details page href …
468d1ae 
…for monitor management table (#122533)"

This reverts commit ba60155.
@shahzad31 shahzad31 requested a review from a team as a code owner January 31, 2022 08:47
@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Jan 31, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@shahzad31 shahzad31 added release_note:skip Skip the PR/issue when compiling release notes v8.1.0 labels Jan 31, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
uptime 708.4KB 708.4KB -51.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

dominiqueclarke
dominiqueclarke approved these changes Feb 1, 2022
View reviewed changes
Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shahzad31 shahzad31 merged commit 1af949c into main Feb 1, 2022
@shahzad31 shahzad31 deleted the revert-122533-fix/monitor-management-browser-monitor-ids branch February 1, 2022 16:48
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiqueclarke dominiqueclarke dominiqueclarke approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shahzad31 @elasticmachine @kibana-ci @dominiqueclarke @kibanamachine