Uptime Monitor Management - Adjust monitor details page href for browser monitors #122533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tor management table
dominiqueclarke
added
bug
…agement-browser-monitor-ids
|
Pinging @elastic/uptime (Team:uptime) |
shahzad31
reviewed
Jan 14, 2022
| href={`${basePath}/app/uptime/monitor/${Buffer.from( | ||
| /* Monitor Management currently only supports inline browser monitors. | ||
| * Inline browser monitors append `inline` to the monitor id */ | ||
| `${id}${type === DataStream.BROWSER ? `-inline` : ''}`, |
There was a problem hiding this comment.
i thought we are going to handle this in heartbeat elastic/beats#29505
But if you doing this as a makeshift solution. I am fine by it.
There was a problem hiding this comment.
@shahzad31 That only accounts for removing the appended - Inline in the journey title, not the id, or at least it should. We already opened pandora's box with this id scheme, we can't change it now or we'll lose the history for these monitors.
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
dominiqueclarke
changed the title
dominiqueclarke
deleted the
fix/monitor-management-browser-monitor-ids
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #121549
Summary
This PR adjusts the monitor details url in Monitor Management, specifically for browser monitors.
Depending on the type of browser monitor, inline or suite, heartbeat appends to the monitor id.
For inline monitors, the monitor id supplied by kibana is appended with
-inline.Suite monitors are not currently supported by Monitor Management, so we only have to support inline monitor ids. In a future version, this logic will need to be adjusted to account for suites.
Testing
oblt-cli./app/uptime/add-monitorand create a browser monitor/app/uptime/manage-monitorsand click on the name of the monitor to link to the monitor detail page.