[Accessibility] Avoid empty th in doc-table header row #12364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weltenwort
added
Project:Accessibility
Feature:Discover
cjcenizal
approved these changes
Jun 19, 2017
weltenwort
force-pushed
the
fix/doctable-accessibility-empty-header
branch
from
781ba27 to
68d9a14
Compare
weltenwort
force-pushed
the
fix/doctable-accessibility-empty-header
branch
from
68d9a14 to
f19e266
Compare
Bargs
approved these changes
Jun 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Note: The discover document table header cells provide appropriate hints to screen-readers.
This changes the first cell in the doc-table header row to be a
<td>instead of<th>so screen readers interpret it correctly. Additionally, thescopeattribute marks the remaining headers as being column headers.fixes #11854