Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.17] skip tests broken when testing against 8.0 #123427

Merged
merged 1 commit into from
Jan 20, 2022

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Jan 20, 2022

#123289 added the ability to skip a functional test suite when run against es 8.0. This PR uses that feature to skip all broken tests in 7.17 so that we can start running the 7.17 tests against 8.0 snapshots and work on fixing the tests (or functionality) in 7.17 that doesn't work when it's run against 8.0.

Skipping the tests allows us to see all the tests which are broken and ensure that new issues don't get added.

Examples of this branch running against the 8.0 snapshot and passing: https://buildkite.com/elastic/kibana-pull-request/builds/18605

@spalger spalger force-pushed the skip-7.17-tests-invalid-with-8.0 branch from 5c3bb96 to fecda8f Compare January 20, 2022 02:04
@spalger spalger force-pushed the skip-7.17-tests-invalid-with-8.0 branch from fecda8f to 068aa38 Compare January 20, 2022 02:10
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

  • 💔 Build #18601 failed fecda8fb46c57c62cff04fdb2e34352c1cc2df24
  • 💔 Build #18589 failed 5c3bb963b10841bafee5f5ef8f1fd07107cab2a7

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@spalger spalger added backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.17.0 labels Jan 20, 2022
@spalger spalger marked this pull request as ready for review January 20, 2022 03:49
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@spalger spalger requested review from a team January 20, 2022 03:50
@spalger spalger merged commit 8bdc018 into elastic:7.17 Jan 20, 2022
@spalger spalger deleted the skip-7.17-tests-invalid-with-8.0 branch January 20, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.17.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants