-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ftr] support filtering tests by es version #123289
[ftr] support filtering tests by es version #123289
Conversation
…rsion-test-filters
Pinging @elastic/kibana-operations (Team:Operations) |
@elasticmachine merge upstream |
…rsion-test-filters
…r/kibana into implement/es-version-test-filters
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Public APIs missing exports
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit 12e63dd)
Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit 12e63dd) # Conflicts: # packages/kbn-es-archiver/src/cli.ts # packages/kbn-test/src/functional_test_runner/cli.ts
Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit 12e63dd) # Conflicts: # packages/kbn-es-archiver/src/cli.ts # packages/kbn-test/src/functional_test_runner/cli.ts
Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit 12e63dd)
* [ftr] support filtering tests by es version (#123289) Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit 12e63dd) # Conflicts: # packages/kbn-es-archiver/src/cli.ts # packages/kbn-test/src/functional_test_runner/cli.ts * fix type error in 7.17
Add a new method to suites like
this.tags()
, for defining a valid esVersion range for the suite.This version range is then validated against the
--es-version
flag passed to the functional_test_runner CLI, the version number extracted from theES_SNAPSHOT_MANIFEST
environment variable, or the Kibana version (in that order).Any test which doesn't match the es version number will be excluded automatically.
In addition to the ability to skip a whole suite tests can be updated to use the
esVersion
service, which exposes a helpful method for conditional logic based on version ranges:To see this in action I'm also working on #123312, which backports this PR and skips all the suites which are failing in 7.17 when running that branch against an 8.0 snapshot.