Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Only show span.sync badge when relevant #123038

Merged
merged 4 commits into from
Jan 18, 2022
Merged

[APM] Only show span.sync badge when relevant #123038

merged 4 commits into from
Jan 18, 2022

Conversation

cauemarcondes
Copy link
Contributor

@cauemarcondes cauemarcondes commented Jan 14, 2022 •
edited
Loading

closes #109661

@cauemarcondes cauemarcondes added release_note:enhancement auto-backport Deprecated - use backport:version if exact versions are needed v8.1.0 labels Jan 14, 2022
@cauemarcondes cauemarcondes requested a review from a team as a code owner January 14, 2022 13:21
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Jan 14, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@cauemarcondes cauemarcondes changed the title [APM] Don't show deprecation notice in Kibana Upgrade Assistant for non-apm users [APM] Only show span.sync badge when relevant Jan 14, 2022
@cauemarcondes
Copy link
Contributor Author

@elasticmachine merge upstream

gbamparop
gbamparop approved these changes Jan 17, 2022
View reviewed changes
Copy link
Contributor

@gbamparop gbamparop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! It would be great if you could also update the stories for waterfall items to match this. There are still some go / python agents in storybook that display blocking badges

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 2.8MB 2.8MB +193.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cauemarcondes cauemarcondes merged commit b5aadc2 into elastic:main Jan 18, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jan 18, 2022
@cauemarcondes cauemarcondes deleted the apm-hide-async-badge branch January 18, 2022 17:51
@kibanamachine
Copy link
Contributor

💔 Backport failed

The pull request could not be backported due to the following error:
There are no branches to backport to. Aborting.

How to fix

Re-run the backport manually:

node scripts/backport --pr 123038

Questions ?

Please refer to the Backport tool documentation

@trentm trentm mentioned this pull request Jun 5, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbamparop gbamparop gbamparop approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed backport:skip This commit does not require backporting release_note:enhancement Team:APM All issues that need APM UI Team support v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Only show span.sync badge when relevant
5 participants
@cauemarcondes @elasticmachine @kibana-ci @kibanamachine @gbamparop