Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Only show span.sync badge when relevant #109661

Closed
sorenlouv opened this issue Aug 23, 2021 · 2 comments · Fixed by #123038
Closed

[APM] Only show span.sync badge when relevant #109661

sorenlouv opened this issue Aug 23, 2021 · 2 comments · Fixed by #123038
Assignees
Labels
apm:test-plan-done Pull request that was successfully tested during the test plan apm:ux-refresh Team:APM All issues that need APM UI Team support v8.1.0

Comments

@sorenlouv
Copy link
Member

sorenlouv commented Aug 23, 2021

Related: elastic/apm-agent-nodejs#1881

With #55113 we started showing badges for span.sync to indicate whether the span was async or blocking.

Problem
It is visually very noisy to display the badge for every span. This was raised in elastic/apm-agent-nodejs#1881

image

Solution
The badge should only be displayed when span.sync is operating in a non-default mode relative to the language in question. So for javascript the default is async so the badge should only be shown when blocking. Opposite for php.

We should talk to agent developers to get a list of the default span.sync values that we (unfortunately) have to hardcode in the ui.

@sorenlouv sorenlouv added [zube]: Inbox apm:ux-refresh Team:APM All issues that need APM UI Team support v7.16.0 labels Aug 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@cauemarcondes
Copy link
Contributor

tests ok:
only blocking should be shown for nodejs.
Screen Shot 2022-02-09 at 4 35 46 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:test-plan-done Pull request that was successfully tested during the test plan apm:ux-refresh Team:APM All issues that need APM UI Team support v8.1.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants