Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Lists] - Remove disabled exception list delete icon #122844

Merged
merged 1 commit into from
Jan 13, 2022
Merged

[Security Solution][Lists] - Remove disabled exception list delete icon #122844

merged 1 commit into from
Jan 13, 2022

Conversation

yctercero
Copy link
Contributor

@yctercero yctercero commented Jan 12, 2022 •
edited
Loading

Summary

Addresses #121761 . Instead of showing disabled exception delete icon in exceptions table, if it's disabled, simply don't show it at all.

Screen Shot 2022-01-12 at 8 37 30 AM

Checklist

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 4.6MB 4.6MB +26.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@yctercero yctercero self-assigned this Jan 12, 2022
@yctercero yctercero added release_note:fix Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Security Solution Platform Security Solution Platform Team v8.0.0 bug Fixes for quality problems that affect the customer experience labels Jan 12, 2022
@yctercero yctercero marked this pull request as ready for review January 12, 2022 21:15
@yctercero yctercero requested a review from a team as a code owner January 12, 2022 21:15
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@yctercero yctercero added v8.1.0 and removed v8.0.0 labels Jan 12, 2022
spong
spong approved these changes Jan 13, 2022
View reviewed changes
Copy link
Member

@spong spong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Checked out locally and no longer seeing the delete icon. Would be nice if the icons aligned, but suppose its intentional since this is how the basic table handles singular actions, so all good 👍

@yctercero yctercero added the auto-backport Deprecated - use backport:version if exact versions are needed label Jan 13, 2022
@yctercero
Copy link
Contributor Author

@spong thanks! I played around with it just quickly and couldn't find a quick way to align though def agree with you there.

@yctercero yctercero merged commit f47839e into elastic:main Jan 13, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jan 13, 2022
@kibanamachine
Copy link
Contributor

💔 Backport failed

The pull request could not be backported due to the following error:
There are no branches to backport to. Aborting.

How to fix

Re-run the backport manually:

node scripts/backport --pr 122844

Questions ?

Please refer to the Backport tool documentation

@yctercero yctercero mentioned this pull request Jan 13, 2022
Closed
@yctercero yctercero deleted the exceptions_delete_icon branch August 4, 2022 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spong spong spong approved these changes

Assignees

@yctercero yctercero

Labels
auto-backport Deprecated - use backport:version if exact versions are needed backport:skip This commit does not require backporting bug Fixes for quality problems that affect the customer experience release_note:fix Team:Security Solution Platform Security Solution Platform Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yctercero @kibana-ci @elasticmachine @kibanamachine @spong