Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Exceptions list delete is dissabled #121761

Closed
gavinwye opened this issue Dec 21, 2021 · 5 comments
Closed

[Security Solution] Exceptions list delete is dissabled #121761

gavinwye opened this issue Dec 21, 2021 · 5 comments
Assignees
@gavinwye @yctercero
Labels
bug Fixes for quality problems that affect the customer experience fixed QA:Validated Issue has been validated by QA Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. UX: UI/UX Consultation Requires UX lead input/consult before development and UX lead approval on PR before merge. v8.1.0

Comments

@gavinwye
Copy link

Describe the bug:
the Delete icon is disabled, if functionality is not available (there doesn't seem to be a way to delete a list) it should be hidden. We shouldn't show users elements they can't do anything with.

Kibana/Elasticsearch Stack version:
v 7.16.1

Original install method (e.g. download page, yum, from source, etc.):
Eden

Functional Area (e.g. Endpoint management, timelines, resolver, etc.):
Detections > Exceptions

Current behavior:
Delete button/icon is greyed out and inactive

Expected behavior:
Remove the icon if users can't delete the list

Screenshots (if relevant):
image
@gavinwye gavinwye added bug Fixes for quality problems that affect the customer experience triage_needed Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Dec 21, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@gavinwye gavinwye added the UX: UI/UX Consultation Requires UX lead input/consult before development and UX lead approval on PR before merge. label Dec 21, 2021
@gavinwye gavinwye self-assigned this Dec 22, 2021
@gavinwye gavinwye mentioned this issue Dec 27, 2021
Open
25 tasks
This was referenced Jan 12, 2022
Merged
Closed
yctercero added a commit that referenced this issue Jan 13, 2022
@yctercero
[Security Solution][Lists] - Remove disabled exception list delete ic…
f47839e 
…on (#122844)

### Summary

Addresses #121761 . Instead of showing disabled exception delete icon in exceptions table, if it's disabled, simply don't show it at all.
@yctercero
Copy link
Contributor

@MadameSheema PR merged and in 8.1

#122844

@gavinwye
Copy link
Author

@yctercero Thanks 😄

@MadameSheema
Copy link
Member

@deepikakeshav-qasource can you please validate this on the current 8.1BC? Thanks!

@ghost
Copy link

ghost commented Feb 14, 2022

Hi @MadameSheema ,

We have Validated this issue on 8.1.0 BC2 and observed that issue is Fixed.

Please find the below testing details:

Build Details:

Version: 8.1.0 BC2
Commit:ee89ebfddeda3baaf6cd87c0299247c5248cb952
Build:50222

Screenshot:
image

Hence, We are closing this issue and marking as QA Validated.

@ghost ghost added the QA:Validated Issue has been validated by QA label Feb 14, 2022
@ghost ghost closed this as completed Feb 14, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gavinwye gavinwye

@yctercero yctercero

Labels
bug Fixes for quality problems that affect the customer experience fixed QA:Validated Issue has been validated by QA Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. UX: UI/UX Consultation Requires UX lead input/consult before development and UX lead approval on PR before merge. v8.1.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@gavinwye @yctercero @elasticmachine @MadameSheema