Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[shared-ux] Create Services, migrate Exit Full Screen button #122499

Merged
merged 4 commits into from
Jan 10, 2022
Merged

[shared-ux] Create Services, migrate Exit Full Screen button #122499

merged 4 commits into from
Jan 10, 2022

Conversation

clintandrewhall
Copy link
Contributor

@clintandrewhall clintandrewhall commented Jan 9, 2022 •
edited
Loading

Summary

This PR does a few things:

  • Defines a service abstraction layer pattern for Shared UX;
  • Implements that service layer for Storybook, Jest, stubs and Kibana;
  • Migrates <ExitFullScreenButton /> from kibana_react.

See kibana_react/exit_full_screen_button

Next steps:

@clintandrewhall clintandrewhall added review loe:medium Medium Level of Effort release_note:skip Skip the PR/issue when compiling release notes impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. auto-backport Deprecated - use backport:version if exact versions are needed v8.1.0 v8.2.0 Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) labels Jan 9, 2022
@clintandrewhall clintandrewhall requested a review from a team January 9, 2022 02:04
@clintandrewhall
Copy link
Contributor Author

@elasticmachine merge upstream

@clintandrewhall clintandrewhall requested a review from a team January 9, 2022 02:09
@clintandrewhall clintandrewhall force-pushed the sharedux/services-exit branch 3 times, most recently from 63e0db4 to 62f69fa Compare January 10, 2022 04:48
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
sharedUX 4 16 +12

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
sharedUX 6 4 -2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
sharedUX 0.0B 2.3KB +2.3KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
sharedUX 0 1 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
sharedUX 1.2KB 3.7KB +2.5KB
Unknown metric groups

API count

id before after diff
sharedUX 6 10 +4

async chunk count

id before after diff
sharedUX 0 1 +1

ESLint disabled in files

id before after diff
sharedUX 0 3 +3

ESLint disabled line counts

id before after diff
sharedUX 6 1 -5

Total ESLint disabled count

id before after diff
sharedUX 6 4 -2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@clintandrewhall clintandrewhall merged commit 5f07a0f into elastic:main Jan 10, 2022
cchaos
cchaos suggested changes Jan 10, 2022
View reviewed changes
...ns/shared_ux/public/components/exit_full_screen_button/exit_full_screen_button.component.tsx
`;

const buttonCSS = css`
&.euiButton {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clintandrewhall Is there any way not to target .eui classes? This really shouldn't be necessary and should be applying custom class names instead like the original Sass did: https://github.com/elastic/kibana/blob/main/src/plugins/kibana_react/public/exit_full_screen_button/_exit_full_screen_button.scss

In EUI, we don't consider changes to internal classes to be breaking changes and when we do (and could very soon) this will break your styles.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we discussed, I'm opening a follow-up PR to address this, and will follow up with EUI to document issues. Thanks for your help here, @cchaos !!

@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
❌ 8.2 The branch "8.2" is invalid or doesn't exist

How to fix

Re-run the backport manually:

node scripts/backport --pr 122499

Questions ?

Please refer to the Backport tool documentation

@cchaos cchaos mentioned this pull request Jan 10, 2022
Merged
@clintandrewhall clintandrewhall mentioned this pull request Jan 10, 2022
Open
5 tasks
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jan 12, 2022
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 122499 or prevent reminders by adding the backport:skip label.

1 similar comment
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 122499 or prevent reminders by adding the backport:skip label.

@rshen91 rshen91 mentioned this pull request Jan 13, 2022
Open
15 tasks
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 122499 or prevent reminders by adding the backport:skip label.

4 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 122499 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 122499 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 122499 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 122499 or prevent reminders by adding the backport:skip label.

@clintandrewhall clintandrewhall added backport:skip This commit does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. auto-backport Deprecated - use backport:version if exact versions are needed labels Jan 21, 2022
@clintandrewhall clintandrewhall mentioned this pull request Feb 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cchaos cchaos cchaos requested changes

@rshen91 rshen91 rshen91 approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort release_note:skip Skip the PR/issue when compiling release notes review Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@clintandrewhall @kibana-ci @kibanamachine @cchaos @rshen91