Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deprecation] ExitFullScreenButton migration #125752

Closed
Tracked by #122499
clintandrewhall opened this issue Feb 16, 2022 · 7 comments
Closed
Tracked by #122499

[deprecation] ExitFullScreenButton migration #125752

clintandrewhall opened this issue Feb 16, 2022 · 7 comments
Labels
Feature:Dashboard Dashboard related features Feature:Maps Feature:Timeline Security Solution Timeline feature impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Detection Engine Security Solution Detection Engine Area Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)

Comments

@clintandrewhall
Copy link
Contributor

clintandrewhall commented Feb 16, 2022

See: #125750

The ExitFullScreenButton in kibana_react has been deprecated. There are currently two active plugins where this component is used, and two questions about consistency in Kibana. This issue will track migration in order to facilitate deleting the old button and removing page bundle bloat (#114990)

Awaiting Migration

Once these plugins move to the new component, the issue raised in #114990 will be addressed for the deprecated component.

Team Plugin Status Notes
@elastic/kibana-presentation Dashboard @ThomThomson
@elastic/kibana-gis Maps @nreese

Open Questions

These questions remain open for other teams and plugins.

Team Plugin Status Notes
@elastic/kibana-presentation Canvas ⬜️ Why doesn't Canvas use an Exit Full Screen button? @ryankeairns @elastic/kibana-design (see #35984 (comment))
@elastic/security-solution Security Solution ⬜️ Should this button be replaced?
@elastic/security-threat-hunting Timelines ⬜️ Should this button be replaced?
@clintandrewhall clintandrewhall added Feature:Dashboard Dashboard related features [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:small Small Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Feature:Canvas Team:Security Solution Platform Security Solution Platform Team Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) labels Feb 16, 2022
@clintandrewhall clintandrewhall added the Feature:Timeline Security Solution Timeline feature label Feb 16, 2022
@nreese
Copy link
Contributor

nreese commented Feb 16, 2022

Opened #125786, to track maps migration

@ryankeairns
Copy link
Contributor

Why doesn't Canvas use an Exit Full Screen button?

I don't recall if it was clear decision not to include it, but I suspect it would be of annoyance when you're presenting in full screen mode given that it is always visible/overlaid. Perhaps if it only showed on hover or focus would negate that.

@cchaos
Copy link
Contributor

cchaos commented Feb 16, 2022

annoyance when you're presenting in full screen mode given that it is always visible/overlaid

To be honest this is a general problem with it that affects dashboards as well. We should pursue looking into other options for placement for all usages, but implement the changes in the new Shared UX component.

@clintandrewhall
Copy link
Contributor Author

@ryankeairns @cchaos We could go the route that if the mouse doesn't move, the button fades away and returns if the mouse moves? We've seen that pattern in other apps.

But I agree: we should code that into this component so all benefit.

@ryankeairns
Copy link
Contributor

FWIW, Google Slides shows this bit of UI only when you hover/focus on the bottom left portion of the screen and it fades as you move out.

Screen Shot 2022-02-17 at 12 34 59 PM

Bonus: They also show a brief tip upon entering full screen that you can press ESC to exit.

Screen Shot 2022-02-17 at 12 35 11 PM

@clintandrewhall
Copy link
Contributor Author

@ryankeairns Nice. All things we should consider here, and stuff we can bake into this component.

@jb1b84 jb1b84 added Feature:Maps and removed [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation labels Nov 3, 2022
@ThomThomson ThomThomson removed the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Apr 10, 2023
@yctercero yctercero added Team:Detection Engine Security Solution Detection Engine Area and removed Team:Security Solution Platform Security Solution Platform Team labels May 14, 2023
@Dosant
Copy link
Contributor

Dosant commented Jul 18, 2024

I think this was done

@Dosant Dosant closed this as not planned Won't fix, can't repro, duplicate, stale Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Dashboard Dashboard related features Feature:Maps Feature:Timeline Security Solution Timeline feature impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Detection Engine Security Solution Detection Engine Area Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)
Projects
None yet
Development

No branches or pull requests

9 participants