-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[deprecation] ExitFullScreenButton
migration
#125752
Comments
Opened #125786, to track maps migration |
I don't recall if it was clear decision not to include it, but I suspect it would be of annoyance when you're presenting in full screen mode given that it is always visible/overlaid. Perhaps if it only showed on hover or focus would negate that. |
To be honest this is a general problem with it that affects dashboards as well. We should pursue looking into other options for placement for all usages, but implement the changes in the new Shared UX component. |
@ryankeairns @cchaos We could go the route that if the mouse doesn't move, the button fades away and returns if the mouse moves? We've seen that pattern in other apps. But I agree: we should code that into this component so all benefit. |
@ryankeairns Nice. All things we should consider here, and stuff we can bake into this component. |
I think this was done |
The
ExitFullScreenButton
inkibana_react
has been deprecated. There are currently two active plugins where this component is used, and two questions about consistency in Kibana. This issue will track migration in order to facilitate deleting the old button and removing page bundle bloat (#114990)Awaiting Migration
Once these plugins move to the new component, the issue raised in #114990 will be addressed for the deprecated component.
Open Questions
These questions remain open for other teams and plugins.
The text was updated successfully, but these errors were encountered: