-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix autocomplete suggestions for repository of type fs
(typo)
#120775
Fix autocomplete suggestions for repository of type fs
(typo)
#120775
Conversation
Pinging @elastic/kibana-stack-management (Team:Stack Management) |
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for patching this up @yuliacech! Changes make sense, tested locally and all works as expected 🚀
I also experienced the same problem in which the autocompletion for settings is always for fs
, is there a bug open for that or should we open one?
Thank you for the review, @sabarasaba! I opened this issue #120888 for the template bug. |
💔 Backport failedThe backport operation could not be completed due to the following error: The backport PRs will be merged automatically after passing CI. To backport manually run: |
Summary
While investigating alternative solutions for #120512 I noticed that autocomplete suggestions for repository
settings
of typefs
were not working. Other repository types have autocomplete suggestions forsettings
.NOTE: I'm not sure why, but template autocompletion (the default object printed out when
settings
is selected) is always the template for typefs
.Before
Screen.Recording.2021-12-08.at.16.07.45.mov
After
Screen.Recording.2021-12-08.at.16.06.12.mov