Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix autocomplete suggestions for repository of type fs (typo) #120775

Merged
merged 1 commit into from
Dec 9, 2021

Conversation

yuliacech
Copy link
Contributor

Summary

While investigating alternative solutions for #120512 I noticed that autocomplete suggestions for repository settings of type fs were not working. Other repository types have autocomplete suggestions for settings.
NOTE: I'm not sure why, but template autocompletion (the default object printed out when settings is selected) is always the template for type fs.

Before

Screen.Recording.2021-12-08.at.16.07.45.mov

After

Screen.Recording.2021-12-08.at.16.06.12.mov

@yuliacech yuliacech added Feature:Console Dev Tools Console Feature Feature:Dev Tools release_note:fix Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.1.0 labels Dec 8, 2021
@yuliacech yuliacech requested a review from a team as a code owner December 8, 2021 15:11
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-stack-management (Team:Stack Management)

@yuliacech yuliacech requested a review from sabarasaba December 8, 2021 15:11
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@sabarasaba sabarasaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for patching this up @yuliacech! Changes make sense, tested locally and all works as expected 🚀

I also experienced the same problem in which the autocompletion for settings is always for fs, is there a bug open for that or should we open one?

@yuliacech
Copy link
Contributor Author

Thank you for the review, @sabarasaba! I opened this issue #120888 for the template bug.

@yuliacech yuliacech added the auto-backport Deprecated - use backport:version if exact versions are needed label Dec 9, 2021
@yuliacech yuliacech merged commit 0c32b8d into elastic:main Dec 9, 2021
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Dec 9, 2021
@kibanamachine
Copy link
Contributor

💔 Backport failed

The backport operation could not be completed due to the following error:
There are no branches to backport to. Aborting.

The backport PRs will be merged automatically after passing CI.

To backport manually run:
node scripts/backport --pr 120775

TinLe pushed a commit to TinLe/kibana that referenced this pull request Dec 22, 2021
@yuliacech yuliacech deleted the snapshot_conditional_typo_fix branch March 7, 2022 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed backport:skip This commit does not require backporting Feature:Console Dev Tools Console Feature Feature:Dev Tools release_note:fix Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants