Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CTI] Threat Intel Card on Overview page needs to accommodate Fleet TI integrations - #120459

Merged
merged 35 commits into from
Dec 7, 2021
Merged

[CTI] Threat Intel Card on Overview page needs to accommodate Fleet TI integrations - #120459

merged 35 commits into from
Dec 7, 2021

Conversation

nkhristinin
Copy link
Contributor

@nkhristinin nkhristinin commented Dec 6, 2021 •
edited
Loading

Summary

Small fixes of this PR, because looks like after successful build and clicking merge button into main was merged PR which trigger some conflicts.

Here the fix of this conflicts

@nkhristinin
Add support integrations
6f936c0
@nkhristinin
Fix types
9895973
@nkhristinin
fix unit tests
9ca6afe
@nkhristinin
Fix tests and types
68aaf7f
@nkhristinin
fix eslint
02a02ef
@nkhristinin
fix file case
38abcc7
@nkhristinin
add cy tests
2ba2af5
@nkhristinin
Revert test
ac8d3e3
@nkhristinin
Add tests
fbef6f1
@nkhristinin
Add support of installed integrations
79920c5
@nkhristinin
Fix types
98025cc
@nkhristinin
Add isntalled ingtegration case for cypress tests
78dbb5a
@nkhristinin
Fix cypress tests
3cc960d
@nkhristinin
Fix comments
4ab0017
@nkhristinin
Fix capital naming
f716d40
@nkhristinin
Fix again capital naming
8ddb2e6
@nkhristinin
Add dynamic dashboard for a new integrations packages
37c8469
@nkhristinin
intermidiate changes, to keep it remote
2a0f82e
@nkhristinin
Big refactoring
c417830
@nkhristinin
Tests and refactoring
954fab2
@nkhristinin
Remove unused constanrs
61f11ce
@nkhristinin
Fix e2e tests
727ec1b
@nkhristinin
PR comments fix
0a2d6f4
@nkhristinin
fix ts
1d01df2
@nkhristinin
Fix translations
1454bae
@nkhristinin
Remove stubs
7088bbb
@nkhristinin
Rename isSomeIntegrationsDisabled -> allIntegrationsInstalled
4b6e027
@nkhristinin
Add buildQuery tests
c654e62
@nkhristinin
Fix type
d86b0d2
@nkhristinin
Add tests for Enable Source button
378411d
@nkhristinin nkhristinin requested review from a team as code owners December 6, 2021 10:24
@nkhristinin nkhristinin self-assigned this Dec 6, 2021
@nkhristinin nkhristinin added v8.0.0 auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team: CTI labels Dec 6, 2021
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 2800 2798 -2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 4.6MB 4.6MB -2.0KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 243.7KB 245.4KB +1.7KB
Unknown metric groups

References to deprecated APIs

id before after diff
securitySolution 55 54 -1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nkhristinin

ecezalp
ecezalp approved these changes Dec 6, 2021
View reviewed changes
Copy link
Contributor

@ecezalp ecezalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same changes from the last PR which was approved, LGTM

@ecezalp ecezalp enabled auto-merge (squash) December 6, 2021 20:44
@ecezalp ecezalp merged commit acad16d into elastic:main Dec 7, 2021
@kibanamachine
Copy link
Contributor

The following labels were identified as gaps in your version labels and will be added automatically:

  • v8.1.0

If any of these should not be on your pull request, please manually remove them.

@kibanamachine kibanamachine mentioned this pull request Dec 7, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 7, 2021
@nkhristinin @kibanamachine
[CTI] Threat Intel Card on Overview page needs to accommodate Fleet T…
eec9a15 
…I integrations - (elastic#120459)

* Add support integrations

* Fix types

* fix unit tests

* Fix tests and types

* fix eslint

* fix file case

* add cy tests

* Revert test

* Add tests

* Add support of installed integrations

* Fix types

* Add isntalled ingtegration case for cypress tests

* Fix cypress tests

* Fix comments

* Fix capital naming

* Fix again capital naming

* Add dynamic dashboard for a new integrations packages

* intermidiate changes, to keep it remote

* Big refactoring

* Tests and refactoring

* Remove unused constanrs

* Fix e2e tests

* PR comments fix

* fix ts

* Fix translations

* Remove stubs

* Rename isSomeIntegrationsDisabled -> allIntegrationsInstalled

* Add buildQuery tests

* Fix type

* Add tests for Enable Source button

* Remove copied file

* Move api call to api.ts

* Rename fetchFleetIntegrations

* Remove __mocks__

* Fix path
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 8.0

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Dec 7, 2021
@kibanamachine @nkhristinin
[CTI] Threat Intel Card on Overview page needs to accommodate Fleet T…
e71d6dc 
…I integrations - (#120459) (#120578)

* Add support integrations

* Fix types

* fix unit tests

* Fix tests and types

* fix eslint

* fix file case

* add cy tests

* Revert test

* Add tests

* Add support of installed integrations

* Fix types

* Add isntalled ingtegration case for cypress tests

* Fix cypress tests

* Fix comments

* Fix capital naming

* Fix again capital naming

* Add dynamic dashboard for a new integrations packages

* intermidiate changes, to keep it remote

* Big refactoring

* Tests and refactoring

* Remove unused constanrs

* Fix e2e tests

* PR comments fix

* fix ts

* Fix translations

* Remove stubs

* Rename isSomeIntegrationsDisabled -> allIntegrationsInstalled

* Add buildQuery tests

* Fix type

* Add tests for Enable Source button

* Remove copied file

* Move api call to api.ts

* Rename fetchFleetIntegrations

* Remove __mocks__

* Fix path

Co-authored-by: Khristinin Nikita <[email protected]>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Dec 7, 2021
@jloleysens
Merge branch 'main' of github.com:elastic/kibana into reporting/close…
364ffac 
…-chromium-before-compiling-pdf

* 'main' of github.com:elastic/kibana: (121 commits)
  FTR should use the new kibana_system user (elastic#120436)
  [Lens] Temporarily exclude Mosaic/Waffle from the suggestions list (elastic#120488)
  [Reporting] Fix slow CSV with large max size bytes (elastic#120365)
  [CTI] Threat Intel Card on Overview page needs to accommodate Fleet TI integrations -  (elastic#120459)
  [Dashboard] Added KibanaThemeProvider.  (elastic#120122)
  add more rule_registry unit tests (elastic#120323)
  [Lens] update xpack.lens.pie.smallValuesWarningMessage text (elastic#120478)
  [Fleet] Simplified package policy create API, enriching default values (elastic#119739)
  mock `elastic-apm-node` in `@kbn/test` jest preset (elastic#120324)
  [RAC] Rename occurrences of alert_type to rule_type in Infra (elastic#120455)
  [Security Solutions] Removes tech debt of exporting all from linter rule for timeline plugin (elastic#120437)
  [Workplace Search] Add API Keys view to replace Access tokens (elastic#120147)
  [Security Solutions] Removes tech debt of exporting all from linter rule for cases plugin in the server section (elastic#120411)
  Add support for threat.feed.name (elastic#120250)
  [Rule Registry] Rewrite APM registry rules for Observability (elastic#117740)
  [docs] Fix artifact layout formatting (elastic#119386)
  [Workplace Search] Add a technical preview of connecting GitHub via GitHub apps (elastic#119764)
  add osquery notes for 7.16 (elastic#120407)
  chore(NA): splits types from code on @kbn/docs-utils (elastic#120533)
  [Reporting] Decouple screenshotting plugin from the reporting (elastic#120110)
  ...

# Conflicts:
#	x-pack/plugins/reporting/server/browsers/chromium/driver_factory/index.test.ts
#	x-pack/plugins/reporting/server/browsers/chromium/driver_factory/index.ts
#	x-pack/plugins/reporting/server/lib/screenshots/observable.test.ts
#	x-pack/plugins/reporting/server/lib/screenshots/observable.ts
#	x-pack/plugins/reporting/server/test_helpers/create_mock_browserdriverfactory.ts
TinLe pushed a commit to TinLe/kibana that referenced this pull request Dec 22, 2021
@nkhristinin @TinLe
[CTI] Threat Intel Card on Overview page needs to accommodate Fleet T…
328595a 
…I integrations - (elastic#120459)

* Add support integrations

* Fix types

* fix unit tests

* Fix tests and types

* fix eslint

* fix file case

* add cy tests

* Revert test

* Add tests

* Add support of installed integrations

* Fix types

* Add isntalled ingtegration case for cypress tests

* Fix cypress tests

* Fix comments

* Fix capital naming

* Fix again capital naming

* Add dynamic dashboard for a new integrations packages

* intermidiate changes, to keep it remote

* Big refactoring

* Tests and refactoring

* Remove unused constanrs

* Fix e2e tests

* PR comments fix

* fix ts

* Fix translations

* Remove stubs

* Rename isSomeIntegrationsDisabled -> allIntegrationsInstalled

* Add buildQuery tests

* Fix type

* Add tests for Enable Source button

* Remove copied file

* Move api call to api.ts

* Rename fetchFleetIntegrations

* Remove __mocks__

* Fix path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecezalp ecezalp ecezalp approved these changes

@MadameSheema MadameSheema MadameSheema approved these changes

Assignees

@nkhristinin nkhristinin

Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team: CTI v8.0.0 v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nkhristinin @kibana-ci @kibanamachine @MadameSheema @ecezalp