-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rule Registry] Rewrite APM registry rules for Observability #117740
[Rule Registry] Rewrite APM registry rules for Observability #117740
Conversation
…write-apm-rule-registry-test
…write-apm-rule-registry-test
…write-apm-rule-registry-test
@simianhacker fwiw, this was already an API test? |
@dgieselaar Not sure what you mean? It was an API test under APM. From the description in the linked issue, @weltenwort wanted it moved to Observability. |
@simianhacker this issue description says:
But APM's Registry Rules tests were already part of the Kibana API tests. They were not written with Cypress. |
@dgieselaar Sorry... I misunderstood, I thought the tests under |
@dgieselaar I'm not sure if you want to "re-review" this. I moved all the tests under |
…write-apm-rule-registry-test
x-pack/test/rule_registry/common/lib/helpers/cleanup_target_indices.ts
Outdated
Show resolved
Hide resolved
…write-apm-rule-registry-test
…write-apm-rule-registry-test
@@ -22,8 +22,9 @@ export default ({ loadTestFile, getService }: FtrProviderContext): void => { | |||
await deleteSpaces(getService); | |||
}); | |||
|
|||
// Basic | |||
// Trial |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was Basic the old marketing name? Nevermind, it seems you're fixing some copypasta.
FYI the link to APM's Registry Rules test in the description is broken. |
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
…#117740) * [Actionable Observability] Rewrite APM registry rules for Observability * removing apm's rule registry test * Moving everything under observability_api_integration * removing old observability directory under api_integrations since it's not being used * removing observability from api_integration tests * renaming file * moving test to x-pack/test/rule_registry * Adding error handing to cleanupTargetIndices Co-authored-by: Kibana Machine <[email protected]>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
#120557) * [Actionable Observability] Rewrite APM registry rules for Observability * removing apm's rule registry test * Moving everything under observability_api_integration * removing old observability directory under api_integrations since it's not being used * removing observability from api_integration tests * renaming file * moving test to x-pack/test/rule_registry * Adding error handing to cleanupTargetIndices Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Chris Cowan <[email protected]>
…-chromium-before-compiling-pdf * 'main' of github.com:elastic/kibana: (121 commits) FTR should use the new kibana_system user (elastic#120436) [Lens] Temporarily exclude Mosaic/Waffle from the suggestions list (elastic#120488) [Reporting] Fix slow CSV with large max size bytes (elastic#120365) [CTI] Threat Intel Card on Overview page needs to accommodate Fleet TI integrations - (elastic#120459) [Dashboard] Added KibanaThemeProvider. (elastic#120122) add more rule_registry unit tests (elastic#120323) [Lens] update xpack.lens.pie.smallValuesWarningMessage text (elastic#120478) [Fleet] Simplified package policy create API, enriching default values (elastic#119739) mock `elastic-apm-node` in `@kbn/test` jest preset (elastic#120324) [RAC] Rename occurrences of alert_type to rule_type in Infra (elastic#120455) [Security Solutions] Removes tech debt of exporting all from linter rule for timeline plugin (elastic#120437) [Workplace Search] Add API Keys view to replace Access tokens (elastic#120147) [Security Solutions] Removes tech debt of exporting all from linter rule for cases plugin in the server section (elastic#120411) Add support for threat.feed.name (elastic#120250) [Rule Registry] Rewrite APM registry rules for Observability (elastic#117740) [docs] Fix artifact layout formatting (elastic#119386) [Workplace Search] Add a technical preview of connecting GitHub via GitHub apps (elastic#119764) add osquery notes for 7.16 (elastic#120407) chore(NA): splits types from code on @kbn/docs-utils (elastic#120533) [Reporting] Decouple screenshotting plugin from the reporting (elastic#120110) ... # Conflicts: # x-pack/plugins/reporting/server/browsers/chromium/driver_factory/index.test.ts # x-pack/plugins/reporting/server/browsers/chromium/driver_factory/index.ts # x-pack/plugins/reporting/server/lib/screenshots/observable.test.ts # x-pack/plugins/reporting/server/lib/screenshots/observable.ts # x-pack/plugins/reporting/server/test_helpers/create_mock_browserdriverfactory.ts
…#117740) * [Actionable Observability] Rewrite APM registry rules for Observability * removing apm's rule registry test * Moving everything under observability_api_integration * removing old observability directory under api_integrations since it's not being used * removing observability from api_integration tests * renaming file * moving test to x-pack/test/rule_registry * Adding error handing to cleanupTargetIndices Co-authored-by: Kibana Machine <[email protected]>
Summary
This PR closes #110637 by rewriting APM's Registry Rules test and moving it to the Rule Registry tests.
Checklist