Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rule Registry][Security Solution] AlertWithPersistence return only alerts that were actually indexed #120439

Merged
merged 2 commits into from
Dec 7, 2021
Merged

[Rule Registry][Security Solution] AlertWithPersistence return only alerts that were actually indexed #120439

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e8ae250
AlertWithPersistence return only alerts that were actually indexed
marshallmain Dec 4, 2021
91b7102
Merge branch 'main' into alert-persistence-update
kibanamachine Dec 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion x-pack/plugins/rule_registry/server/rule_data_client/rule_data_client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ export class RuleDataClient implements IRuleDataClient {
return clusterClient.bulk(requestWithDefaultParameters).then((response) => {
if (response.body.errors) {
const error = new errors.ResponseError(response);
throw error;
this.options.logger.error(error);
}
return response;
});
Expand Down
18 changes: 10 additions & 8 deletions x-pack/plugins/rule_registry/server/utils/create_persistence_rule_type_wrapper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,14 +106,16 @@ export const createPersistenceRuleTypeWrapper: CreatePersistenceRuleTypeWrapper
}

return {
createdAlerts: augmentedAlerts.map((alert, idx) => {
const responseItem = response.body.items[idx].create;
return {
_id: responseItem?._id ?? '',
_index: responseItem?._index ?? '',
...alert._source,
};
}),
createdAlerts: augmentedAlerts
.map((alert, idx) => {
const responseItem = response.body.items[idx].create;
return {
_id: responseItem?._id ?? '',
_index: responseItem?._index ?? '',
...alert._source,
};
})
.filter((_, idx) => response.body.items[idx].create?.status === 201),
};
} else {
logger.debug('Writing is disabled.');
Expand Down