[Rule Registry][Security Solution] AlertWithPersistence return only alerts that were actually indexed #120439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marshallmain
added
auto-backport
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
15 tasks
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 7, 2021
…lastic#120439) Co-authored-by: Kibana Machine <[email protected]>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Dec 7, 2021
…120439) (#120669) Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Marshall Main <[email protected]>
TinLe
pushed a commit
to TinLe/kibana
that referenced
this pull request
Dec 22, 2021
…lastic#120439) Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the rule data client returns
undefinedif any errors are encountered in the bulk indexing request. This can hide the fact that some of the bulk index operations actually succeeded and created or updated alerts. This PR updates thebulkmethod so it still returns the response to the caller if errors are encountered and the caller can handle the errors appropriately.In the Persistence Rule Type, appropriate handling of errors means checking which of the bulk operations succeeded and returning those as
createdAlerts. ThesecreatedAlertsare made available in the actions context later on, so it's important that any created alerts are returned, but also alerts that were submitted in the bulk request but were not actually created are not returned.