Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove soft limit for snapshot repositories #118634

Merged
merged 5 commits into from
Nov 17, 2021
Merged

Remove soft limit for snapshot repositories #118634

merged 5 commits into from
Nov 17, 2021

Conversation

jrodewig
Copy link
Contributor

@jrodewig jrodewig commented Nov 15, 2021

Summary

With elastic/elasticsearch#74350, we no longer recommend a 200 snapshot soft limit for snapshot repositories or SLM policies. This removes a related sentence from the Snapshot Policy UI.

It also updates the docs link to point to the create snapshot docs, which include guidance on snapshot retention, rather than the put SLM policy API docs.

Relates to elastic/elasticsearch#80745

CC @Leaf-Lin @original-brownbear

Before

Screen Shot 2021-11-16 at 9 16 37 AM

After

Screen Shot 2021-11-16 at 9 39 53 AM

@jrodewig jrodewig added Feature:Snapshot and Restore Elasticsearch snapshots and repositories UI Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.0.0 v8.1.0 labels Nov 16, 2021
@jrodewig jrodewig marked this pull request as ready for review November 16, 2021 17:32
@jrodewig jrodewig requested a review from a team as a code owner November 16, 2021 17:32
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-stack-management (Team:Stack Management)

@jrodewig jrodewig added v7.16.1 release_note:skip Skip the PR/issue when compiling release notes labels Nov 16, 2021
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
snapshotRestore 258.6KB 258.4KB -110.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@sabarasaba sabarasaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @jrodewig! code changes lgtm, didn't test locally

@jrodewig jrodewig merged commit 38e3c09 into elastic:main Nov 17, 2021
@jrodewig jrodewig deleted the docs__remove-200-snapshot-soft-limit branch November 17, 2021 15:27
jrodewig added a commit that referenced this pull request Nov 17, 2021
With elastic/elasticsearch#74350, we no longer recommend a 200 snapshot soft limit for snapshot repositories or SLM policies. This removes a related sentence from the Snapshot Policy UI.

It also updates the docs link to point to the [create snapshot docs](https://www.elastic.co/guide/en/elasticsearch/reference/master/snapshots-take-snapshot.html), which include guidance on snapshot retention, rather than the [put SLM policy API docs](https://www.elastic.co/guide/en/elasticsearch/reference/master/slm-api-put-policy.html).

Relates to elastic/elasticsearch#80745
jrodewig added a commit that referenced this pull request Nov 17, 2021
With elastic/elasticsearch#74350, we no longer recommend a 200 snapshot soft limit for snapshot repositories or SLM policies. This removes a related sentence from the Snapshot Policy UI.

It also updates the docs link to point to the [create snapshot docs](https://www.elastic.co/guide/en/elasticsearch/reference/master/snapshots-take-snapshot.html), which include guidance on snapshot retention, rather than the [put SLM policy API docs](https://www.elastic.co/guide/en/elasticsearch/reference/master/slm-api-put-policy.html).

Relates to elastic/elasticsearch#80745
TinLe pushed a commit to TinLe/kibana that referenced this pull request Nov 20, 2021
With elastic/elasticsearch#74350, we no longer recommend a 200 snapshot soft limit for snapshot repositories or SLM policies. This removes a related sentence from the Snapshot Policy UI.

It also updates the docs link to point to the [create snapshot docs](https://www.elastic.co/guide/en/elasticsearch/reference/master/snapshots-take-snapshot.html), which include guidance on snapshot retention, rather than the [put SLM policy API docs](https://www.elastic.co/guide/en/elasticsearch/reference/master/slm-api-put-policy.html).

Relates to elastic/elasticsearch#80745
dmlemeshko pushed a commit that referenced this pull request Nov 29, 2021
With elastic/elasticsearch#74350, we no longer recommend a 200 snapshot soft limit for snapshot repositories or SLM policies. This removes a related sentence from the Snapshot Policy UI.

It also updates the docs link to point to the [create snapshot docs](https://www.elastic.co/guide/en/elasticsearch/reference/master/snapshots-take-snapshot.html), which include guidance on snapshot retention, rather than the [put SLM policy API docs](https://www.elastic.co/guide/en/elasticsearch/reference/master/slm-api-put-policy.html).

Relates to elastic/elasticsearch#80745
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Snapshot and Restore Elasticsearch snapshots and repositories UI release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.16.1 v8.0.0 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants