Skip to content

Commit

Permalink
Remove soft limit for snapshot repositories (#118634)
Browse files Browse the repository at this point in the history
With elastic/elasticsearch#74350, we no longer recommend a 200 snapshot soft limit for snapshot repositories or SLM policies. This removes a related sentence from the Snapshot Policy UI.

It also updates the docs link to point to the [create snapshot docs](https://www.elastic.co/guide/en/elasticsearch/reference/master/snapshots-take-snapshot.html), which include guidance on snapshot retention, rather than the [put SLM policy API docs](https://www.elastic.co/guide/en/elasticsearch/reference/master/slm-api-put-policy.html).

Relates to elastic/elasticsearch#80745
  • Loading branch information
jrodewig authored Nov 17, 2021
1 parent c983bd9 commit 38e3c09
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ import {
EuiButtonEmpty,
EuiFieldNumber,
EuiSelect,
EuiCode,
} from '@elastic/eui';

import { SlmPolicyPayload } from '../../../../../common/types';
Expand Down Expand Up @@ -139,10 +138,7 @@ export const PolicyStepRetention: React.FunctionComponent<StepProps> = ({
description={
<FormattedMessage
id="xpack.snapshotRestore.policyForm.stepRetention.countDescription"
defaultMessage="The minimum and maximum number of snapshots to store in your cluster. It should not exceed {maxNumber}."
values={{
maxNumber: <EuiCode>200</EuiCode>,
}}
defaultMessage="The minimum and maximum number of snapshots to store for the policy."
/>
}
fullWidth
Expand Down Expand Up @@ -225,13 +221,13 @@ export const PolicyStepRetention: React.FunctionComponent<StepProps> = ({
<EuiButtonEmpty
size="s"
flush="right"
href={docLinks.links.apis.putSnapshotLifecyclePolicy}
href={docLinks.links.snapshotRestore.createSnapshot}
target="_blank"
iconType="help"
>
<FormattedMessage
id="xpack.snapshotRestore.policyForm.stepRetention.docsButtonLabel"
defaultMessage="Snapshot retention docs"
defaultMessage="Snapshot docs"
/>
</EuiButtonEmpty>
</EuiFlexItem>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ export const PolicyStepSettings: React.FunctionComponent<StepProps> = ({
>
<FormattedMessage
id="xpack.snapshotRestore.policyForm.stepSettings.docsButtonLabel"
defaultMessage="Snapshot settings docs"
defaultMessage="Snapshot docs"
/>
</EuiButtonEmpty>
</EuiFlexItem>
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/translations/translations/ja-JP.json
Original file line number Diff line number Diff line change
Expand Up @@ -22989,7 +22989,7 @@
"xpack.snapshotRestore.policyForm.stepLogistics.snapshotNameDescription": "スナップショットの名前です。それぞれの名前に自動的に追加される固有の識別子です。",
"xpack.snapshotRestore.policyForm.stepLogistics.snapshotNameDescriptionTitle": "スナップショット名",
"xpack.snapshotRestore.policyForm.stepLogisticsTitle": "ロジスティクス",
"xpack.snapshotRestore.policyForm.stepRetention.countDescription": "クラスターに格納するスナップショットの最少数と最大数。{maxNumber} 以下でなければなりません。",
"xpack.snapshotRestore.policyForm.stepRetention.countDescription": "クラスターに格納するスナップショットの最少数と最大数。",
"xpack.snapshotRestore.policyForm.stepRetention.countTitle": "保存するスナップショット",
"xpack.snapshotRestore.policyForm.stepRetention.docsButtonLabel": "スナップショット保存ドキュメント",
"xpack.snapshotRestore.policyForm.stepRetention.expirationDescription": "スナップショットの削除までに待つ時間です。",
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/translations/translations/zh-CN.json
Original file line number Diff line number Diff line change
Expand Up @@ -23376,7 +23376,7 @@
"xpack.snapshotRestore.policyForm.stepLogistics.snapshotNameDescription": "快照的名称。唯一标识符将自动添加到每个名称中。",
"xpack.snapshotRestore.policyForm.stepLogistics.snapshotNameDescriptionTitle": "快照名称",
"xpack.snapshotRestore.policyForm.stepLogisticsTitle": "运筹",
"xpack.snapshotRestore.policyForm.stepRetention.countDescription": "在您的集群中要存储的最小和最大快照数目。不应超过 {maxNumber}。",
"xpack.snapshotRestore.policyForm.stepRetention.countDescription": "在您的集群中要存储的最小和最大快照数目。",
"xpack.snapshotRestore.policyForm.stepRetention.countTitle": "要保留的快照",
"xpack.snapshotRestore.policyForm.stepRetention.docsButtonLabel": "快照保留文档",
"xpack.snapshotRestore.policyForm.stepRetention.expirationDescription": "删除快照前要等候的时间。",
Expand Down

0 comments on commit 38e3c09

Please sign in to comment.