Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Canvas] Filters panel with filter group update functionality. #117649

Closed
wants to merge 126 commits into from
Closed

[Canvas] Filters panel with filter group update functionality. #117649

wants to merge 126 commits into from

Conversation

Kuznietsov
Copy link
Contributor

Introduction

At this PR the feature from this issue was extended by the functionality of updating the filter group of the filter directly from the Filters panel.

Screenshots

Changing filter group to the filter group of the element.

Screenshot 2021-11-05 at 14 46 30
Screenshot 2021-11-05 at 14 46 43

Displaying all the filters, depending to the group of the element with an ability to update.

Screenshot 2021-11-05 at 14 46 52
Screenshot 2021-11-05 at 14 48 54

Changing the group is updating the element view.

Screenshot 2021-11-05 at 14 49 14

Kuznietsov and others added 30 commits October 27, 2021 12:52
@Kuznietsov
Added new GlobalConfig layout.
88d7c79
@Kuznietsov
Removed not used section.
9e471e6
@Kuznietsov
Added filter components.
7737f1f
@Kuznietsov
Fixed rows of filter keys.
24b65ae
@Kuznietsov
Added filterViews and their transforming.
6da422e
@Kuznietsov
Refactored getFilterFormatter method.
10d3ccd
@Kuznietsov
Fixed typo.
a4c8748
@Kuznietsov
Added types.
457d7ad
@Kuznietsov
Added hook for connecting to the canvas store.
8ef909a
@Kuznietsov
fixed import.
6da604b
@Kuznietsov
Added filter types.
6ca376f
@Kuznietsov
Fixed the style of filter view.
7e6cb11
@Kuznietsov
Added sidebar reducer and saved groupByOption there.
9c6a738
@Kuznietsov
Added strict type.
59594de
@Kuznietsov
Added time formatting and translations.
d426cd7
@Kuznietsov
added invalid date translation.
d3671b5
@Kuznietsov
Added components to the view of filter.
fa81a02
@kibanamachine
Merge branch 'main' into canvas_filters_panel
712c1de
@Kuznietsov
Fixed some bugs and done refactoring.
e8d033c
@Kuznietsov
Added unit tests for filter.ts lib.
a99a555
@Kuznietsov
Refactored use_canvas_filters and added unit tests for filter_adapters.
dbad0ca
@Kuznietsov
Fixed format.
4529463
@Kuznietsov
Added test to groupFiltersBy function.
15e781a
@Kuznietsov
Added default (beta) FiltersGroup story.
6acc3e1
@Kuznietsov
Refactored the code.
8bc5220
@Kuznietsov
Storybook and snapshot for FiltersGroup component.
093845a
@Kuznietsov
Added utils for WorkpadFilters storybook.
52bd47f
@Kuznietsov
FilterComponent storybook and snapshot added.
ebb1274
@Kuznietsov
WorkpadFiltersComponent storybook and snapshots added.
73e72e3
@Kuznietsov
WorkpadFilters redux storybook added.
616d25a
@Kuznietsov Kuznietsov added backport:skip This commit does not require backporting Feature:Canvas Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.1.0 impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort release_note:feature Makes this part of the condensed release notes and removed WIP Work in progress labels Nov 18, 2021
@Kuznietsov
Merge branch 'main' into canvas_filters_panel_update_group
ac4cbfd
@Kuznietsov
Fixed eslint error.
6918c42
@Kuznietsov
Removed added by merge mistake file.
968e3be
@Kuznietsov
Merge branch 'canvas_filters_panel_for_element' into canvas_filters_p…
b7b9996 
…anel_update_group

# Conflicts:
#	x-pack/plugins/canvas/public/components/workpad_filters/__stories__/elements.ts
#	x-pack/plugins/canvas/public/components/workpad_filters/__stories__/workpad_filters.stories.tsx
#	x-pack/plugins/canvas/public/components/workpad_filters/hooks/use_canvas_filters.ts
@Kuznietsov
Fixed linting problems.
93e7d8c
@Kuznietsov
Copy link
Contributor Author

@elasticmachine merge upstream

@Kuznietsov
Copy link
Contributor Author

@elasticmachine merge upstream

@Kuznietsov
Copy link
Contributor Author

@elasticmachine merge upstream

@Kuznietsov
Copy link
Contributor Author

@elasticmachine merge upstream

@Kuznietsov
Copy link
Contributor Author

@elasticmachine merge upstream

@Kuznietsov Kuznietsov mentioned this pull request Nov 30, 2021
Merged
18 tasks
@Kuznietsov
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

merge conflict between base and head

@Kuznietsov
Merge branch 'main' into canvas_filters_panel_update_group
b3cc587 
# Conflicts:
#	x-pack/plugins/canvas/canvas_plugin_src/renderers/filters/dropdown_filter/index.tsx
#	x-pack/plugins/canvas/canvas_plugin_src/renderers/filters/time_filter/index.tsx
#	x-pack/plugins/canvas/public/components/sidebar/element_settings/element_settings.component.tsx
#	x-pack/plugins/canvas/public/components/workpad_filters/__stories__/workpad_filters.stories.tsx
#	x-pack/plugins/canvas/public/components/workpad_filters/hooks/use_canvas_filters.ts
#	x-pack/plugins/canvas/public/components/workpad_filters/workpad_filters.tsx
#	x-pack/plugins/canvas/public/functions/filters.ts
#	x-pack/plugins/canvas/public/lib/filter.test.ts
#	x-pack/plugins/canvas/public/lib/filter.ts
@Kuznietsov
Fixes of merge results.
dab8567
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
canvas 1071 1073 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
canvas 1013.2KB 1019.4KB +6.2KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @Kunzetsov

@Kuznietsov Kuznietsov closed this May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crob611 crob611 Awaiting requested review from crob611

@alexwizp alexwizp Awaiting requested review from alexwizp

Assignees

@Kuznietsov Kuznietsov

Labels
backport:skip This commit does not require backporting Feature:Canvas impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort release_note:feature Makes this part of the condensed release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kuznietsov @kibanamachine @kibana-ci