Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Canvas] Add filters information to the UI #50984

Closed
ryankeairns opened this issue Nov 18, 2019 · 12 comments
Closed

[Canvas] Add filters information to the UI #50984

ryankeairns opened this issue Nov 18, 2019 · 12 comments
Assignees
Labels
design enhancement New value added to drive a business result Feature:Canvas impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@ryankeairns
Copy link
Contributor

ryankeairns commented Nov 18, 2019

Describe the feature:
Filters in Canvas are confusing at times and it's not obvious how to filter specific elements. There is a lot that could be done to improve this experience, especially as we begin embedding content from other Kibana applications, but let's start with clarifying which filters are being applied.

Describe a specific use case for the feature:
As a user, I want to click on an element and easily see which filters are being applied.

Additionally, Canvas filters are applied globally by default but often I to apply filters per element(s). Filter groups allow you to achieve this behavior, but this feature is not very discoverable and could be clarified in the UI.

Phase 1 filter improvements

  • Display global filters in the side bar
  • Display element filters in the side bar

In a future phase these will be interactive, but for this first pass let's simply show users which filters are being applied to a workpad/element and provide a link to documentation regarding filter groups.

Note
One way to view filters, currently, is by this expression filters | render as=debug. This initial phase would essentially add that information directly to the UI.

Meta
This work is a subset of #50985

@ryankeairns ryankeairns added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas design loe:medium Medium Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Nov 18, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-canvas (Team:Canvas)

@ryankeairns ryankeairns changed the title [Canvas] Add filter information to the UI [Canvas] Add filters information to the UI Nov 18, 2019
@ryankeairns
Copy link
Contributor Author

@andreadelrio when you have the time, please add a couple of screenshots to his issue. Maybe one for the element view and one for the workpad view. You can also link to the Figma doc/prototype for people to get more information. Thanks

@andreadelrio
Copy link
Contributor

Workpad view - Dropdown option

workpad_filters_groupedByFilterGroups

Figma prototype: https://www.figma.com/proto/Y1eiYAj9in7fRo7N60harh/canvas_filters_tab_v2?node-id=40%3A305&scaling=min-zoom

Workpad view - Button group option

workpad_filters_buttonGroup_type

Figma prototype: https://www.figma.com/proto/Y1eiYAj9in7fRo7N60harh/canvas_filters_tab_v2?node-id=143%3A3004&scaling=min-zoom

Element view - Dropdown option (for a reference of the "button group" option see above)

element_filters_filterGroups

@ryankeairns
Copy link
Contributor Author

@andreadelrio these looks great. Two small pieces of feedback:

  • I prefer the 'select' input as the button group feels a bit too tight for that space
  • To align with the element name, please change the 'Exactly' accordion to 'Dropdown'. That is the name of the element the user sees when adding this type of filter to their workpad. For other one, 'Time' is correct (see below).

Screenshot 2019-12-17 07 43 45

Thanks!

@andreadelrio
Copy link
Contributor

Updated the Figma links replacing 'Exactly' with 'Dropdown'.

@ryankeairns
Copy link
Contributor Author

@timductive @shaunmcgough @clintandrewhall @crob611

The phase 1 design work for displaying filter information is ready from the design side.

Thanks @andreadelrio !

@timductive timductive added the enhancement New value added to drive a business result label Feb 11, 2020
@maggieghamry maggieghamry self-assigned this Mar 31, 2020
@maggieghamry
Copy link
Contributor

maggieghamry commented Apr 1, 2020

@ryankeairns can you please provide the latest UI design (if there are differences from https://www.figma.com/proto/Y1eiYAj9in7fRo7N60harh/canvas_filters_tab_v2?node-id=141%3A1080&scaling=min-zoom)?

I do have some questions about the aforementioned mockup, provided that is the latest:

  • In your comment Filter groups allow you to achieve this behavior, but this feature is not very discoverable and could be clarified in the UI- can you please let me know how to discover the Filter groups you mentioned here?
  • Are there any mockups for the "selected element" filter tab display(s)?
  • Is there any documented logic for the different menus?
  • What should Learn about filters in Canvas link to?
  • On each of the options; Filter group, Filter type, and Column, the data displays are very similar, and I could use some help understanding how the right hand menu selections should render differently in the UI, or where some of the values come from (for example: Project , Value, Type that are populated in the filter menus. Can you help me decipher these?
    columnFilterMockupQuestions
    filterTypeMockupQuestions
    filterGroupMockupQuestions

cc @cqliu1 @crob611 @timductive

@ryankeairns
Copy link
Contributor Author

@maggieghamry the last image in Andrea's post shows when an element is selected (it adds a third tab in the sidebar for Filters):

The Figma mockup is here: https://www.figma.com/file/Y1eiYAj9in7fRo7N60harh/canvas_filters_tab_v2?node-id=143%3A3652

Here is a screenshot snippet from that link:
Screenshot 2020-04-01 16 12 53

@maggieghamry
Copy link
Contributor

Thank you @ryankeairns !

@ryankeairns
Copy link
Contributor Author

ryankeairns commented Apr 2, 2020

@maggieghamry I've updated the mockups to be more accurate (they now show actual filter elements :) ):

Updated mockups

The 'Group by' dropdown is hooked up and you can collapse/expand the bottom accordion in each view (for simplicity's sake, the top accordion does not expand/collapse in the prototype). If you collapse the bottom accordion, you'll also be able to see the 'View filter docs' link which also now takes you to the actual docs site.

https://www.figma.com/proto/Y1eiYAj9in7fRo7N60harh/canvas_filters_tab_v2?node-id=40%3A305&viewport=-2421%2C2694%2C0.4273872673511505&scaling=min-zoom

Screenshot from Figma link

Screenshot 2020-04-02 12 17 09

@maggieghamry
Copy link
Contributor

Awesome, thanks so much for this @ryankeairns!

@ThomThomson
Copy link
Contributor

Closing this for the time being as we are currently not prioritizing work to make the Canvas filtering experience more usable.

@ThomThomson ThomThomson closed this as not planned Won't fix, can't repro, duplicate, stale Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design enhancement New value added to drive a business result Feature:Canvas impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

No branches or pull requests

7 participants