Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[uiFramework/docSite] reuse kibana babel config #11688

Merged

Conversation

spalger
Copy link
Contributor

@spalger spalger commented May 9, 2017

I tried running the npm run uiFramework:start task after merging #11535 and realized that the webpack config in that code wasn't using Kibana's babel config, so it was out of date. This PR pulls in Kibana's babel config so that the tasks run again.

@spalger spalger added Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. review v5.5.0 v6.0.0 labels May 9, 2017
@spalger spalger requested a review from cjcenizal May 9, 2017 22:54
@spalger
Copy link
Contributor Author

spalger commented May 9, 2017

jenkins, please test this

Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thank you so much for doing this.

@spalger spalger merged commit ff87098 into elastic:master May 10, 2017
spalger added a commit that referenced this pull request May 10, 2017
@spalger
Copy link
Contributor Author

spalger commented May 10, 2017

@cjcenizal 🎩

5.x/5.5: 519a47c

@spalger spalger deleted the fix/ui-framework-webpack-reuse-kibana-config branch May 10, 2017 01:51
snide pushed a commit to snide/kibana that referenced this pull request May 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. v5.5.0 v6.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants