[babel] tweak babel options for performance and debugging #11535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
added
Team:Operations
spalger
force-pushed
the
babel/tweak-options
branch
4 times, most recently
from
1a7fe50 to
f6ea8ad
Compare
|
jenkins, test this |
|
Nice. Before: After: |
jbudz
reviewed
May 3, 2017
package.json
Outdated
| @@ -98,14 +98,16 @@ | |||
| "babel-jest": "19.0.0", | |||
| "babel-loader": "6.2.10", | |||
| "babel-plugin-add-module-exports": "0.2.1", | |||
| "babel-plugin-syntax-dynamic-import": "^6.18.0", | |||
| "babel-plugin-transform-async-generator-functions": "^6.24.1", | |||
There was a problem hiding this comment.
should these be locked to the patch version?
There was a problem hiding this comment.
Yeah, sorry, I've been using yarn which doesn't do this because of yarn.lock
spalger
force-pushed
the
babel/tweak-options
branch
from
acfb7e0 to
14c91a7
Compare
jbudz
approved these changes
May 5, 2017
kimjoar
reviewed
May 8, 2017
package.json
Outdated
| "babel-plugin-transform-async-generator-functions": "6.24.1", | ||
| "babel-plugin-transform-class-properties": "6.24.1", | ||
| "babel-plugin-transform-object-rest-spread": "6.23.0", | ||
| "babel-plugin-transform-unicode-property-regex": "2.0.1", |
There was a problem hiding this comment.
Is babel-plugin-transform-unicode-property-regex and babel-plugin-syntax-dynamic-import used?
There was a problem hiding this comment.
I was originally basing the list of plugins off of babel#master, rather than the released versions
|
EDIT: Bah, I was checking in |
kimjoar
approved these changes
May 8, 2017
spalger
added a commit
to spalger/kibana
that referenced
this pull request
May 8, 2017
) * [babel] tweak babel options for performance and debugging * [babel] remove babel-plugin-transform-export-extensions * [npm] lock new deps to the patch version * [npm] remove unused deps (cherry picked from commit 36ecf13)
spalger
added a commit
to spalger/kibana
that referenced
this pull request
May 8, 2017
) * [babel] tweak babel options for performance and debugging * [babel] remove babel-plugin-transform-export-extensions * [npm] lock new deps to the patch version * [npm] remove unused deps (cherry picked from commit 36ecf13)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9472
babel-preset-env'suseBuiltInsoption which trims the core-js polyfills to just those necessary for the current node versionbabel-plugin-transform-class-properties