Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX for #11002. Should not throw error when fitting on empty data. #11620

Merged
merged 1 commit into from
May 10, 2017
Merged

FIX for #11002. Should not throw error when fitting on empty data. #11620

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/ui/public/vis_maps/__tests__/geohash_layer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,6 +483,20 @@ describe('kibana_map tests', function () {
});


it('should not throw when fitting on empty-data layer', function () {

const geohashLayer = new GeohashLayer({
type: 'FeatureCollection',
features: []
}, { 'mapType': 'Scaled Circle Markers' }, kibanaMap.getZoomLevel(), kibanaMap);
kibanaMap.addLayer(geohashLayer);

expect(() => {
kibanaMap.fitToData();
}).to.not.throwException();
});


});

});
Expand Down
2 changes: 1 addition & 1 deletion src/ui/public/vis_maps/kibana_map.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,7 +474,7 @@ export class KibanaMap extends EventEmitter {
}
});

if (bounds) {
if (bounds && bounds.isValid()) {
this._leafletMap.fitBounds(bounds);
}
}
Expand Down