Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX for #11002. Should not throw error when fitting on empty data. #11620

Merged
merged 1 commit into from
May 10, 2017
Merged

FIX for #11002. Should not throw error when fitting on empty data. #11620

merged 1 commit into from
May 10, 2017

Conversation

thomasneirynck
Copy link
Contributor

When users click on the fit button before data is added to the map, it should not throw an error.

Closes #11002.

@thomasneirynck thomasneirynck added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) review v5.4.1 labels May 5, 2017
@thomasneirynck thomasneirynck requested a review from ppisljar May 5, 2017 15:04
ppisljar
ppisljar approved these changes May 6, 2017
View reviewed changes
Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasneirynck thomasneirynck merged commit 21f2b87 into elastic:master May 10, 2017
thomasneirynck added a commit to thomasneirynck/kibana that referenced this pull request May 10, 2017
@thomasneirynck
should not throw error when fitting on empty data (elastic#11620)
50a3898
thomasneirynck added a commit to thomasneirynck/kibana that referenced this pull request May 10, 2017
@thomasneirynck
should not throw error when fitting on empty data (elastic#11620)
b4ca471
@thomasneirynck
Copy link
Contributor Author

backports:
5.x backport: #11712
5.4 backport: #11710

thomasneirynck added a commit that referenced this pull request May 10, 2017
@thomasneirynck
should not throw error when fitting on empty data (#11620) (#11712)
0c3bb05
thomasneirynck added a commit that referenced this pull request May 11, 2017
@thomasneirynck
should not throw error when fitting on empty data (#11620) (#11710)
9fef931
snide pushed a commit to snide/kibana that referenced this pull request May 30, 2017
@thomasneirynck @snide
should not throw error when fitting on empty data (elastic#11620)
a0ec2bb
@snyk-bot snyk-bot mentioned this pull request Dec 29, 2020
Open
@larrycameron80 larrycameron80 mentioned this pull request Mar 15, 2021
Open
@larrycameron80 larrycameron80 mentioned this pull request Nov 4, 2022
Open
@82ndAirborneDiv 82ndAirborneDiv mentioned this pull request Nov 5, 2022
Open
@xhad xhad mentioned this pull request Nov 5, 2022
Open
@xhad xhad mentioned this pull request Dec 25, 2022
Open
@larrycameron80 larrycameron80 mentioned this pull request Dec 25, 2022
Open
@82ndAirborneDiv 82ndAirborneDiv mentioned this pull request Dec 26, 2022
Open
@larrycameron80 larrycameron80 mentioned this pull request Jan 10, 2023
Open
@82ndAirborneDiv 82ndAirborneDiv mentioned this pull request Nov 28, 2023
Open
@xhad xhad mentioned this pull request May 13, 2024
Open
@82ndAirborneDiv 82ndAirborneDiv mentioned this pull request May 14, 2024
Open
@larrycameron80 larrycameron80 mentioned this pull request May 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppisljar ppisljar ppisljar approved these changes

Assignees
No one assigned
Labels
Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:fix review v5.4.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomasneirynck @ppisljar