Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecation allowance for rmdir recursive #116019

Merged
merged 3 commits into from
Nov 1, 2021
Merged

Remove deprecation allowance for rmdir recursive #116019

merged 3 commits into from
Nov 1, 2021

Conversation

jbudz
Copy link
Member

@jbudz jbudz commented Oct 21, 2021 •
edited
Loading

This bumps synthetics to 1.0.0 beta 16, letting us remove the ignored
warning for fs.rmdir(path, { recursive: true})

@jbudz
Remove deprecation allowance for rmdir recursive
f9937d3 
This bumps synthetics to 1.0.0 beta 16, letting us remove the ignored
warning for fs.rmdir(path, { recursive: true})
@jbudz jbudz added Team:Operations Team label for Operations Team v8.0.0 Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability release_note:skip Skip the PR/issue when compiling release notes labels Oct 21, 2021
@jbudz
Copy link
Member Author

jbudz commented Oct 25, 2021

@elasticmachine merge upstream

@jbudz
Copy link
Member Author

jbudz commented Oct 25, 2021

I'm okay with waiting on this until it's more convenient, just wanted to make sure it isn't forgotten.

@jbudz jbudz marked this pull request as ready for review October 25, 2021 22:11
@jbudz jbudz requested a review from a team as a code owner October 25, 2021 22:11
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@jbudz jbudz requested a review from a team October 25, 2021 22:11
vigneshshanmugam
vigneshshanmugam approved these changes Oct 25, 2021
View reviewed changes
Copy link
Member

@vigneshshanmugam vigneshshanmugam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from synthetics side.

@jbudz
Copy link
Member Author

jbudz commented Nov 1, 2021

@elasticmachine merge upstream

@jbudz jbudz added the auto-backport Deprecated - use backport:version if exact versions are needed label Nov 1, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jbudz jbudz removed v8.0.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Nov 1, 2021
@jbudz jbudz merged commit 07576c8 into elastic:main Nov 1, 2021
@jbudz jbudz added the v8.1.0 label Nov 1, 2021
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 116019 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 2, 2021
@jbudz jbudz added the backport:skip This commit does not require backporting label Nov 2, 2021
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vigneshshanmugam vigneshshanmugam vigneshshanmugam approved these changes

@spalger spalger spalger approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jbudz @elasticmachine @kibanamachine @spalger @vigneshshanmugam