Skip to content

Commit

Permalink
Remove deprecation allowance for rmdir recursive (#116019)
Browse files Browse the repository at this point in the history
This bumps synthetics to 1.0.0 beta 16, letting us remove the ignored
warning for fs.rmdir(path, { recursive: true})

Co-authored-by: Kibana Machine <[email protected]>
  • Loading branch information
jbudz and kibanamachine authored Nov 1, 2021
1 parent f2402ce commit 07576c8
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 11 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -435,7 +435,7 @@
"@elastic/eslint-plugin-eui": "0.0.2",
"@elastic/github-checks-reporter": "0.0.20b3",
"@elastic/makelogs": "^6.0.0",
"@elastic/synthetics": "^1.0.0-beta.12",
"@elastic/synthetics": "^1.0.0-beta.16",
"@emotion/babel-preset-css-prop": "^11.2.0",
"@emotion/jest": "^11.3.0",
"@istanbuljs/schema": "^0.1.2",
Expand Down
6 changes: 0 additions & 6 deletions src/setup_node_env/exit_on_warning.js
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,6 @@ var IGNORE_WARNINGS = [
name: 'DeprecationWarning',
code: 'DEP0148',
},
// In future versions of Node.js, fs.rmdir(path, { recursive: true }) will be removed.
// Remove after https://github.com/elastic/synthetics/pull/390
{
name: 'DeprecationWarning',
code: 'DEP0147',
},
{
// TODO: @elastic/es-clients - The new client will attempt a Product check and it will `process.emitWarning`
// that the security features are blocking such check.
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2553,10 +2553,10 @@
history "^4.9.0"
qs "^6.7.0"

"@elastic/synthetics@^1.0.0-beta.12":
version "1.0.0-beta.13"
resolved "https://registry.yarnpkg.com/@elastic/synthetics/-/synthetics-1.0.0-beta.13.tgz#84b3353b6bfff5623613016d8ed3d47e48ed17ea"
integrity sha512-CXpdfq/E6sVwDU6aGkH9mvcBPimQvR3/2QfBS5U4J58145m7YRPhJzaPJqXVApKomYcE/yzN49zOTIDsMcdOkg==
"@elastic/synthetics@^1.0.0-beta.16":
version "1.0.0-beta.16"
resolved "https://registry.yarnpkg.com/@elastic/synthetics/-/synthetics-1.0.0-beta.16.tgz#3d670cf29019e2be356592f2a7871594a3b0ce68"
integrity sha512-Ke8MO1lbddZjncPuY2IzZ1qKwePVD1hn9JtSUMv+7zJmczasrqcDKS2QCeFdt12kvFNe/IE60PStwfc9AD7j9w==
dependencies:
commander "^7.0.0"
deepmerge "^4.2.2"
Expand Down

0 comments on commit 07576c8

Please sign in to comment.