Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Stack management apps] Deprecate "enabled" Kibana setting (#114768) #115541

Merged
merged 11 commits into from
Oct 19, 2021

Conversation

sebelga
Copy link
Contributor

@sebelga sebelga commented Oct 19, 2021

Backports the following commits to 7.x:

…14768)

# Conflicts:
#	docs/dev-tools/console/console.asciidoc
#	docs/setup/settings.asciidoc
#	x-pack/plugins/upgrade_assistant/__jest__/client_integration/helpers/index.ts
#	x-pack/plugins/upgrade_assistant/__jest__/client_integration/helpers/setup_environment.tsx
#	x-pack/plugins/upgrade_assistant/__jest__/client_integration/overview/overview.test.tsx
#	x-pack/plugins/upgrade_assistant/common/config.ts
#	x-pack/plugins/upgrade_assistant/common/constants.ts
#	x-pack/plugins/upgrade_assistant/public/application/components/es_deprecations/deprecation_types/reindex/flyout/warning_step.test.tsx
#	x-pack/plugins/upgrade_assistant/public/plugin.ts
#	x-pack/plugins/upgrade_assistant/public/types.ts
@sebelga sebelga enabled auto-merge (squash) October 19, 2021 11:18
@sebelga sebelga disabled auto-merge October 19, 2021 11:49
@sebelga sebelga requested a review from cjcenizal October 19, 2021 11:56
Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, deprecations and code LGTM.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
console 9 13 +4
rollup 20 21 +1
snapshotRestore 22 23 +1
total +6

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
home 81.4KB 81.4KB +12.0B
inspector 14.8KB 14.8KB +14.0B
upgradeAssistant 136.1KB 136.1KB -1.0B
total +25.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
console 16.6KB 16.6KB +89.0B
indexManagement 36.4KB 36.4KB +49.0B
licenseManagement 11.1KB 11.2KB +57.0B
rollup 11.7KB 11.8KB +82.0B
snapshotRestore 28.7KB 28.7KB +31.0B
upgradeAssistant 18.3KB 18.3KB -6.0B
total +302.0B
Unknown metric groups

API count

id before after diff
console 9 13 +4
rollup 20 21 +1
snapshotRestore 23 24 +1
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants