[Upgrade Assistant] Forwardport from 7.x #114966

sabarasaba · 2021-10-14T09:27:48Z

This PR forwardports a bunch of PRs that were merged into 7.16 into main.

The approach I took for this was to:

Find the last commit for the upgrade_assistant folder that was in both master and 7.x. Which turn out to be 4df76f0
Then I wrote down all the commits that were in 7.x but not in master, taking into account that there were some PR's in master that were also backported to 7.x. You can see the list of commits down below.
Wrote tiny bash script that cherry-picks every one of the commits with the --strategy-option theirs flag, because in case of any conflicts we always want to pick whatever was added in 7.x
Once all of that was done, somehow there was one translation that was not being used and a few linter issues that I addressed with 29d1847 and 47781c1
Because we prefered 7.x changes when in conflict, we need to go through the files that were outside the UA folders and manually address those. Luckily for us it was only in just a few files 61688d5 and 66ab7ba
Up next we need to skip a11y and functional tests since they were written to work with deprecations from 7.x which no longer exist in 8 9efd7a1
Lastly, I had to fix a few type errors 5f103d6 and 32946a8

List of commits

Fix link to Cloud deployment URL in upgrade step.
ec3c28f#diff-9b2043598ef96a80bc51f79970c917270a1eff4e3e6625380325fb4da8925d5a

[Upgrade Assistant] Refactor CITs
af6b908#diff-9b2043598ef96a80bc51f79970c917270a1eff4e3e6625380325fb4da8925d5a

Rename UA steps to fix_issues_step and fix_logs_step.
03e3baa#diff-9b2043598ef96a80bc51f79970c917270a1eff4e3e6625380325fb4da8925d5a

[Upgrade Assistant] Cleanup scss
4a14a94#diff-9b2043598ef96a80bc51f79970c917270a1eff4e3e6625380325fb4da8925d5a

[Upgrade Assistant] Update readme
77fe9ec#diff-9b2043598ef96a80bc51f79970c917270a1eff4e3e6625380325fb4da8925d5a

Add "Back up data" step to UA
7947341#diff-9b2043598ef96a80bc51f79970c917270a1eff4e3e6625380325fb4da8925d5a

Change copy references of 'deprecation issues' to 'deprecation warnin…
7c79a81#diff-9b2043598ef96a80bc51f79970c917270a1eff4e3e6625380325fb4da8925d5a

[Upgrade Assistant] Address design feedback for ES deprecations page
ec09a41#diff-9b2043598ef96a80bc51f79970c917270a1eff4e3e6625380325fb4da8925d5a

[Upgrade Assistant] Add checkpoint feature to Overview page
047fe77#diff-9b2043598ef96a80bc51f79970c917270a1eff4e3e6625380325fb4da8925d5a

Add on-Cloud state to Upgrade Assistant 'Back up data' step
986ac3b#diff-9b2043598ef96a80bc51f79970c917270a1eff4e3e6625380325fb4da8925d5a

[Upgrade Assistant] Refactor external links to use locators
efdc7d5#diff-9b2043598ef96a80bc51f79970c917270a1eff4e3e6625380325fb4da8925d5a

[Upgrade Assistant] Use AppContext for services instead of KibanaContext
f558a79#diff-9b2043598ef96a80bc51f79970c917270a1eff4e3e6625380325fb4da8925d5a

[Upgrade Assistant] Enable functional and a11y tests
0f451a5#diff-9b2043598ef96a80bc51f79970c917270a1eff4e3e6625380325fb4da8925d5a

[Upgrade Assistant] Remove version from UA nav title
f15250e#diff-9b2043598ef96a80bc51f79970c917270a1eff4e3e6625380325fb4da8925d5a

[Upgrade Assistant] New Kibana deprecations page
ee32afb#diff-9b2043598ef96a80bc51f79970c917270a1eff4e3e6625380325fb4da8925d5a

Use injected lib.handleEsError instead of importing it in Upgrade Assistant
1a74022#diff-9b2043598ef96a80bc51f79970c917270a1eff4e3e6625380325fb4da8925d5a

Add tests for UA back up data step on Cloud
de66029#diff-9b2043598ef96a80bc51f79970c917270a1eff4e3e6625380325fb4da8925d5a

Update UA to consume snapshotsUrl as provided by the Cloud plugin
25de643#diff-9b2043598ef96a80bc51f79970c917270a1eff4e3e6625380325fb4da8925d5a

Skip flaky UA Backup step polling test
d4dbce0#diff-9b2043598ef96a80bc51f79970c917270a1eff4e3e6625380325fb4da8925d5a

[Upgrade Assistant] Refactor kibana deprecation service mocks
48b25a6#diff-9b2043598ef96a80bc51f79970c917270a1eff4e3e6625380325fb4da8925d5a

[Upgrade Assistant] Remove unnecessary EuiScreenReaderOnly from stats panel
7779b38#diff-9b2043598ef96a80bc51f79970c917270a1eff4e3e6625380325fb4da8925d5a

Use consistent 'issues' and 'critical' vs. 'warning' terminology in UA
7515700#diff-9b2043598ef96a80bc51f79970c917270a1eff4e3e6625380325fb4da8925d5a

Refactor UA Overview to support step-completion
af9d3f5#diff-9b2043598ef96a80bc51f79970c917270a1eff4e3e6625380325fb4da8925d5a

[Upgrade Assistant] External links with checkpoint time-range applied
67871d5#diff-9b2043598ef96a80bc51f79970c917270a1eff4e3e6625380325fb4da8925d5a

[Upgrade Assistant] Tests for updating step state accordingly if API
5250db8#diff-9b2043598ef96a80bc51f79970c917270a1eff4e3e6625380325fb4da8925d5a

[Upgrade Assistant] Add a11y tests for es deprecation flyouts
426bda8#diff-9b2043598ef96a80bc51f79970c917270a1eff4e3e6625380325fb4da8925d5a

[Upgrade Assistant] Set fix_logs step as incomplete if log collection is not enabled
2528898#diff-9b2043598ef96a80bc51f79970c917270a1eff4e3e6625380325fb4da8925d5a

[Upgrade Assistant] Update copy to use "issues" instead of "warnings"
5393b37#diff-9b2043598ef96a80bc51f79970c917270a1eff4e3e6625380325fb4da8925d5a

Create common deprecation issues panel component in UA
e23c26f#diff-9b2043598ef96a80bc51f79970c917270a1eff4e3e6625380325fb4da8925d5a

[Upgrade Assistant] Fix Kibana deprecations warning message
8dd4122#diff-9b2043598ef96a80bc51f79970c917270a1eff4e3e6625380325fb4da8925d5a

[Upgrade Assistant] Add support for API keys when reindexing
c615246#diff-9b2043598ef96a80bc51f79970c917270a1eff4e3e6625380325fb4da8925d5a

[Upgrade Assistant] Update readme
ac94ed9#diff-9b2043598ef96a80bc51f79970c917270a1eff4e3e6625380325fb4da8925d5a

[Upgrade Assistant] Make infra plugin optional
d7ce247#diff-9b2043598ef96a80bc51f79970c917270a1eff4e3e6625380325fb4da8925d5a

[Upgrade Assistant] Improve flyout information architecture
70f2677#diff-9b2043598ef96a80bc51f79970c917270a1eff4e3e6625380325fb4da8925d5a

[Upgrade Assistant] Update readme
1ad9a72#diff-9b2043598ef96a80bc51f79970c917270a1eff4e3e6625380325fb4da8925d5a

[Upgrade Assistant] Add integration tests for Overview page
3c35cbf#diff-9b2043598ef96a80bc51f79970c917270a1eff4e3e6625380325fb4da8925d5a

[Upgrade Assistant] Add note about compatibility headers
c9292e5#diff-9b2043598ef96a80bc51f79970c917270a1eff4e3e6625380325fb4da8925d5a

Improve error states for Upgrade Assistant deprecation issues
71bfe79#diff-9b2043598ef96a80bc51f79970c917270a1eff4e3e6625380325fb4da8925d5a

Change count poll time to 15s
52723a5#diff-9b2043598ef96a80bc51f79970c917270a1eff4e3e6625380325fb4da8925d5a

[Upgrade Assistant] Add permissions check to logs step
dacf0c2#diff-9b2043598ef96a80bc51f79970c917270a1eff4e3e6625380325fb4da8925d5a

[Upgrade Assistant] Refactor telemetry
991d24b#diff-9b2043598ef96a80bc51f79970c917270a1eff4e3e6625380325fb4da8925d5a

[Upgrade Assistant] Check for ML upgrade mode before enabling flyout actions
b409e2e#diff-9b2043598ef96a80bc51f79970c917270a1eff4e3e6625380325fb4da8925d5a

Add missing error handlers for deprecation logging route
231ab17#diff-9b2043598ef96a80bc51f79970c917270a1eff4e3e6625380325fb4da8925d5a

[Upgrade Assistant] Batch reindex docs
a85f7a5#diff-9b2043598ef96a80bc51f79970c917270a1eff4e3e6625380325fb4da8925d5a

[Upgrade Assistant] Improve error messages for GET /api/upgrade_assistant/reindex/
ade05d9#diff-9b2043598ef96a80bc51f79970c917270a1eff4e3e6625380325fb4da8925d5a

Add support for single manual steps to Upgrade Assistant
16271f5#diff-9b2043598ef96a80bc51f79970c917270a1eff4e3e6625380325fb4da8925d5a

Revert "[Upgrade Assistant] Refactor telemetry
c385d49#diff-9b2043598ef96a80bc51f79970c917270a1eff4e3e6625380325fb4da8925d5a

[Upgrade Assistant] Use skipFetchFields when creating the indexPatter…
…n in order to avoid errors if index doesn't exist
6674293#diff-9b2043598ef96a80bc51f79970c917270a1eff4e3e6625380325fb4da8925d5a

[Upgrade Assistant] Hide system indices from es deprecations list
6b3eb50#diff-9b2043598ef96a80bc51f79970c917270a1eff4e3e6625380325fb4da8925d5a

Refactor reindex routes into separate single and batch reindex files.…
… Apply version precheck to batch routes.
3042c11#diff-9b2043598ef96a80bc51f79970c917270a1eff4e3e6625380325fb4da8925d5a

[Upgrade Assistant] Remove ML/Watcher logic
794366f#diff-9b2043598ef96a80bc51f79970c917270a1eff4e3e6625380325fb4da8925d5a

Add show upgrade flag to url
0d614dc#diff-9b2043598ef96a80bc51f79970c917270a1eff4e3e6625380325fb4da8925d5a

[Upgrade Assistant] Delete deprecation log cache
f69facc#diff-9b2043598ef96a80bc51f79970c917270a1eff4e3e6625380325fb4da8925d5a

[Upgrade Assistant] Add upgrade system indices section
2763514#diff-9b2043598ef96a80bc51f79970c917270a1eff4e3e6625380325fb4da8925d5a

[Upgrade Assistant] Reindexing progress
7bdfcf1#diff-9b2043598ef96a80bc51f79970c917270a1eff4e3e6625380325fb4da8925d5a

[Upgrade Assistant] Remove Fix manually heading when there are no man…
…ual steps
1b62981#diff-9b2043598ef96a80bc51f79970c917270a1eff4e3e6625380325fb4da8925d5a

Add rolling upgrade interstitials to UA
4732d4a#diff-9b2043598ef96a80bc51f79970c917270a1eff4e3e6625380325fb4da8925d5a

[Upgrade Assistant] Added "accept changes" header to the warnings lis…
…t in the reindex flyout
0e3853a#diff-9b2043598ef96a80bc51f79970c917270a1eff4e3e6625380325fb4da8925d5a

Refactor kibana deprecation tests
21d7bc8#diff-9b2043598ef96a80bc51f79970c917270a1eff4e3e6625380325fb4da8925d5a

[Upgrade Assistant] Removed "closed index" warning from reindex flyout
a2b42d2#diff-9b2043598ef96a80bc51f79970c917270a1eff4e3e6625380325fb4da8925d5a

Add LevelIconTips to be more explicit about the difference between cr……itical and warning issues.
b25dd4e#diff-9b2043598ef96a80bc51f79970c917270a1eff4e3e6625380325fb4da8925d5a

Extract common DeprecationFlyoutLearnMoreLink component and change wo……rding to 'Learn more'.
ee57648#diff-9b2043598ef96a80bc51f79970c917270a1eff4e3e6625380325fb4da8925d5a

[Upgrade Assistant] Reindexing cancellation
8f28bf0#diff-9b2043598ef96a80bc51f79970c917270a1eff4e3e6625380325fb4da8925d5a

Fix test errors
8df988e#diff-9b2043598ef96a80bc51f79970c917270a1eff4e3e6625380325fb4da8925d5a

[Upgrade Assistant] Overview page UI clean up
daaf60d#diff-9b2043598ef96a80bc51f79970c917270a1eff4e3e6625380325fb4da8925d5a

Revert "Revert "[Upgrade Assistant] Refactor telemetry
19cad6d#diff-9b2043598ef96a80bc51f79970c917270a1eff4e3e6625380325fb4da8925d5a

[Upgrade Assistant] Rename upgrade_status to migration_status
9750b24#diff-9b2043598ef96a80bc51f79970c917270a1eff4e3e6625380325fb4da8925d5a

[Upgrade Assistant] Swapped reindexing flyouts order
1151c85#diff-9b2043598ef96a80bc51f79970c917270a1eff4e3e6625380325fb4da8925d5a

[Upgrade Assistant] Hide features that don't need to be migrated from flyout
128afbb#diff-9b2043598ef96a80bc51f79970c917270a1eff4e3e6625380325fb4da8925d5a

Refine Upgrade Assistant copy.
4c86ad2#diff-9b2043598ef96a80bc51f79970c917270a1eff4e3e6625380325fb4da8925d5a

sabarasaba · 2021-10-14T13:33:59Z

@elasticmachine merge upstream

sabarasaba · 2021-10-15T13:44:54Z

@elasticmachine merge upstream

kibanamachine · 2021-10-15T13:44:57Z

merge conflict between base and head

elasticmachine · 2021-10-19T15:05:57Z

Pinging @elastic/kibana-stack-management (Team:Stack Management)

kibanamachine · 2021-10-20T13:02:23Z

💛 Build succeeded, but was flaky

continuous-integration/kibana-ci/pull-request
Commit: f8404ba428f75d437233f5655500e56159bbedf9
Storybooks Preview
Documentation Changes
Flaky suites:
- xpack-kibana-ciGroup2

Test Failures

Kibana Pipeline / general / X-Pack Saved Object Tagging Functional Tests.x-pack/test/saved_object_tagging/functional/tests/dashboard_integration·ts.saved objects tagging - functional tests dashboard integration editing allows to select tags for an existing dashboard

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 2 times on tracked branches: https://github.com/elastic/kibana/issues/106547

[00:00:00]     │
[00:00:00]       └-: saved objects tagging - functional tests
[00:00:00]         └-> "before all" hook in "saved objects tagging - functional tests"
[00:00:00]         └-> "before all" hook in "saved objects tagging - functional tests"
[00:00:00]           │ debg creating role kibana_rbac_default_space_read_user
[00:00:00]           │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [kibana_rbac_default_space_read_user]
[00:00:00]           │ debg creating role kibana_rbac_default_space_write_user
[00:00:00]           │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [kibana_rbac_default_space_write_user]
[00:00:00]           │ debg creating role kibana_rbac_default_space_so_management_write_user
[00:00:00]           │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [kibana_rbac_default_space_so_management_write_user]
[00:00:00]           │ debg creating role kibana_rbac_default_space_so_management_read_user
[00:00:00]           │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [kibana_rbac_default_space_so_management_read_user]
[00:00:00]           │ debg creating role kibana_rbac_default_space_so_tagging_read_user
[00:00:00]           │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [kibana_rbac_default_space_so_tagging_read_user]
[00:00:00]           │ debg creating role kibana_rbac_default_space_so_tagging_write_user
[00:00:00]           │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [kibana_rbac_default_space_so_tagging_write_user]
[00:00:00]           │ debg creating role kibana_rbac_default_space_dashboard_read_user
[00:00:00]           │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [kibana_rbac_default_space_dashboard_read_user]
[00:00:00]           │ debg creating role kibana_rbac_default_space_dashboard_write_user
[00:00:00]           │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [kibana_rbac_default_space_dashboard_write_user]
[00:00:00]           │ debg creating role kibana_rbac_default_space_visualize_read_user
[00:00:00]           │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [kibana_rbac_default_space_visualize_read_user]
[00:00:00]           │ debg creating role kibana_rbac_default_space_visualize_write_user
[00:00:00]           │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [kibana_rbac_default_space_visualize_write_user]
[00:00:00]           │ debg creating role kibana_rbac_default_space_advanced_settings_read_user
[00:00:00]           │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [kibana_rbac_default_space_advanced_settings_read_user]
[00:00:00]           │ debg creating role kibana_rbac_default_space_maps_read_user
[00:00:00]           │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [kibana_rbac_default_space_maps_read_user]
[00:00:00]           │ debg creating user not_a_kibana_user
[00:00:00]           │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [not_a_kibana_user]
[00:00:00]           │ debg created user not_a_kibana_user
[00:00:00]           │ debg creating user a_kibana_rbac_default_space_read_user
[00:00:00]           │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [a_kibana_rbac_default_space_read_user]
[00:00:00]           │ debg created user a_kibana_rbac_default_space_read_user
[00:00:00]           │ debg creating user a_kibana_rbac_default_space_write_user
[00:00:00]           │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [a_kibana_rbac_default_space_write_user]
[00:00:00]           │ debg created user a_kibana_rbac_default_space_write_user
[00:00:00]           │ debg creating user a_kibana_rbac_default_space_so_management_write_user
[00:00:00]           │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [a_kibana_rbac_default_space_so_management_write_user]
[00:00:00]           │ debg created user a_kibana_rbac_default_space_so_management_write_user
[00:00:00]           │ debg creating user a_kibana_rbac_default_space_so_tagging_read_user
[00:00:01]           │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [a_kibana_rbac_default_space_so_tagging_read_user]
[00:00:01]           │ debg created user a_kibana_rbac_default_space_so_tagging_read_user
[00:00:01]           │ debg creating user a_kibana_rbac_default_space_so_tagging_read_so_management_read_user
[00:00:01]           │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [a_kibana_rbac_default_space_so_tagging_read_so_management_read_user]
[00:00:01]           │ debg created user a_kibana_rbac_default_space_so_tagging_read_so_management_read_user
[00:00:01]           │ debg creating user a_kibana_rbac_default_space_so_tagging_write_user
[00:00:01]           │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [a_kibana_rbac_default_space_so_tagging_write_user]
[00:00:01]           │ debg created user a_kibana_rbac_default_space_so_tagging_write_user
[00:00:01]           │ debg creating user a_kibana_rbac_default_space_dashboard_read_user
[00:00:01]           │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [a_kibana_rbac_default_space_dashboard_read_user]
[00:00:01]           │ debg created user a_kibana_rbac_default_space_dashboard_read_user
[00:00:01]           │ debg creating user a_kibana_rbac_default_space_visualize_read_user
[00:00:01]           │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [a_kibana_rbac_default_space_visualize_read_user]
[00:00:01]           │ debg created user a_kibana_rbac_default_space_visualize_read_user
[00:00:01]           │ debg creating user a_kibana_rbac_default_space_dashboard_write_user
[00:00:01]           │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [a_kibana_rbac_default_space_dashboard_write_user]
[00:00:01]           │ debg created user a_kibana_rbac_default_space_dashboard_write_user
[00:00:01]           │ debg creating user a_kibana_rbac_default_space_visualize_write_user
[00:00:01]           │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [a_kibana_rbac_default_space_visualize_write_user]
[00:00:01]           │ debg created user a_kibana_rbac_default_space_visualize_write_user
[00:00:01]           │ debg creating user a_kibana_rbac_default_space_advanced_settings_read_user
[00:00:01]           │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [a_kibana_rbac_default_space_advanced_settings_read_user]
[00:00:01]           │ debg created user a_kibana_rbac_default_space_advanced_settings_read_user
[00:00:01]           │ debg creating user a_kibana_rbac_default_space_maps_read_user
[00:00:02]           │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [a_kibana_rbac_default_space_maps_read_user]
[00:00:02]           │ debg created user a_kibana_rbac_default_space_maps_read_user
[00:05:41]         └-: dashboard integration
[00:05:41]           └-> "before all" hook in "dashboard integration"
[00:05:41]           └-> "before all" hook in "dashboard integration"
[00:05:41]             │ info [x-pack/test/saved_object_tagging/common/fixtures/es_archiver/dashboard] Loading "mappings.json"
[00:05:41]             │ info [x-pack/test/saved_object_tagging/common/fixtures/es_archiver/dashboard] Loading "data.json"
[00:05:41]             │ info [o.e.c.m.MetadataDeleteIndexService] [node-01] [.kibana_task_manager_8.0.0_001/B3GLs92ESiWr2gePlMlNcw] deleting index
[00:05:41]             │ info [o.e.c.m.MetadataDeleteIndexService] [node-01] [.kibana_1/MXLuRSS7S6C2GsgX4H2QkA] deleting index
[00:05:41]             │ info [o.e.c.m.MetadataDeleteIndexService] [node-01] [.kibana_8.0.0_001/iOHUxfMiTXqg8CmMhtAmiQ] deleting index
[00:05:41]             │ info [x-pack/test/saved_object_tagging/common/fixtures/es_archiver/dashboard] Deleted existing index ".kibana_8.0.0_001"
[00:05:41]             │ info [x-pack/test/saved_object_tagging/common/fixtures/es_archiver/dashboard] Deleted existing index ".kibana_task_manager_8.0.0_001"
[00:05:41]             │ info [x-pack/test/saved_object_tagging/common/fixtures/es_archiver/dashboard] Deleted existing index ".kibana_1"
[00:05:41]             │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [.kibana_1] creating index, cause [api], templates [], shards [1]/[0]
[00:05:41]             │ info [o.e.c.r.a.AllocationService] [node-01] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[.kibana_1][0]]])." previous.health="YELLOW" reason="shards started [[.kibana_1][0]]"
[00:05:41]             │ info [x-pack/test/saved_object_tagging/common/fixtures/es_archiver/dashboard] Created index ".kibana_1"
[00:05:41]             │ debg [x-pack/test/saved_object_tagging/common/fixtures/es_archiver/dashboard] ".kibana_1" settings {"index":{"auto_expand_replicas":"0-1","number_of_replicas":"0","number_of_shards":"1"}}
[00:05:41]             │ info [x-pack/test/saved_object_tagging/common/fixtures/es_archiver/dashboard] Indexed 12 docs into ".kibana"
[00:05:41]             │ debg Migrating saved objects
[00:05:41]             │ proc [kibana] [2021-10-20T11:50:21.648+00:00][INFO ][savedobjects-service] [.kibana_task_manager] INIT -> CREATE_NEW_TARGET. took: 3ms.
[00:05:41]             │ proc [kibana] [2021-10-20T11:50:21.650+00:00][INFO ][savedobjects-service] [.kibana] INIT -> WAIT_FOR_YELLOW_SOURCE. took: 7ms.
[00:05:41]             │ proc [kibana] [2021-10-20T11:50:21.652+00:00][INFO ][savedobjects-service] [.kibana] WAIT_FOR_YELLOW_SOURCE -> CHECK_UNKNOWN_DOCUMENTS. took: 2ms.
[00:05:41]             │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [.kibana_task_manager_8.0.0_001] creating index, cause [api], templates [], shards [1]/[1]
[00:05:41]             │ info [o.e.c.r.a.AllocationService] [node-01] updating number_of_replicas to [0] for indices [.kibana_task_manager_8.0.0_001]
[00:05:41]             │ proc [kibana] [2021-10-20T11:50:21.659+00:00][INFO ][savedobjects-service] [.kibana] CHECK_UNKNOWN_DOCUMENTS -> SET_SOURCE_WRITE_BLOCK. took: 7ms.
[00:05:41]             │ info [o.e.c.m.MetadataIndexStateService] [node-01] adding block write to indices [[.kibana_1/c-AAsHdlSX6xRCt1lo_VaA]]
[00:05:41]             │ info [o.e.c.r.a.AllocationService] [node-01] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[.kibana_task_manager_8.0.0_001][0]]])." previous.health="YELLOW" reason="shards started [[.kibana_task_manager_8.0.0_001][0]]"
[00:05:41]             │ info [o.e.c.m.MetadataIndexStateService] [node-01] completed adding block write to indices [.kibana_1]
[00:05:41]             │ proc [kibana] [2021-10-20T11:50:21.722+00:00][INFO ][savedobjects-service] [.kibana_task_manager] CREATE_NEW_TARGET -> MARK_VERSION_INDEX_READY. took: 74ms.
[00:05:41]             │ proc [kibana] [2021-10-20T11:50:21.741+00:00][INFO ][savedobjects-service] [.kibana] SET_SOURCE_WRITE_BLOCK -> CALCULATE_EXCLUDE_FILTERS. took: 82ms.
[00:05:41]             │ proc [kibana] [2021-10-20T11:50:21.745+00:00][INFO ][savedobjects-service] [.kibana] CALCULATE_EXCLUDE_FILTERS -> CREATE_REINDEX_TEMP. took: 4ms.
[00:05:41]             │ proc [kibana] [2021-10-20T11:50:21.763+00:00][INFO ][savedobjects-service] [.kibana_task_manager] MARK_VERSION_INDEX_READY -> DONE. took: 41ms.
[00:05:41]             │ proc [kibana] [2021-10-20T11:50:21.763+00:00][INFO ][savedobjects-service] [.kibana_task_manager] Migration completed after 118ms
[00:05:41]             │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [.kibana_8.0.0_reindex_temp] creating index, cause [api], templates [], shards [1]/[1]
[00:05:41]             │ info [o.e.c.r.a.AllocationService] [node-01] updating number_of_replicas to [0] for indices [.kibana_8.0.0_reindex_temp]
[00:05:41]             │ info [o.e.c.r.a.AllocationService] [node-01] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[.kibana_8.0.0_reindex_temp][0]]])." previous.health="YELLOW" reason="shards started [[.kibana_8.0.0_reindex_temp][0]]"
[00:05:41]             │ proc [kibana] [2021-10-20T11:50:21.814+00:00][INFO ][savedobjects-service] [.kibana] CREATE_REINDEX_TEMP -> REINDEX_SOURCE_TO_TEMP_OPEN_PIT. took: 69ms.
[00:05:41]             │ proc [kibana] [2021-10-20T11:50:21.818+00:00][INFO ][savedobjects-service] [.kibana] REINDEX_SOURCE_TO_TEMP_OPEN_PIT -> REINDEX_SOURCE_TO_TEMP_READ. took: 4ms.
[00:05:41]             │ proc [kibana] [2021-10-20T11:50:21.825+00:00][INFO ][savedobjects-service] [.kibana] Starting to process 12 documents.
[00:05:41]             │ proc [kibana] [2021-10-20T11:50:21.825+00:00][INFO ][savedobjects-service] [.kibana] REINDEX_SOURCE_TO_TEMP_READ -> REINDEX_SOURCE_TO_TEMP_TRANSFORM. took: 7ms.
[00:05:41]             │ proc [kibana] [2021-10-20T11:50:21.833+00:00][INFO ][savedobjects-service] [.kibana] REINDEX_SOURCE_TO_TEMP_TRANSFORM -> REINDEX_SOURCE_TO_TEMP_INDEX_BULK. took: 8ms.
[00:05:41]             │ info [o.e.c.m.MetadataMappingService] [node-01] [.kibana_8.0.0_reindex_temp/Uqr9lIUTRcqYtsdOSZi9dg] update_mapping [_doc]
[00:05:41]             │ info [o.e.c.m.MetadataMappingService] [node-01] [.kibana_8.0.0_reindex_temp/Uqr9lIUTRcqYtsdOSZi9dg] update_mapping [_doc]
[00:05:41]             │ info [o.e.c.m.MetadataMappingService] [node-01] [.kibana_8.0.0_reindex_temp/Uqr9lIUTRcqYtsdOSZi9dg] update_mapping [_doc]
[00:05:41]             │ info [o.e.c.m.MetadataMappingService] [node-01] [.kibana_8.0.0_reindex_temp/Uqr9lIUTRcqYtsdOSZi9dg] update_mapping [_doc]
[00:05:41]             │ info [o.e.c.m.MetadataMappingService] [node-01] [.kibana_8.0.0_reindex_temp/Uqr9lIUTRcqYtsdOSZi9dg] update_mapping [_doc]
[00:05:41]             │ info [o.e.c.m.MetadataMappingService] [node-01] [.kibana_8.0.0_reindex_temp/Uqr9lIUTRcqYtsdOSZi9dg] update_mapping [_doc]
[00:05:41]             │ info [o.e.c.m.MetadataMappingService] [node-01] [.kibana_8.0.0_reindex_temp/Uqr9lIUTRcqYtsdOSZi9dg] update_mapping [_doc]
[00:05:42]             │ proc [kibana] [2021-10-20T11:50:22.027+00:00][INFO ][savedobjects-service] [.kibana] REINDEX_SOURCE_TO_TEMP_INDEX_BULK -> REINDEX_SOURCE_TO_TEMP_READ. took: 194ms.
[00:05:42]             │ proc [kibana] [2021-10-20T11:50:22.034+00:00][INFO ][savedobjects-service] [.kibana] Processed 12 documents out of 12.
[00:05:42]             │ proc [kibana] [2021-10-20T11:50:22.034+00:00][INFO ][savedobjects-service] [.kibana] REINDEX_SOURCE_TO_TEMP_READ -> REINDEX_SOURCE_TO_TEMP_CLOSE_PIT. took: 7ms.
[00:05:42]             │ proc [kibana] [2021-10-20T11:50:22.037+00:00][INFO ][savedobjects-service] [.kibana] REINDEX_SOURCE_TO_TEMP_CLOSE_PIT -> SET_TEMP_WRITE_BLOCK. took: 3ms.
[00:05:42]             │ info [o.e.c.m.MetadataIndexStateService] [node-01] adding block write to indices [[.kibana_8.0.0_reindex_temp/Uqr9lIUTRcqYtsdOSZi9dg]]
[00:05:42]             │ info [o.e.c.m.MetadataIndexStateService] [node-01] completed adding block write to indices [.kibana_8.0.0_reindex_temp]
[00:05:42]             │ proc [kibana] [2021-10-20T11:50:22.081+00:00][INFO ][savedobjects-service] [.kibana] SET_TEMP_WRITE_BLOCK -> CLONE_TEMP_TO_TARGET. took: 44ms.
[00:05:42]             │ info [o.e.c.m.MetadataCreateIndexService] [node-01] applying create index request using existing index [.kibana_8.0.0_reindex_temp] metadata
[00:05:42]             │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [.kibana_8.0.0_001] creating index, cause [clone_index], templates [], shards [1]/[1]
[00:05:42]             │ info [o.e.c.r.a.AllocationService] [node-01] updating number_of_replicas to [0] for indices [.kibana_8.0.0_001]
[00:05:42]             │ info [o.e.c.m.MetadataMappingService] [node-01] [.kibana_8.0.0_001/srWfZ5pDTTCQ69sFIbBL8Q] create_mapping
[00:05:42]             │ info [o.e.c.r.a.AllocationService] [node-01] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[.kibana_8.0.0_001][0]]])." previous.health="YELLOW" reason="shards started [[.kibana_8.0.0_001][0]]"
[00:05:42]             │ proc [kibana] [2021-10-20T11:50:22.187+00:00][INFO ][savedobjects-service] [.kibana] CLONE_TEMP_TO_TARGET -> REFRESH_TARGET. took: 106ms.
[00:05:42]             │ proc [kibana] [2021-10-20T11:50:22.191+00:00][INFO ][savedobjects-service] [.kibana] REFRESH_TARGET -> OUTDATED_DOCUMENTS_SEARCH_OPEN_PIT. took: 4ms.
[00:05:42]             │ proc [kibana] [2021-10-20T11:50:22.193+00:00][INFO ][savedobjects-service] [.kibana] OUTDATED_DOCUMENTS_SEARCH_OPEN_PIT -> OUTDATED_DOCUMENTS_SEARCH_READ. took: 2ms.
[00:05:42]             │ proc [kibana] [2021-10-20T11:50:22.200+00:00][INFO ][savedobjects-service] [.kibana] OUTDATED_DOCUMENTS_SEARCH_READ -> OUTDATED_DOCUMENTS_SEARCH_CLOSE_PIT. took: 7ms.
[00:05:42]             │ proc [kibana] [2021-10-20T11:50:22.202+00:00][INFO ][savedobjects-service] [.kibana] OUTDATED_DOCUMENTS_SEARCH_CLOSE_PIT -> UPDATE_TARGET_MAPPINGS. took: 2ms.
[00:05:42]             │ info [o.e.c.m.MetadataMappingService] [node-01] [.kibana_8.0.0_001/srWfZ5pDTTCQ69sFIbBL8Q] update_mapping [_doc]
[00:05:42]             │ proc [kibana] [2021-10-20T11:50:22.266+00:00][INFO ][savedobjects-service] [.kibana] UPDATE_TARGET_MAPPINGS -> UPDATE_TARGET_MAPPINGS_WAIT_FOR_TASK. took: 64ms.
[00:05:42]             │ info [o.e.t.LoggingTaskListener] [node-01] 7781 finished with response BulkByScrollResponse[took=31.2ms,timed_out=false,sliceId=null,updated=12,created=0,deleted=0,batches=1,versionConflicts=0,noops=0,retries=0,throttledUntil=0s,bulk_failures=[],search_failures=[]]
[00:05:42]             │ proc [kibana] [2021-10-20T11:50:22.372+00:00][INFO ][savedobjects-service] [.kibana] UPDATE_TARGET_MAPPINGS_WAIT_FOR_TASK -> MARK_VERSION_INDEX_READY. took: 106ms.
[00:05:42]             │ info [o.e.c.m.MetadataDeleteIndexService] [node-01] [.kibana_8.0.0_reindex_temp/Uqr9lIUTRcqYtsdOSZi9dg] deleting index
[00:05:42]             │ proc [kibana] [2021-10-20T11:50:22.412+00:00][INFO ][savedobjects-service] [.kibana] MARK_VERSION_INDEX_READY -> DONE. took: 40ms.
[00:05:42]             │ proc [kibana] [2021-10-20T11:50:22.413+00:00][INFO ][savedobjects-service] [.kibana] Migration completed after 770ms
[00:05:42]             │ debg [x-pack/test/saved_object_tagging/common/fixtures/es_archiver/dashboard] Migrated Kibana index after loading Kibana data
[00:05:42]             │ debg [x-pack/test/saved_object_tagging/common/fixtures/es_archiver/dashboard] Ensured that default space exists in .kibana
[00:05:42]             │ info [x-pack/test/saved_object_tagging/common/fixtures/es_archiver/logstash_functional] Loading "mappings.json"
[00:05:42]             │ info [x-pack/test/saved_object_tagging/common/fixtures/es_archiver/logstash_functional] Loading "data.json.gz"
[00:05:42]             │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [logstash-2015.09.22] creating index, cause [api], templates [], shards [1]/[0]
[00:05:42]             │ info [o.e.c.r.a.AllocationService] [node-01] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[logstash-2015.09.22][0]]])." previous.health="YELLOW" reason="shards started [[logstash-2015.09.22][0]]"
[00:05:42]             │ info [x-pack/test/saved_object_tagging/common/fixtures/es_archiver/logstash_functional] Created index "logstash-2015.09.22"
[00:05:42]             │ debg [x-pack/test/saved_object_tagging/common/fixtures/es_archiver/logstash_functional] "logstash-2015.09.22" settings {"index":{"analysis":{"analyzer":{"url":{"max_token_length":"1000","tokenizer":"uax_url_email","type":"standard"}}},"number_of_replicas":"0","number_of_shards":"1"}}
[00:05:42]             │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [logstash-2015.09.20] creating index, cause [api], templates [], shards [1]/[0]
[00:05:42]             │ info [o.e.c.r.a.AllocationService] [node-01] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[logstash-2015.09.20][0]]])." previous.health="YELLOW" reason="shards started [[logstash-2015.09.20][0]]"
[00:05:42]             │ info [x-pack/test/saved_object_tagging/common/fixtures/es_archiver/logstash_functional] Created index "logstash-2015.09.20"
[00:05:42]             │ debg [x-pack/test/saved_object_tagging/common/fixtures/es_archiver/logstash_functional] "logstash-2015.09.20" settings {"index":{"analysis":{"analyzer":{"url":{"max_token_length":"1000","tokenizer":"uax_url_email","type":"standard"}}},"number_of_replicas":"0","number_of_shards":"1"}}
[00:05:42]             │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [logstash-2015.09.21] creating index, cause [api], templates [], shards [1]/[0]
[00:05:42]             │ info [o.e.c.r.a.AllocationService] [node-01] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[logstash-2015.09.21][0]]])." previous.health="YELLOW" reason="shards started [[logstash-2015.09.21][0]]"
[00:05:42]             │ info [x-pack/test/saved_object_tagging/common/fixtures/es_archiver/logstash_functional] Created index "logstash-2015.09.21"
[00:05:42]             │ debg [x-pack/test/saved_object_tagging/common/fixtures/es_archiver/logstash_functional] "logstash-2015.09.21" settings {"index":{"analysis":{"analyzer":{"url":{"max_token_length":"1000","tokenizer":"uax_url_email","type":"standard"}}},"number_of_replicas":"0","number_of_shards":"1"}}
[00:05:52]             │ info progress: 11884
[00:05:53]             │ info [x-pack/test/saved_object_tagging/common/fixtures/es_archiver/logstash_functional] Indexed 4633 docs into "logstash-2015.09.22"
[00:05:53]             │ info [x-pack/test/saved_object_tagging/common/fixtures/es_archiver/logstash_functional] Indexed 4757 docs into "logstash-2015.09.20"
[00:05:53]             │ info [x-pack/test/saved_object_tagging/common/fixtures/es_archiver/logstash_functional] Indexed 4614 docs into "logstash-2015.09.21"
[00:07:34]           └-: editing
[00:07:34]             └-> "before all" hook for "allows to select tags for an existing dashboard"
[00:07:34]             └-> allows to select tags for an existing dashboard
[00:07:34]               └-> "before each" hook: global before each for "allows to select tags for an existing dashboard"
[00:07:34]               └-> "before each" hook for "allows to select tags for an existing dashboard"
[00:07:34]                 │ debg navigating to dashboard url: http://localhost:61111/app/dashboards#/list
[00:07:34]                 │ debg navigate to: http://localhost:61111/app/dashboards#/list
[00:07:34]                 │ debg browser[INFO] http://localhost:61111/app/dashboards?_t=1634730734559#/list 281 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:07:34]                 │
[00:07:34]                 │ debg browser[INFO] http://localhost:61111/bootstrap.js 41:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:07:34]                 │ debg ... sleep(700) start
[00:07:35]                 │ debg ... sleep(700) end
[00:07:35]                 │ debg returned from get, calling refresh
[00:07:36]                 │ debg browser[INFO] http://localhost:61111/app/dashboards?_t=1634730734559#/list 281 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:07:36]                 │
[00:07:36]                 │ debg browser[INFO] http://localhost:61111/bootstrap.js 41:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:07:36]                 │ debg currentUrl = http://localhost:61111/app/dashboards#/list
[00:07:36]                 │          appUrl = http://localhost:61111/app/dashboards#/list
[00:07:36]                 │ debg TestSubjects.find(kibanaChrome)
[00:07:36]                 │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:07:37]                 │ debg ... sleep(501) start
[00:07:37]                 │ debg ... sleep(501) end
[00:07:37]                 │ debg in navigateTo url = http://localhost:61111/app/dashboards#/list?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:now-15m,to:now))
[00:07:37]                 │ debg --- retry.tryForTime error: URL changed, waiting for it to settle
[00:07:38]                 │ debg ... sleep(501) start
[00:07:38]                 │ debg ... sleep(501) end
[00:07:38]                 │ debg in navigateTo url = http://localhost:61111/app/dashboards#/list?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:now-15m,to:now))
[00:07:38]                 │ debg gotoDashboardLandingPage
[00:07:38]                 │ debg onDashboardLandingPage
[00:07:38]                 │ debg TestSubjects.exists(dashboardLandingPage)
[00:07:38]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="dashboardLandingPage"]') with timeout=5000
[00:07:38]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="itemsInMemTable"]:not(.euiBasicTable-loading)') with timeout=2500
[00:07:38]               │ debg TestSubjects.click(dashboardListingTitleLink-dashboard-4-with-real-data-(tag-1))
[00:07:38]               │ debg Find.clickByCssSelector('[data-test-subj="dashboardListingTitleLink-dashboard-4-with-real-data-(tag-1)"]') with timeout=10000
[00:07:38]               │ debg Find.findByCssSelector('[data-test-subj="dashboardListingTitleLink-dashboard-4-with-real-data-(tag-1)"]') with timeout=10000
[00:07:38]               │ debg Switching to edit mode
[00:07:38]               │ debg TestSubjects.exists(dashboardEditMode)
[00:07:38]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="dashboardEditMode"]') with timeout=2500
[00:07:38]               │ debg browser[INFO] http://localhost:61111/app/dashboards#/view/61c58ad0-3dd3-11e8-b2b9-5d5dc1715159?_g=(filters:!()) 281 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:07:38]               │
[00:07:38]               │ debg browser[INFO] http://localhost:61111/bootstrap.js 41:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:07:41]               │ debg --- retry.tryForTime error: [data-test-subj="dashboardEditMode"] is not displayed
[00:07:41]               │ debg browser[WARNING] http://localhost:61111/47434/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js 20:68219 "Deprecation warning: value provided is not in a recognized RFC2822 or ISO format. moment construction falls back to js Date(), which is not reliable across all browsers and versions. Non RFC2822/ISO date formats are discouraged and will be removed in an upcoming major release. Please refer to http://momentjs.com/guides/#/warnings/js-date/ for more info.
[00:07:41]               │      Arguments: 
[00:07:41]               │      [0] _isAMomentObject: true, _isUTC: false, _useUTC: false, _l: undefined, _i: Mon Apr 09 2018 17:56:08 GMT-0400, _f: undefined, _strict: undefined, _locale: [object Object]
[00:07:41]               │      Error
[00:07:41]               │          at Function.createFromInputFallback (http://localhost:61111/47434/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:21:68648)
[00:07:41]               │          at http://localhost:61111/47434/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:21:88824
[00:07:41]               │          at http://localhost:61111/47434/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:21:88875
[00:07:41]               │          at Ot (http://localhost:61111/47434/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:21:89187)
[00:07:41]               │          at wt (http://localhost:61111/47434/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:21:89448)
[00:07:41]               │          at Mt (http://localhost:61111/47434/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:21:89530)
[00:07:41]               │          at r (http://localhost:61111/47434/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:21:65570)
[00:07:41]               │          at Object.l [as parse] (http://localhost:61111/47434/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:340:135143)
[00:07:41]               │          at http://localhost:61111/47434/bundles/plugin/data/kibana/data.plugin.js:1:129886
[00:07:41]               │          at t._next (http://localhost:61111/47434/bundles/plugin/data/kibana/data.plugin.js:1:129960)"
[00:07:41]               │ debg Waiting up to 20000ms for in edit mode...
[00:07:41]               │ debg TestSubjects.findAll(embeddablePanel)
[00:07:41]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanel"]') with timeout=2500
[00:07:41]               │ warn browser[SEVERE] http://localhost:61111/api/index_patterns/_fields_for_wildcard?pattern=animals-*&meta_fields=_source&meta_fields=_id&meta_fields=_type&meta_fields=_index&meta_fields=_score - Failed to load resource: the server responded with a status of 404 (Not Found)
[00:07:41]               │ debg TestSubjects.findAll(embeddablePanelToggleMenuIcon)
[00:07:41]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=2500
[00:07:41]               │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [.async-search] creating index, cause [auto(bulk api)], templates [], shards [1]/[0]
[00:07:41]               │ info [o.e.c.r.a.AllocationService] [node-01] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[.async-search][0]]])." previous.health="YELLOW" reason="shards started [[.async-search][0]]"
[00:07:42]               │ debg TestSubjects.findAll(embeddablePanel)
[00:07:42]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanel"]') with timeout=2500
[00:07:42]               │ debg TestSubjects.findAll(embeddablePanelToggleMenuIcon)
[00:07:42]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=2500
[00:07:43]               │ info [o.e.c.m.MetadataMappingService] [node-01] [.kibana_8.0.0_001/srWfZ5pDTTCQ69sFIbBL8Q] update_mapping [_doc]
[00:07:43]               │ debg TestSubjects.findAll(embeddablePanel)
[00:07:43]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanel"]') with timeout=2500
[00:07:43]               │ debg TestSubjects.findAll(embeddablePanelToggleMenuIcon)
[00:07:43]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=2500
[00:07:43]               │ debg TestSubjects.findAll(embeddablePanel)
[00:07:43]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanel"]') with timeout=2500
[00:07:43]               │ debg TestSubjects.findAll(embeddablePanelToggleMenuIcon)
[00:07:43]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=2500
[00:07:44]               │ debg TestSubjects.findAll(embeddablePanel)
[00:07:44]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanel"]') with timeout=2500
[00:07:44]               │ debg TestSubjects.findAll(embeddablePanelToggleMenuIcon)
[00:07:44]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=2500
[00:07:44]               │ debg TestSubjects.findAll(embeddablePanel)
[00:07:44]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanel"]') with timeout=2500
[00:07:44]               │ debg TestSubjects.findAll(embeddablePanelToggleMenuIcon)
[00:07:44]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=2500
[00:07:45]               │ debg TestSubjects.findAll(embeddablePanel)
[00:07:45]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanel"]') with timeout=2500
[00:07:45]               │ debg TestSubjects.findAll(embeddablePanelToggleMenuIcon)
[00:07:45]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=2500
[00:07:45]               │ debg TestSubjects.findAll(embeddablePanel)
[00:07:45]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanel"]') with timeout=2500
[00:07:45]               │ debg TestSubjects.findAll(embeddablePanelToggleMenuIcon)
[00:07:45]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=2500
[00:07:46]               │ debg TestSubjects.findAll(embeddablePanel)
[00:07:46]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanel"]') with timeout=2500
[00:07:46]               │ debg TestSubjects.findAll(embeddablePanelToggleMenuIcon)
[00:07:46]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=2500
[00:07:47]               │ info [o.e.c.m.MetadataMappingService] [node-01] [.kibana_8.0.0_001/srWfZ5pDTTCQ69sFIbBL8Q] update_mapping [_doc]
[00:07:47]               │ debg TestSubjects.findAll(embeddablePanel)
[00:07:47]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanel"]') with timeout=2500
[00:07:47]               │ debg TestSubjects.findAll(embeddablePanelToggleMenuIcon)
[00:07:47]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=2500
[00:07:47]               │ debg TestSubjects.findAll(embeddablePanel)
[00:07:47]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanel"]') with timeout=2500
[00:07:47]               │ debg TestSubjects.findAll(embeddablePanelToggleMenuIcon)
[00:07:47]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=2500
[00:07:48]               │ debg TestSubjects.findAll(embeddablePanel)
[00:07:48]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanel"]') with timeout=2500
[00:07:48]               │ debg TestSubjects.findAll(embeddablePanelToggleMenuIcon)
[00:07:48]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=2500
[00:07:48]               │ debg TestSubjects.findAll(embeddablePanel)
[00:07:48]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanel"]') with timeout=2500
[00:07:48]               │ debg TestSubjects.findAll(embeddablePanelToggleMenuIcon)
[00:07:48]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=2500
[00:07:49]               │ debg TestSubjects.findAll(embeddablePanel)
[00:07:49]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanel"]') with timeout=2500
[00:07:49]               │ debg TestSubjects.findAll(embeddablePanelToggleMenuIcon)
[00:07:49]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=2500
[00:07:49]               │ debg TestSubjects.findAll(embeddablePanel)
[00:07:49]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanel"]') with timeout=2500
[00:07:49]               │ debg TestSubjects.findAll(embeddablePanelToggleMenuIcon)
[00:07:49]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=2500
[00:07:50]               │ debg TestSubjects.findAll(embeddablePanel)
[00:07:50]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanel"]') with timeout=2500
[00:07:50]               │ debg TestSubjects.findAll(embeddablePanelToggleMenuIcon)
[00:07:50]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=2500
[00:07:51]               │ debg TestSubjects.findAll(embeddablePanel)
[00:07:51]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanel"]') with timeout=2500
[00:07:51]               │ debg TestSubjects.findAll(embeddablePanelToggleMenuIcon)
[00:07:51]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=2500
[00:07:51]               │ debg TestSubjects.findAll(embeddablePanel)
[00:07:51]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanel"]') with timeout=2500
[00:07:51]               │ debg TestSubjects.findAll(embeddablePanelToggleMenuIcon)
[00:07:51]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=2500
[00:07:52]               │ debg TestSubjects.findAll(embeddablePanel)
[00:07:52]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanel"]') with timeout=2500
[00:07:52]               │ debg TestSubjects.findAll(embeddablePanelToggleMenuIcon)
[00:07:52]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=2500
[00:07:52]               │ debg TestSubjects.findAll(embeddablePanel)
[00:07:52]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanel"]') with timeout=2500
[00:07:52]               │ debg TestSubjects.findAll(embeddablePanelToggleMenuIcon)
[00:07:52]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=2500
[00:07:53]               │ debg TestSubjects.findAll(embeddablePanel)
[00:07:53]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanel"]') with timeout=2500
[00:07:53]               │ debg TestSubjects.findAll(embeddablePanelToggleMenuIcon)
[00:07:53]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=2500
[00:07:53]               │ debg TestSubjects.findAll(embeddablePanel)
[00:07:53]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanel"]') with timeout=2500
[00:07:53]               │ debg TestSubjects.findAll(embeddablePanelToggleMenuIcon)
[00:07:53]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=2500
[00:07:54]               │ debg TestSubjects.findAll(embeddablePanel)
[00:07:54]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanel"]') with timeout=2500
[00:07:54]               │ debg TestSubjects.findAll(embeddablePanelToggleMenuIcon)
[00:07:54]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=2500
[00:07:55]               │ debg TestSubjects.findAll(embeddablePanel)
[00:07:55]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanel"]') with timeout=2500
[00:07:55]               │ debg TestSubjects.findAll(embeddablePanelToggleMenuIcon)
[00:07:55]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=2500
[00:07:55]               │ debg TestSubjects.findAll(embeddablePanel)
[00:07:55]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanel"]') with timeout=2500
[00:07:55]               │ debg TestSubjects.findAll(embeddablePanelToggleMenuIcon)
[00:07:55]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=2500
[00:07:56]               │ debg TestSubjects.findAll(embeddablePanel)
[00:07:56]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanel"]') with timeout=2500
[00:07:56]               │ debg TestSubjects.findAll(embeddablePanelToggleMenuIcon)
[00:07:56]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=2500
[00:07:56]               │ debg TestSubjects.findAll(embeddablePanel)
[00:07:56]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanel"]') with timeout=2500
[00:07:56]               │ debg TestSubjects.findAll(embeddablePanelToggleMenuIcon)
[00:07:56]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=2500
[00:07:57]               │ debg TestSubjects.findAll(embeddablePanel)
[00:07:57]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanel"]') with timeout=2500
[00:07:57]               │ debg TestSubjects.findAll(embeddablePanelToggleMenuIcon)
[00:07:57]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=2500
[00:07:57]               │ debg TestSubjects.findAll(embeddablePanel)
[00:07:57]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanel"]') with timeout=2500
[00:07:57]               │ debg TestSubjects.findAll(embeddablePanelToggleMenuIcon)
[00:07:57]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=2500
[00:07:58]               │ debg TestSubjects.findAll(embeddablePanel)
[00:07:58]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanel"]') with timeout=2500
[00:07:58]               │ debg TestSubjects.findAll(embeddablePanelToggleMenuIcon)
[00:07:58]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=2500
[00:07:59]               │ debg TestSubjects.findAll(embeddablePanel)
[00:07:59]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanel"]') with timeout=2500
[00:07:59]               │ debg TestSubjects.findAll(embeddablePanelToggleMenuIcon)
[00:07:59]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=2500
[00:07:59]               │ debg TestSubjects.findAll(embeddablePanel)
[00:07:59]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanel"]') with timeout=2500
[00:07:59]               │ debg TestSubjects.findAll(embeddablePanelToggleMenuIcon)
[00:07:59]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=2500
[00:08:00]               │ debg TestSubjects.findAll(embeddablePanel)
[00:08:00]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanel"]') with timeout=2500
[00:08:00]               │ debg TestSubjects.findAll(embeddablePanelToggleMenuIcon)
[00:08:00]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=2500
[00:08:00]               │ debg TestSubjects.findAll(embeddablePanel)
[00:08:00]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanel"]') with timeout=2500
[00:08:00]               │ debg TestSubjects.findAll(embeddablePanelToggleMenuIcon)
[00:08:00]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=2500
[00:08:01]               │ debg TestSubjects.findAll(embeddablePanel)
[00:08:01]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanel"]') with timeout=2500
[00:08:01]               │ debg TestSubjects.findAll(embeddablePanelToggleMenuIcon)
[00:08:01]               │ debg Find.allByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]') with timeout=2500
[00:08:01]               │ info Taking screenshot "/dev/shm/workspace/parallel/11/kibana/x-pack/test/saved_object_tagging/functional/screenshots/failure/saved objects tagging - functional tests dashboard integration editing allows to select tags for an existing dashboard.png"
[00:08:02]               │ info Current URL is: http://localhost:61111/app/dashboards#/view/61c58ad0-3dd3-11e8-b2b9-5d5dc1715159?_g=(filters:!())
[00:08:02]               │ info Saving page source to: /dev/shm/workspace/parallel/11/kibana/x-pack/test/saved_object_tagging/functional/failure_debug/html/saved objects tagging - functional tests dashboard integration editing allows to select tags for an existing dashboard.html
[00:08:02]               └- ✖ fail: saved objects tagging - functional tests dashboard integration editing allows to select tags for an existing dashboard
[00:08:02]               │      Error: timed out waiting for in edit mode
[00:08:02]               │       at onFailure (/dev/shm/workspace/parallel/11/kibana/test/common/services/retry/retry_for_truthy.ts:39:13)
[00:08:02]               │       at retryForSuccess (/dev/shm/workspace/parallel/11/kibana/test/common/services/retry/retry_for_success.ts:59:13)
[00:08:02]               │       at retryForTruthy (/dev/shm/workspace/parallel/11/kibana/test/common/services/retry/retry_for_truthy.ts:27:3)
[00:08:02]               │       at RetryService.waitFor (/dev/shm/workspace/parallel/11/kibana/test/common/services/retry/retry.ts:59:5)
[00:08:02]               │       at DashboardPageObject.switchToEditMode (/dev/shm/workspace/parallel/11/kibana/test/functional/page_objects/dashboard_page.ts:257:5)
[00:08:02]               │       at Context.<anonymous> (test/saved_object_tagging/functional/tests/dashboard_integration.ts:166:9)
[00:08:02]               │       at Object.apply (/dev/shm/workspace/parallel/11/kibana/node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:87:16)
[00:08:02]               │ 
[00:08:02]               │

Stack Trace

Error: timed out waiting for in edit mode
    at onFailure (/dev/shm/workspace/parallel/11/kibana/test/common/services/retry/retry_for_truthy.ts:39:13)
    at retryForSuccess (/dev/shm/workspace/parallel/11/kibana/test/common/services/retry/retry_for_success.ts:59:13)
    at retryForTruthy (/dev/shm/workspace/parallel/11/kibana/test/common/services/retry/retry_for_truthy.ts:27:3)
    at RetryService.waitFor (/dev/shm/workspace/parallel/11/kibana/test/common/services/retry/retry.ts:59:5)
    at DashboardPageObject.switchToEditMode (/dev/shm/workspace/parallel/11/kibana/test/functional/page_objects/dashboard_page.ts:257:5)
    at Context.<anonymous> (test/saved_object_tagging/functional/tests/dashboard_integration.ts:166:9)
    at Object.apply (/dev/shm/workspace/parallel/11/kibana/node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:87:16)

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`upgradeAssistant`	108	145	+37

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`upgradeAssistant`	104.3KB	136.3KB	+32.1KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`core`	303.1KB	303.4KB	+338.0B
`esUiShared`	124.5KB	124.6KB	+16.0B
`upgradeAssistant`	18.9KB	18.3KB	-669.0B
total			-315.0B

Saved Objects .kibana field count

Every field in each saved object type adds overhead to Elasticsearch. Kibana needs to keep the total field count below Elasticsearch's default limit of 1000 fields. Only specify field mappings for the fields you wish to search on or query. See https://www.elastic.co/guide/en/kibana/master/development-plugin-saved-objects.html#_mappings

id	before	after	diff
`upgrade-assistant-telemetry`	13	4	-9

Unknown metric groups

References to deprecated APIs

id	before	after	diff
`upgradeAssistant`	4	7	+3

History

💔 Build #163132 failed 08643be
💚 Build #161923 succeeded 32946a8648854e3f218e42f75513cb026bf7c8ba
💔 Build #161885 failed 5f103d68f8ff83f5b45f2d282cb5b5de8cdc5d73
💔 Build #161443 failed 31459fcdbeb4177c4a30439921f2b9d95850551b
💔 Build #161417 failed ab3d8f17abfb8ba4d884de902d06b9c2fd7d34fe

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @sabarasaba

yuliacech

Thank you so much for bringing all those PRs together, @sabarasaba, that is a massive effort! I reviewed the files outside x-pack/plugins/upgrade_assistant and changes LGTM. Then I compared the UA folder in this PR to the one in 7.16. I believe that the goal is that they are identical as much as possible, right?. Currently there are some changes that are just the same code in different places and then there are some differences, I couldn't quite explain. Do you know if these differences are due to breaking changes in 8.0?

cjcenizal

This truly is a herculean effort! Great work getting it this far, @sabarasaba! I ran a diff between these files and those in 7.16 and found some discrepancies.

Process

I created a copy of the repo on master and a copy of the repo on 7.16 and ran this command to diff them:

diff -rq /kibana-7/x-pack/plugins/upgrade_assistant /kibana/x-pack/plugins/upgrade_assistant --exclude=.DS_Store

I then ran a verbose diff on all of the files that it identified as containing differences between the two directories. Some of them seemed like false positives which I guess we can ignore. Where there were true positives, I dug deeper into commit histories to figure out how they came to be.

Findings

Here are the files that contained differences, and my analysis of them. I think there are only 3 files that need to be fixed, and 1 that needs to be investigated. Note that a number of these were pretty confusing to track down. I'm 95% confident in the items I marked "Ignore", but I suggest double-checking the ones marked "Fix" and making sure you concur.

setup_environment.tsx

x-pack/plugins/upgrade_assistant/__jest__/client_integration/helpers/setup_environment.tsx

Ignore: Identical export const kibanaVersion = new SemVer(MAJOR_VERSION);

service.mock.ts

x-pack/plugins/upgrade_assistant/__jest__/client_integration/kibana_deprecations/service.mock.ts

Fix: see comment (#114966 (comment))

constants.ts

x-pack/plugins/upgrade_assistant/common/constants.ts

Ignore: MAJOR_VERSION set to 7.16.0 vs 8.0.0

checklist_step.test.tsx

x-pack/plugins/upgrade_assistant/public/application/components/es_deprecations/deprecation_types/reindex/flyout/checklist_step.test.tsx

Fix: See comment (#114966 (comment))

warning_step.test.tsx

x-pack/plugins/upgrade_assistant/public/application/components/es_deprecations/deprecation_types/reindex/flyout/warning_step.test.tsx

Fix: See comment (#114966 (comment))

warning_step.test.tsx

x-pack/plugins/upgrade_assistant/public/plugin.ts

Ignore: Diff is empty space

types.ts

x-pack/plugins/upgrade_assistant/public/types.ts

Ignore: Identical ClientConfigType interfaces

config.ts

x-pack/plugins/upgrade_assistant/server/config.ts

Investigate: { defaultValue: undefined } added to schemaLatest and schema7x in #115541. Not sure what this is for or why it was only added to 7.16.

reindex_actions.ts

x-pack/plugins/upgrade_assistant/server/lib/reindexing/reindex_actions.ts

Ignore: See comment (#114966 (comment))

reindex_service.ts

x-pack/plugins/upgrade_assistant/server/lib/reindexing/reindex_service.ts

Ignore: See comment (#114966 (comment))

worker.ts

x-pack/plugins/upgrade_assistant/server/lib/reindexing/worker.ts

Ignore: See comment (#114966 (comment))

...ck/plugins/upgrade_assistant/__jest__/client_integration/kibana_deprecations/service.mock.ts

...lication/components/es_deprecations/deprecation_types/reindex/flyout/checklist_step.test.tsx

...pplication/components/es_deprecations/deprecation_types/reindex/flyout/warning_step.test.tsx

cjcenizal · 2021-10-20T22:37:35Z

x-pack/plugins/upgrade_assistant/server/lib/reindexing/reindex_actions.ts

@@ -266,76 +236,5 @@ export const reindexActionsFactory = (

      return flatSettings.body[indexName];
    },


We can ignore this. This was added in 7.x to support mapping types, which have been removed in 8.

On ln 210, 7.16 has a withTypeName parameter:

kibana/x-pack/plugins/upgrade_assistant/server/lib/reindexing/reindex_actions.ts

Lines 211 to 214 in 9231d80

async getFlatSettings(indexName: string, withTypeName?: boolean) {

let flatSettings;

if (versionService.getMajorVersion() === 7 && withTypeName) {

cjcenizal · 2021-10-20T22:39:22Z

x-pack/plugins/upgrade_assistant/server/lib/reindexing/reindex_service.ts

@@ -476,23 +351,6 @@ export const reindexServiceFactory = (
    });


We can ignore this. This was added in 7.x to support mapping types, which have been removed in 8.

On ln406 7.16 passes true as this parameter:

kibana/x-pack/plugins/upgrade_assistant/server/lib/reindexing/reindex_service.ts

Line 406 in 9231d80

const flatSettings = await actions.getFlatSettings(indexName, true);

Changed in cd9da66#diff-fc6ae8cf0aeabd326a5bbad51c14aab8c9340735a0a05f4ed3d3f2f272bf7c53R551

cjcenizal · 2021-10-20T22:41:25Z

x-pack/plugins/upgrade_assistant/server/lib/reindexing/worker.ts

@@ -223,7 +232,7 @@ export class ReindexWorker {
    reindexOp = await swallowExceptions(service.processNextStep, this.log)(reindexOp);


We can ignore this.

On ln231 7.16 creates fakeRequest:

kibana/x-pack/plugins/upgrade_assistant/server/lib/reindexing/worker.ts

Lines 231 to 238 in 9231d80

// Setup a ReindexService specific to these credentials.

const fakeRequest: FakeRequest = { headers: credential };

const scopedClusterClient = this.clusterClient.asScoped(fakeRequest);

const callAsCurrentUser = scopedClusterClient.asCurrentUser;

const actions = reindexActionsFactory(this.client, callAsCurrentUser);

const service = reindexServiceFactory(callAsCurrentUser, actions, this.log, this.licensing);

Originally introduced in https://github.com/elastic/kibana/pull/61082/files#diff-67d0943ad643f8d8d99e9a04387e75e23d2596456fe34463a0acbfb7ada414bbR134

But looking more closely at this, it looks like this was refactored in https://github.com/elastic/kibana/pull/60770/files#diff-67d0943ad643f8d8d99e9a04387e75e23d2596456fe34463a0acbfb7ada414bb to use the getCredentialScopedReindexService helper in master, but it was left out of the backport to 7.x in https://github.com/elastic/kibana/pull/61082/files#diff-67d0943ad643f8d8d99e9a04387e75e23d2596456fe34463a0acbfb7ada414bb. This might have been a mistake. If so, I think this is a difference we can safely ignore.

I can't recall a specific reason for that not being backported, likely it was a mistake that snuck in due to the differences between 7.x and master causing merge conflicts when doing a backport 😅 . Specifically the differences around this.apmIndexPatterns which probably triggered the conflict.

TinaHeiligers

DocLinks, api docs and telemetry-related changes LGTM.

cjcenizal · 2021-10-21T04:24:43Z

Just a note that it will be acceptable if this work spills over into 8.1, since UA is disabled in 8.0 anyway and there's a near-zero chance we'll need to fix anything for it in a 8.0.x patch release. The only aspect to consider is the status API which Cloud uses to determine whether a deployment can be upgraded. We should make sure we're fulfilling the contract they expect in 8.0.

sebelga · 2021-10-21T09:17:48Z

config.ts
x-pack/plugins/upgrade_assistant/server/config.ts
Investigate: { defaultValue: undefined } added to schemaLatest and schema7x in #115541. Not sure what this is for or why it > was only added to 7.16.

This was a fix for a regression when running in 7.x. I created #115903 to bring the change back to master and align both branches.

sabarasaba · 2021-10-25T09:29:34Z

Thanks everyone for having a look! @cjcenizal I've address your comments with 31ced6f 🎸

cjcenizal

Didn't re-test locally, but I reviewed your changes and also re-ran diff locally. Code LGTM! Great work, @sabarasaba!

UA functional API integration test to check cloud backup status creates a snapshot repo, which fails to be created with my changes to config.ts `'path.repo=/tmp/repo,/tmp/repo_1,/tmp/repo_2,'`. Adding `/tmp/cloud-snapshots/'` to the config fixes the test.

…c#116335) * Fix typos * Fix typo also in server tests * Make sure log collection remains enabled throughout the test Co-authored-by: Kibana Machine <[email protected]>

lockewritesdocs · 2021-11-08T14:57:33Z

@elasticmachine update branch

kibanamachine · 2021-11-08T17:04:46Z

💛 Build succeeded, but was flaky

Test Failures

[job] [logs] Default CI Group #4 / lens app lens add-to-dashboards tests should allow new lens to be added by reference to a new dashboard

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`upgradeAssistant`	102	127	+25

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`upgradeAssistant`	103.8KB	133.2KB	+29.4KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`core`	267.2KB	267.5KB	+338.0B
`esUiShared`	122.2KB	122.3KB	+16.0B
`upgradeAssistant`	16.7KB	18.0KB	+1.3KB
total			+1.6KB

Saved Objects .kibana field count

Every field in each saved object type adds overhead to Elasticsearch. Kibana needs to keep the total field count below Elasticsearch's default limit of 1000 fields. Only specify field mappings for the fields you wish to search on or query. See https://www.elastic.co/guide/en/kibana/master/development-plugin-saved-objects.html#_mappings

id	before	after	diff
`upgrade-assistant-telemetry`	13	4	-9

Unknown metric groups

References to deprecated APIs

id	before	after	diff
`upgradeAssistant`	4	7	+3

History

💚 Build #4949 succeeded 2c629dd
💔 Build #4936 failed db0b847
💔 Build #4925 failed 69d6a51
💔 Build #4914 failed 6ea3df4
💔 Build #1875 failed 6d4e086
💔 Build #1855 failed c873873

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @sabarasaba

yuliacech

Hi @sabarasaba, thank you so much for bringing this PR to completion! Amazing job 👍
The only thing I noticed is that Read.me file in UA plugin refers to master branch in a couple of places. Other than that, I'm happy to see this PR getting merged.

* Fix link to Cloud deployment URL in upgrade step. (elastic#109528) * [Upgrade Assistant] Refactor CITs * Rename UA steps to fix_issues_step and fix_logs_step. (elastic#109526) * Rename tests accordingly. * [Upgrade Assistant] Cleanup scss (elastic#109524) * [Upgrade Assistant] Update readme (elastic#109502) * Add "Back up data" step to UA (elastic#109543) * Add backup step with static content and link to Snapshot and Restore. * Add snapshot_restore locator. * Remove unnecessary describe block from Upgrade Step tests. * Remove unused render_app.tsx. * Change copy references of 'deprecation issues' to 'deprecation warnings'. (elastic#109963) * [Upgrade Assistant] Address design feedback for ES deprecations page (elastic#109726) * [Upgrade Assistant] Add checkpoint feature to Overview page (elastic#109449) * Add on-Cloud state to Upgrade Assistant 'Back up data' step (elastic#109956) * [Upgrade Assistant] Refactor external links to use locators (elastic#110435) * [Upgrade Assistant] Use AppContext for services instead of KibanaContext (elastic#109801) * Remove kibana context dependency in favour of app context * Add missing type to ContextValue * Fix mock type * Refactor app mount flow and types * Refactor to use useServices hook * Fix linter issues * Keep mount_management_section and initialize breadcrumbs and api there * Remove useServices and usePlugins in favour of just useAppContext * Remove unnecessary mocks * [Upgrade Assistant] Enable functional and a11y tests (elastic#109909) * [Upgrade Assistant] Remove version from UA nav title (elastic#110739) * [Upgrade Assistant] New Kibana deprecations page (elastic#110101) * Use injected lib.handleEsError instead of importing it in Upgrade Assistant API route handlers. (elastic#111067) * Add tests for UA back up data step on Cloud (elastic#111066) * Update UA to consume snapshotsUrl as provided by the Cloud plugin. (elastic#111239) * Skip flaky UA Backup step polling test. * [Upgrade Assistant] Refactor kibana deprecation service mocks (elastic#111168) * [Upgrade Assistant] Remove unnecessary EuiScreenReaderOnly from stat panels (elastic#111518) * Remove EuiScreenReaderOnly implementations * Remove unused translations * Remove extra string after merge conflict * Use consistent 'issues' and 'critical' vs. 'warning' terminology in UA. (elastic#111221) * Refactor UA Overview to support step-completion (elastic#111243) * Refactor UA Overview to store step-completion state at the root and delegate step-completion logic to each step component. * Add completion status to logs and issues steps * [Upgrade Assistant] External links with checkpoint time-range applied (elastic#111252) * Bound query around last checkpoint date * Fix tests * Also test discover url contains search params * Small refactor * Keep state about lastCheckpoint in parent component * Remove space * Address CR changes Co-authored-by: Kibana Machine <[email protected]> * [Upgrade Assistant] Tests for updating step state accordingly if API poll receives count followed by error (elastic#111701) * Add test for logs count polling * Test when count api fails * [Upgrade Assistant] Add a11y tests for es deprecation flyouts (elastic#110843) * [Upgrade Assistant] Set fix_logs step as incomplete if log collection is not enabled (elastic#111827) * set step as incomplete if toggle is disabled * Fix test names * Remove unnecessary mocks * [Upgrade Assistant] Update copy to use "issues" instead of "warnings" (elastic#111817) * Create common deprecation issues panel component in UA (elastic#111231) * Refine success state behavior and add tests. * Refactor components into a components directory. * Refactor SCSS to colocate styles with their components. * Refactor tests to reduce boilerplate and clarify conditions under test. * [Upgrade Assistant] Fix Kibana deprecations warning message * [Upgrade Assistant] Add support for API keys when reindexing (elastic#111451) * [Upgrade Assistant] Update readme (elastic#112154) * [Upgrade Assistant] Make infra plugin optional (elastic#111960) * Make infra plugin optional * Fix CR requests * [Upgrade Assistant] Improve flyout information architecture (elastic#111713) * Make sure longstrings inside flyout body are text-wrap * Show resolved badge for reindex flyout and row * Finish off rest of ES deprecation flyouts * Refactor deprecation badge into its own component * Add tests for kibana deprecations * Add tests for es deprecations * Also check that we have status=error before rendering error callout * Check for non-complete states instead of just error * Small refactor * Default deprecation is not resolvable * Add a bit more spacing between title and badge * Address CR changes * Use EuiSpacer instead of flexitems * [Upgrade Assistant] Update readme (elastic#112195) * [Upgrade Assistant] Add integration tests for Overview page (elastic#111370) * Add a11y tests for when overview page has toggle enabled * Add functional and accessibility tests for overview page * Load test files * Fix linter error * Navigate before asserting * Steps have now completion state * Remove duped word * Run setup only once, not per test * Address CR changes * No need to renavigate to the page Co-authored-by: Kibana Machine <[email protected]> * [Upgrade Assistant] Add note about compatibility headers (elastic#110469) * Improve error states for Upgrade Assistant deprecation issues (elastic#112457) * Simplify error state for deprecation issues panels. Remove <EsStatsError />. * Rename components from stats -> panel. * Create common error-reporting component for use in both Kibana and ES deprecations pages. * Align order of loading, error, and success states between these pages. * Change references to 'deprecations' -> 'deprecation issues'. * Fix tests for panels. * Add API integration test for handling auth error. * Fix TS errors. Co-authored-by: Kibana Machine <[email protected]> * Change count poll time to 15s (elastic#112669) * [Upgrade Assistant] Add permissions check to logs step (elastic#112420) * [Upgrade Assistant] Refactor telemetry (elastic#112177) * [Upgrade Assistant] Check for ML upgrade mode before enabling flyout actions (elastic#112555) * Add missing error handlers for deprecation logging route (elastic#113109) * [Upgrade Assistant] Batch reindex docs (elastic#112960) * [UA] Added batch reindexing docs link to the ES deprecations page. Added a link from "batch reindexing" docs page to "start or resume reindex" docs page and from there to ES reindexing docs page. Also renamed "reindexing operation" to "reindexing task" for consistency. * [Upgrade Assistant] Added docs build files * Update x-pack/plugins/upgrade_assistant/public/application/components/es_deprecations/es_deprecations.tsx Co-authored-by: James Rodewig <[email protected]> * Update x-pack/plugins/upgrade_assistant/public/application/components/es_deprecations/es_deprecations.tsx Co-authored-by: James Rodewig <[email protected]> * [Upgrade Assistant] Added review suggestions and fixed eslint issues Co-authored-by: James Rodewig <[email protected]> Co-authored-by: Kibana Machine <[email protected]> * [Upgrade Assistant] Improve error messages for GET /api/upgrade_assistant/reindex/<index> (elastic#112961) * Add support for single manual steps to Upgrade Assistant. (elastic#113344) * Revert "[Upgrade Assistant] Refactor telemetry (elastic#112177)" (elastic#113665) This reverts commit 991d24b. * [Upgrade Assistant] Use skipFetchFields when creating the indexPattern in order to avoid errors if index doesn't exist (elastic#113821) * Use skipFetchFields when creating the indexPatter in order to avoid errors when index doesnt exist * Address CR feedback Co-authored-by: Kibana Machine <[email protected]> * [Upgrade Assistant] Hide system indices from es deprecations list (elastic#113627) * Refactor reindex routes into separate single and batch reindex files. Apply version precheck to batch routes. (elastic#113822) * [Upgrade Assistant] Remove ML/Watcher logic (elastic#113224) * Add show upgrade flag to url (elastic#114243) * [Upgrade Assistant] Delete deprecation log cache (elastic#114113) * [Upgrade Assistant] Add upgrade system indices section (elastic#110593) * [Upgrade Assistant] Reindexing progress (elastic#114275) * [Upgrade Assistant] Added reindexing progress in % to the reindex flyout and es deprecations table * [Upgrade Assistant] Renamed first argument in `getReindexProgressLabel` to `reindexTaskPercComplete` for consistency Co-authored-by: Kibana Machine <[email protected]> * [Upgrade Assistant] Remove Fix manually heading when there are no manual steps * Add rolling upgrade interstitials to UA (elastic#112907) * Refactor FixLogsStep to be explicit in which props are passed to DeprecationLoggingToggle. * Centralize error-handling logic in the api service, instead of handling it within each individual API request. Covers: - Cloud backup status - ES deprecations - Deprecation logging - Remove index settings - ML - Reindexing Also: - Handle 426 error state and surface in UI. - Move ResponseError type into common/types. * Add note about intended use case of status API route. * Add endpoint dedicated to surfacing the cluster upgrade state, and a client-side poll. * Merge App and AppWithRouter components. * [Upgrade Assistant] Added "accept changes" header to the warnings list in the reindex flyout (elastic#114798) * Refactor kibana deprecation tests (elastic#114763) Co-authored-by: Kibana Machine <[email protected]> * Fix linter issues * Remove unused translation * Prefer master changes over 7.x for ml docs * Prefer master changes over 7.x * Skip tests * Move everything to a single describe * Fix types * Add missing prop to mock * [Upgrade Assistant] Removed "closed index" warning from reindex flyout (elastic#114861) * [Upgrade Assistant] Removed "closed index" warning that reindexing might take longer than usual, which is not the case * [Upgrade Assistant] Also deleted i18n strings that are not needed anymore * Add LevelIconTips to be more explicit about the difference between critical and warning issues. (elastic#115121) * Extract common DeprecationFlyoutLearnMoreLink component and change wording to 'Learn more'. (elastic#115117) * [Upgrade Assistant] Reindexing cancellation (elastic#114636) * [Upgrade Assistant] Updated the reindexing cancellation to look less like an error * [Upgrade Assistant] Fixed an i18n issue and updated a jest snapshot * [Upgrade Assistant] Updated cancelled reindexing state with a unified label and cross icon * [Upgrade Assistant] Fixed snapshot test * [Upgrade Assistant] Updated spacing to the reindex cancel button Co-authored-by: Kibana Machine <[email protected]> * Fix test errors (elastic#115183) Co-authored-by: Kibana Machine <[email protected]> * [Upgrade Assistant] Overview page UI clean up (elastic#115258) - Scaling down deprecation issue panel title size to flow with typographic hierarchy. - Removing panel around deprecation logging switch to reduce visual elements. - Using success instead of green color for migration complete message. * Revert "Revert "[Upgrade Assistant] Refactor telemetry (elastic#112177)" (elastic#113665)" (elastic#114804) This reverts commit c385d49. * Add migration to remove obsolete attributes from telemetry saved object. * Refactor UA telemetry constants by extracting it from common/types. * [Upgrade Assistant] Rename upgrade_status to migration_status (elastic#114755) * [Upgrade Assistant] Swapped reindexing flyouts order (elastic#115046) * [Upgrade Assistant] Changed reindexing steps order, replaced a warning callout with a text element * [Upgrade Assistant] Fixed reindex flyout test and changed warning callout from danger color to warning color * [Upgrade Assistant] Fixed the correct status to show warnings * [Upgrade Assistant] Fixed i18n strings * [Upgrade Assistant] Moved reindex with warnings logic into a function * [Upgrade Assistant] Updated reindex flyout copy * [Upgrade Assistant] Also added a trailing period to the reindex step 3 * [Upgrade Assistant] Fixed i18n strings and step 3 wording * [Upgrade Assistant] Added docs changes Co-authored-by: Kibana Machine <[email protected]> * [Upgrade Assistant] Hide features that don't need to be migrated from flyout (elastic#115535) * Filter out system indices that dont require migration on server side * Rename to attrs to migration * Update flyout snapshot. * Refine Upgrade Assistant copy. (elastic#115472) * Remove unused file * Fix kibanaVersion dep * Updated config.ts to fix UA test UA functional API integration test to check cloud backup status creates a snapshot repo, which fails to be created with my changes to config.ts `'path.repo=/tmp/repo,/tmp/repo_1,/tmp/repo_2,'`. Adding `/tmp/cloud-snapshots/'` to the config fixes the test. * Address CR changes * Add missing error handler for system indices migration (elastic#116088) * Fix broken tests * Fix test * Skip tests * Fix linter errors and import * [Upgrade Assistant] Fix typo in retrieval of cluster settings (elastic#116335) * Fix typos * Fix typo also in server tests * Make sure log collection remains enabled throughout the test Co-authored-by: Kibana Machine <[email protected]> * Fix type errors * Fix integration test types * Fix accessibility test type errors * Fix linter errors in shared_imports * Fix functional test types Co-authored-by: CJ Cenizal <[email protected]> Co-authored-by: Alison Goryachev <[email protected]> Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Yulia Čech <[email protected]> Co-authored-by: James Rodewig <[email protected]> Co-authored-by: Dmitry Borodyansky <[email protected]>

* [Upgrade Assistant] Forwardport from 7.x (#114966) * Fix link to Cloud deployment URL in upgrade step. (#109528) * [Upgrade Assistant] Refactor CITs * Rename UA steps to fix_issues_step and fix_logs_step. (#109526) * Rename tests accordingly. * [Upgrade Assistant] Cleanup scss (#109524) * [Upgrade Assistant] Update readme (#109502) * Add "Back up data" step to UA (#109543) * Add backup step with static content and link to Snapshot and Restore. * Add snapshot_restore locator. * Remove unnecessary describe block from Upgrade Step tests. * Remove unused render_app.tsx. * Change copy references of 'deprecation issues' to 'deprecation warnings'. (#109963) * [Upgrade Assistant] Address design feedback for ES deprecations page (#109726) * [Upgrade Assistant] Add checkpoint feature to Overview page (#109449) * Add on-Cloud state to Upgrade Assistant 'Back up data' step (#109956) * [Upgrade Assistant] Refactor external links to use locators (#110435) * [Upgrade Assistant] Use AppContext for services instead of KibanaContext (#109801) * Remove kibana context dependency in favour of app context * Add missing type to ContextValue * Fix mock type * Refactor app mount flow and types * Refactor to use useServices hook * Fix linter issues * Keep mount_management_section and initialize breadcrumbs and api there * Remove useServices and usePlugins in favour of just useAppContext * Remove unnecessary mocks * [Upgrade Assistant] Enable functional and a11y tests (#109909) * [Upgrade Assistant] Remove version from UA nav title (#110739) * [Upgrade Assistant] New Kibana deprecations page (#110101) * Use injected lib.handleEsError instead of importing it in Upgrade Assistant API route handlers. (#111067) * Add tests for UA back up data step on Cloud (#111066) * Update UA to consume snapshotsUrl as provided by the Cloud plugin. (#111239) * Skip flaky UA Backup step polling test. * [Upgrade Assistant] Refactor kibana deprecation service mocks (#111168) * [Upgrade Assistant] Remove unnecessary EuiScreenReaderOnly from stat panels (#111518) * Remove EuiScreenReaderOnly implementations * Remove unused translations * Remove extra string after merge conflict * Use consistent 'issues' and 'critical' vs. 'warning' terminology in UA. (#111221) * Refactor UA Overview to support step-completion (#111243) * Refactor UA Overview to store step-completion state at the root and delegate step-completion logic to each step component. * Add completion status to logs and issues steps * [Upgrade Assistant] External links with checkpoint time-range applied (#111252) * Bound query around last checkpoint date * Fix tests * Also test discover url contains search params * Small refactor * Keep state about lastCheckpoint in parent component * Remove space * Address CR changes Co-authored-by: Kibana Machine <[email protected]> * [Upgrade Assistant] Tests for updating step state accordingly if API poll receives count followed by error (#111701) * Add test for logs count polling * Test when count api fails * [Upgrade Assistant] Add a11y tests for es deprecation flyouts (#110843) * [Upgrade Assistant] Set fix_logs step as incomplete if log collection is not enabled (#111827) * set step as incomplete if toggle is disabled * Fix test names * Remove unnecessary mocks * [Upgrade Assistant] Update copy to use "issues" instead of "warnings" (#111817) * Create common deprecation issues panel component in UA (#111231) * Refine success state behavior and add tests. * Refactor components into a components directory. * Refactor SCSS to colocate styles with their components. * Refactor tests to reduce boilerplate and clarify conditions under test. * [Upgrade Assistant] Fix Kibana deprecations warning message * [Upgrade Assistant] Add support for API keys when reindexing (#111451) * [Upgrade Assistant] Update readme (#112154) * [Upgrade Assistant] Make infra plugin optional (#111960) * Make infra plugin optional * Fix CR requests * [Upgrade Assistant] Improve flyout information architecture (#111713) * Make sure longstrings inside flyout body are text-wrap * Show resolved badge for reindex flyout and row * Finish off rest of ES deprecation flyouts * Refactor deprecation badge into its own component * Add tests for kibana deprecations * Add tests for es deprecations * Also check that we have status=error before rendering error callout * Check for non-complete states instead of just error * Small refactor * Default deprecation is not resolvable * Add a bit more spacing between title and badge * Address CR changes * Use EuiSpacer instead of flexitems * [Upgrade Assistant] Update readme (#112195) * [Upgrade Assistant] Add integration tests for Overview page (#111370) * Add a11y tests for when overview page has toggle enabled * Add functional and accessibility tests for overview page * Load test files * Fix linter error * Navigate before asserting * Steps have now completion state * Remove duped word * Run setup only once, not per test * Address CR changes * No need to renavigate to the page Co-authored-by: Kibana Machine <[email protected]> * [Upgrade Assistant] Add note about compatibility headers (#110469) * Improve error states for Upgrade Assistant deprecation issues (#112457) * Simplify error state for deprecation issues panels. Remove <EsStatsError />. * Rename components from stats -> panel. * Create common error-reporting component for use in both Kibana and ES deprecations pages. * Align order of loading, error, and success states between these pages. * Change references to 'deprecations' -> 'deprecation issues'. * Fix tests for panels. * Add API integration test for handling auth error. * Fix TS errors. Co-authored-by: Kibana Machine <[email protected]> * Change count poll time to 15s (#112669) * [Upgrade Assistant] Add permissions check to logs step (#112420) * [Upgrade Assistant] Refactor telemetry (#112177) * [Upgrade Assistant] Check for ML upgrade mode before enabling flyout actions (#112555) * Add missing error handlers for deprecation logging route (#113109) * [Upgrade Assistant] Batch reindex docs (#112960) * [UA] Added batch reindexing docs link to the ES deprecations page. Added a link from "batch reindexing" docs page to "start or resume reindex" docs page and from there to ES reindexing docs page. Also renamed "reindexing operation" to "reindexing task" for consistency. * [Upgrade Assistant] Added docs build files * Update x-pack/plugins/upgrade_assistant/public/application/components/es_deprecations/es_deprecations.tsx Co-authored-by: James Rodewig <[email protected]> * Update x-pack/plugins/upgrade_assistant/public/application/components/es_deprecations/es_deprecations.tsx Co-authored-by: James Rodewig <[email protected]> * [Upgrade Assistant] Added review suggestions and fixed eslint issues Co-authored-by: James Rodewig <[email protected]> Co-authored-by: Kibana Machine <[email protected]> * [Upgrade Assistant] Improve error messages for GET /api/upgrade_assistant/reindex/<index> (#112961) * Add support for single manual steps to Upgrade Assistant. (#113344) * Revert "[Upgrade Assistant] Refactor telemetry (#112177)" (#113665) This reverts commit 991d24b. * [Upgrade Assistant] Use skipFetchFields when creating the indexPattern in order to avoid errors if index doesn't exist (#113821) * Use skipFetchFields when creating the indexPatter in order to avoid errors when index doesnt exist * Address CR feedback Co-authored-by: Kibana Machine <[email protected]> * [Upgrade Assistant] Hide system indices from es deprecations list (#113627) * Refactor reindex routes into separate single and batch reindex files. Apply version precheck to batch routes. (#113822) * [Upgrade Assistant] Remove ML/Watcher logic (#113224) * Add show upgrade flag to url (#114243) * [Upgrade Assistant] Delete deprecation log cache (#114113) * [Upgrade Assistant] Add upgrade system indices section (#110593) * [Upgrade Assistant] Reindexing progress (#114275) * [Upgrade Assistant] Added reindexing progress in % to the reindex flyout and es deprecations table * [Upgrade Assistant] Renamed first argument in `getReindexProgressLabel` to `reindexTaskPercComplete` for consistency Co-authored-by: Kibana Machine <[email protected]> * [Upgrade Assistant] Remove Fix manually heading when there are no manual steps * Add rolling upgrade interstitials to UA (#112907) * Refactor FixLogsStep to be explicit in which props are passed to DeprecationLoggingToggle. * Centralize error-handling logic in the api service, instead of handling it within each individual API request. Covers: - Cloud backup status - ES deprecations - Deprecation logging - Remove index settings - ML - Reindexing Also: - Handle 426 error state and surface in UI. - Move ResponseError type into common/types. * Add note about intended use case of status API route. * Add endpoint dedicated to surfacing the cluster upgrade state, and a client-side poll. * Merge App and AppWithRouter components. * [Upgrade Assistant] Added "accept changes" header to the warnings list in the reindex flyout (#114798) * Refactor kibana deprecation tests (#114763) Co-authored-by: Kibana Machine <[email protected]> * Fix linter issues * Remove unused translation * Prefer master changes over 7.x for ml docs * Prefer master changes over 7.x * Skip tests * Move everything to a single describe * Fix types * Add missing prop to mock * [Upgrade Assistant] Removed "closed index" warning from reindex flyout (#114861) * [Upgrade Assistant] Removed "closed index" warning that reindexing might take longer than usual, which is not the case * [Upgrade Assistant] Also deleted i18n strings that are not needed anymore * Add LevelIconTips to be more explicit about the difference between critical and warning issues. (#115121) * Extract common DeprecationFlyoutLearnMoreLink component and change wording to 'Learn more'. (#115117) * [Upgrade Assistant] Reindexing cancellation (#114636) * [Upgrade Assistant] Updated the reindexing cancellation to look less like an error * [Upgrade Assistant] Fixed an i18n issue and updated a jest snapshot * [Upgrade Assistant] Updated cancelled reindexing state with a unified label and cross icon * [Upgrade Assistant] Fixed snapshot test * [Upgrade Assistant] Updated spacing to the reindex cancel button Co-authored-by: Kibana Machine <[email protected]> * Fix test errors (#115183) Co-authored-by: Kibana Machine <[email protected]> * [Upgrade Assistant] Overview page UI clean up (#115258) - Scaling down deprecation issue panel title size to flow with typographic hierarchy. - Removing panel around deprecation logging switch to reduce visual elements. - Using success instead of green color for migration complete message. * Revert "Revert "[Upgrade Assistant] Refactor telemetry (#112177)" (#113665)" (#114804) This reverts commit c385d49. * Add migration to remove obsolete attributes from telemetry saved object. * Refactor UA telemetry constants by extracting it from common/types. * [Upgrade Assistant] Rename upgrade_status to migration_status (#114755) * [Upgrade Assistant] Swapped reindexing flyouts order (#115046) * [Upgrade Assistant] Changed reindexing steps order, replaced a warning callout with a text element * [Upgrade Assistant] Fixed reindex flyout test and changed warning callout from danger color to warning color * [Upgrade Assistant] Fixed the correct status to show warnings * [Upgrade Assistant] Fixed i18n strings * [Upgrade Assistant] Moved reindex with warnings logic into a function * [Upgrade Assistant] Updated reindex flyout copy * [Upgrade Assistant] Also added a trailing period to the reindex step 3 * [Upgrade Assistant] Fixed i18n strings and step 3 wording * [Upgrade Assistant] Added docs changes Co-authored-by: Kibana Machine <[email protected]> * [Upgrade Assistant] Hide features that don't need to be migrated from flyout (#115535) * Filter out system indices that dont require migration on server side * Rename to attrs to migration * Update flyout snapshot. * Refine Upgrade Assistant copy. (#115472) * Remove unused file * Fix kibanaVersion dep * Updated config.ts to fix UA test UA functional API integration test to check cloud backup status creates a snapshot repo, which fails to be created with my changes to config.ts `'path.repo=/tmp/repo,/tmp/repo_1,/tmp/repo_2,'`. Adding `/tmp/cloud-snapshots/'` to the config fixes the test. * Address CR changes * Add missing error handler for system indices migration (#116088) * Fix broken tests * Fix test * Skip tests * Fix linter errors and import * [Upgrade Assistant] Fix typo in retrieval of cluster settings (#116335) * Fix typos * Fix typo also in server tests * Make sure log collection remains enabled throughout the test Co-authored-by: Kibana Machine <[email protected]> * Fix type errors * Fix integration test types * Fix accessibility test type errors * Fix linter errors in shared_imports * Fix functional test types Co-authored-by: CJ Cenizal <[email protected]> Co-authored-by: Alison Goryachev <[email protected]> Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Yulia Čech <[email protected]> Co-authored-by: James Rodewig <[email protected]> Co-authored-by: Dmitry Borodyansky <[email protected]> * commit with @elastic.co email Co-authored-by: Ignacio Rivas <[email protected]> Co-authored-by: CJ Cenizal <[email protected]> Co-authored-by: Alison Goryachev <[email protected]> Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Yulia Čech <[email protected]> Co-authored-by: James Rodewig <[email protected]> Co-authored-by: Dmitry Borodyansky <[email protected]>

sabarasaba self-assigned this Oct 14, 2021

sabarasaba added Feature:Upgrade Assistant release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more backport:skip This commit does not require backporting labels Oct 14, 2021

sebelga mentioned this pull request Oct 14, 2021

[Stack management apps] Deprecate "enabled" Kibana setting #114768

Merged

sabarasaba force-pushed the ua/forwardport_from_7.x branch from 02911a9 to 9efd7a1 Compare October 15, 2021 08:43

sabarasaba marked this pull request as ready for review October 19, 2021 15:05

sabarasaba requested review from a team as code owners October 19, 2021 15:05

sabarasaba force-pushed the ua/forwardport_from_7.x branch from 32946a8 to 08643be Compare October 20, 2021 08:27

sabarasaba requested a review from a team as a code owner October 20, 2021 08:27

sabarasaba added the v8.0.0 label Oct 20, 2021

sabarasaba requested review from yuliacech and cjcenizal October 20, 2021 08:29

yuliacech reviewed Oct 20, 2021

View reviewed changes

cjcenizal suggested changes Oct 20, 2021

View reviewed changes

TinaHeiligers approved these changes Oct 20, 2021

View reviewed changes

sabarasaba mentioned this pull request Oct 25, 2021

Failing test: X-Pack Accessibility Tests.x-pack/test/accessibility/apps/upgrade_assistant·ts - Upgrade Assistant Elasticsearch deprecations page Index settings deprecation flyout #115859

Closed

cjcenizal approved these changes Oct 25, 2021

View reviewed changes

Fix link to Cloud deployment URL in upgrade step. (elastic#109528)

05d2572

sabarasaba added 7 commits October 26, 2021 18:44

Fix kibanaVersion dep

45bd346

Address CR changes

cd2be50

Add missing error handler for system indices migration (elastic#116088)

145cad0

Fix broken tests

ea8adac

Fix test

03a32e8

Skip tests

c873873

sabarasaba force-pushed the ua/forwardport_from_7.x branch from 5076ff9 to c873873 Compare October 26, 2021 16:48

sabarasaba and others added 8 commits October 26, 2021 20:27

Fix linter errors and import

6d4e086

Merge branch 'main' into ua/forwardport_from_7.x

6ea3df4

[Upgrade Assistant] Fix typo in retrieval of cluster settings (elasti…

41932b9

…c#116335) * Fix typos * Fix typo also in server tests * Make sure log collection remains enabled throughout the test Co-authored-by: Kibana Machine <[email protected]>

Fix type errors

a43943f

Fix integration test types

69d6a51

Fix accessibility test type errors

5c2845b

Fix linter errors in shared_imports

db0b847

Fix functional test types

2c629dd

Merge branch 'main' into ua/forwardport_from_7.x

cbb1884

yuliacech approved these changes Nov 9, 2021

View reviewed changes

ryankeairns approved these changes Nov 9, 2021

View reviewed changes

sabarasaba merged commit 8819bd8 into elastic:main Nov 9, 2021

spalger mentioned this pull request Nov 11, 2021

[8.0] [Upgrade Assistant] Forwardport from 7.x (#114966) #118410

Merged

cjcenizal mentioned this pull request Nov 22, 2021

[UA] ES deprecation logs in its own page #118659

Merged

3 tasks

sabarasaba mentioned this pull request Jan 12, 2022

[Upgrade Assistant] Skip reindexing api integration tests #122772

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Upgrade Assistant] Forwardport from 7.x #114966

[Upgrade Assistant] Forwardport from 7.x #114966

sabarasaba commented Oct 14, 2021 •

edited

Loading

sabarasaba commented Oct 14, 2021

sabarasaba commented Oct 15, 2021

kibanamachine commented Oct 15, 2021

elasticmachine commented Oct 19, 2021

kibanamachine commented Oct 20, 2021

Standard Out

Stack Trace

References to deprecated APIs

yuliacech left a comment

cjcenizal left a comment •

edited

Loading

cjcenizal Oct 20, 2021 •

edited

Loading

cjcenizal Oct 20, 2021 •

edited

Loading

cjcenizal Oct 20, 2021 •

edited

Loading

jloleysens Oct 21, 2021

TinaHeiligers left a comment

cjcenizal commented Oct 21, 2021

sebelga commented Oct 21, 2021

sabarasaba commented Oct 25, 2021

cjcenizal left a comment

lockewritesdocs commented Nov 8, 2021

kibanamachine commented Nov 8, 2021

References to deprecated APIs

yuliacech left a comment

		@@ -266,76 +236,5 @@ export const reindexActionsFactory = (

		return flatSettings.body[indexName];
		},

	async getFlatSettings(indexName: string, withTypeName?: boolean) {
	let flatSettings;

	if (versionService.getMajorVersion() === 7 && withTypeName) {

		@@ -476,23 +351,6 @@ export const reindexServiceFactory = (
		});

		@@ -223,7 +232,7 @@ export class ReindexWorker {
		reindexOp = await swallowExceptions(service.processNextStep, this.log)(reindexOp);

	// Setup a ReindexService specific to these credentials.
	const fakeRequest: FakeRequest = { headers: credential };

	const scopedClusterClient = this.clusterClient.asScoped(fakeRequest);
	const callAsCurrentUser = scopedClusterClient.asCurrentUser;
	const actions = reindexActionsFactory(this.client, callAsCurrentUser);

	const service = reindexServiceFactory(callAsCurrentUser, actions, this.log, this.licensing);

[Upgrade Assistant] Forwardport from 7.x #114966

[Upgrade Assistant] Forwardport from 7.x #114966

Conversation

sabarasaba commented Oct 14, 2021 • edited Loading

sabarasaba commented Oct 14, 2021

sabarasaba commented Oct 15, 2021

kibanamachine commented Oct 15, 2021

elasticmachine commented Oct 19, 2021

kibanamachine commented Oct 20, 2021

💛 Build succeeded, but was flaky

Test Failures

Standard Out

Stack Trace

Metrics [docs]

Module Count

Async chunks

Page load bundle

Saved Objects .kibana field count

References to deprecated APIs

History

yuliacech left a comment

Choose a reason for hiding this comment

cjcenizal left a comment • edited Loading

Choose a reason for hiding this comment

Process

Findings

setup_environment.tsx

service.mock.ts

constants.ts

checklist_step.test.tsx

warning_step.test.tsx

warning_step.test.tsx

types.ts

config.ts

reindex_actions.ts

reindex_service.ts

worker.ts

cjcenizal Oct 20, 2021 • edited Loading

Choose a reason for hiding this comment

cjcenizal Oct 20, 2021 • edited Loading

Choose a reason for hiding this comment

cjcenizal Oct 20, 2021 • edited Loading

Choose a reason for hiding this comment

jloleysens Oct 21, 2021

Choose a reason for hiding this comment

TinaHeiligers left a comment

Choose a reason for hiding this comment

cjcenizal commented Oct 21, 2021

sebelga commented Oct 21, 2021

sabarasaba commented Oct 25, 2021

cjcenizal left a comment

Choose a reason for hiding this comment

lockewritesdocs commented Nov 8, 2021

kibanamachine commented Nov 8, 2021

💛 Build succeeded, but was flaky

Test Failures

Metrics [docs]

Module Count

Async chunks

Page load bundle

Saved Objects .kibana field count

References to deprecated APIs

History

yuliacech left a comment

Choose a reason for hiding this comment

sabarasaba commented Oct 14, 2021 •

edited

Loading

cjcenizal left a comment •

edited

Loading

cjcenizal Oct 20, 2021 •

edited

Loading

cjcenizal Oct 20, 2021 •

edited

Loading

cjcenizal Oct 20, 2021 •

edited

Loading