Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Ensure APM deprecation documentationUrl point to correct doc branch #115401

Merged
merged 3 commits into from
Oct 18, 2021
Merged

[APM] Ensure APM deprecation documentationUrl point to correct doc branch #115401

merged 3 commits into from
Oct 18, 2021

Conversation

cauemarcondes
Copy link
Contributor

closes #114756

@cauemarcondes cauemarcondes requested a review from a team as a code owner October 18, 2021 15:45
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Oct 18, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@cauemarcondes cauemarcondes added auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes v7.16.0 labels Oct 18, 2021
ogupte
ogupte approved these changes Oct 18, 2021
View reviewed changes
Copy link
Contributor

@ogupte ogupte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cauemarcondes cauemarcondes enabled auto-merge (squash) October 18, 2021 19:22
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cauemarcondes cauemarcondes merged commit 75048dc into elastic:master Oct 18, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 18, 2021
@cauemarcondes @kibanamachine
[APM] Ensure APM deprecation documentationUrl point to correct doc br…
ce48d69 
…anch (elastic#115401)

* using branch in the url

* fixing TS
@kibanamachine kibanamachine mentioned this pull request Oct 18, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Oct 19, 2021
@kibanamachine @cauemarcondes
[APM] Ensure APM deprecation documentationUrl point to correct doc br…
635859f 
…anch (#115401) (#115482)

* using branch in the url

* fixing TS

Co-authored-by: Cauê Marcondes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogupte ogupte ogupte approved these changes

@sorenlouv sorenlouv sorenlouv approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v7.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Ensure APM deprecation documentationUrl point to correct doc branch
5 participants
@cauemarcondes @elasticmachine @kibanamachine @sorenlouv @ogupte